diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-01-20 13:40:20 +0100 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-01-22 12:41:23 +0000 |
| commit | 7961cea6d1041e3e454dae6a1da660b453efd238 (patch) | |
| tree | c0eeb4a9ff9ba32986289c1653d9608e53ccb444 /chromium/docs/sheriff.md | |
| parent | b7034d0803538058e5c9d904ef03cf5eab34f6ef (diff) | |
| download | qtwebengine-chromium-7961cea6d1041e3e454dae6a1da660b453efd238.tar.gz | |
BASELINE: Update Chromium to 78.0.3904.130
Change-Id: If185e0c0061b3437531c97c9c8c78f239352a68b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/docs/sheriff.md')
| -rw-r--r-- | chromium/docs/sheriff.md | 20 |
1 files changed, 19 insertions, 1 deletions
diff --git a/chromium/docs/sheriff.md b/chromium/docs/sheriff.md index feb3d9bf7b2..a56b939c27b 100644 --- a/chromium/docs/sheriff.md +++ b/chromium/docs/sheriff.md @@ -86,6 +86,16 @@ enough to appear in the channel at the top level as well - this helps keep the main channel clear of smaller status updates and makes it more like an index of the threads. +### Monorail + +[Monorail] is our bug tracker. Hopefully you are already familiar with it. +When sheriffing, you use Monorail to: + +* Look for existing bugs +* File bugs when you revert CLs, explaining what happened and including any + stack traces or error messages +* File bugs when you disable tests, again with as much information as practical + ### The Waterfall The [CI console page], commonly referred to as "the waterfall" because of how it @@ -267,7 +277,8 @@ If yes: * Start a new thread in Slack for one of the failures * Investigate the failure and figure out why it happened - see the "diagnosing build failures" section below -* Fix what went wrong +* Fix what went wrong, remembering to file a bug to document both the failure + and your fix * Snooze the failure, with a link to the bug if your investigation resulted in a bug @@ -365,6 +376,13 @@ file called [SlowTests] that lists these tests and gives them more time to run; for Chromium tests you can just mark these as `DISABLED_` in those configurations if you want. +When marking a Blink test as slow/flaky/etc, it's often not clear who to send +the CL to, especially if the test is a WPT test imported from another repository +or hasn't been edited in a while. In those situations, or when you just can't +find the right owner for a test, feel free to TBR your CL to one of the other +sheriffs on your rotation and kick it into the Blink triage queue (ie: mark the +bug as Untriaged with component Blink). + ### Infra Breakage If a bot turns purple rather than red, that indicates an infra failure of some |