diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
| commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
| tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/docs/contributing.md | |
| parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
| download | qtwebengine-chromium-85-based.tar.gz | |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/docs/contributing.md')
| -rw-r--r-- | chromium/docs/contributing.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/chromium/docs/contributing.md b/chromium/docs/contributing.md index bbaaacd315d..753586fcc57 100644 --- a/chromium/docs/contributing.md +++ b/chromium/docs/contributing.md @@ -327,6 +327,10 @@ general rules of thumb can be helpful in navigating how to structure changes: find a product in the Chromium repositories that depends on that line of code or else the line of code should be removed. + Completely new additions to the project (for example, support for a new OS + or architecture, or a new top-level directory for a new sub-project) must + be approved by [//ENG_REVIEW_OWNERS](../ENG_REVIEW_OWNERS). + - **Code should only be moved to a central location (e.g., //base) when multiple consumers would benefit.** We should resist the temptation to build overly generic common libraries as that can lead to code bloat and |