diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
| commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
| tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/docs/code_reviews.md | |
| parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
| download | qtwebengine-chromium-85-based.tar.gz | |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/docs/code_reviews.md')
| -rw-r--r-- | chromium/docs/code_reviews.md | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/chromium/docs/code_reviews.md b/chromium/docs/code_reviews.md index 1fc688d17d4..0c6df1b3802 100644 --- a/chromium/docs/code_reviews.md +++ b/chromium/docs/code_reviews.md @@ -3,9 +3,8 @@ Code reviews are a central part of developing high-quality code for Chromium. All changes must be reviewed. -The bigger patch-upload-and-land process is covered in more detail the -[contributing code](https://www.chromium.org/developers/contributing-code) -page. +The general patch, upload, and land process is covered in more detail in the +[contributing code](contributing.md) page. # Code review policies @@ -186,8 +185,8 @@ Otherwise the reviewer won't know to review the patch. * Add the reviewer's email address in the code review tool's reviewer field like normal. - * Add a line "Tbr:<reviewer's email>" to the bottom of the change list - description. e.g. `Tbr:reviewer1@chromium.org,reviewer2@chromium.org` + * Add a line "Tbr: <reviewer's email>" to the bottom of the change list + description. e.g. `Tbr: reviewer1@chromium.org,reviewer2@chromium.org` * Type a message so that the owners in the TBR list can understand who is responsible for reviewing what, as part of their post-commit review |