diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-02-04 17:20:24 +0100 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-02-12 08:15:25 +0000 |
| commit | 8fa0776f1f79e91fc9c0b9c1ba11a0a29c05196b (patch) | |
| tree | 788d8d7549712682703a0310ca4a0f0860d4802b /chromium/docs/code_review_owners.md | |
| parent | 606d85f2a5386472314d39923da28c70c60dc8e7 (diff) | |
| download | qtwebengine-chromium-8fa0776f1f79e91fc9c0b9c1ba11a0a29c05196b.tar.gz | |
BASELINE: Update Chromium to 98.0.4758.90
Change-Id: Ib7c41539bf8a8e0376bd639f27d68294de90f3c8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/docs/code_review_owners.md')
| -rw-r--r-- | chromium/docs/code_review_owners.md | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/chromium/docs/code_review_owners.md b/chromium/docs/code_review_owners.md index d7709cea973..7f44b389bd2 100644 --- a/chromium/docs/code_review_owners.md +++ b/chromium/docs/code_review_owners.md @@ -34,6 +34,15 @@ duration, using a special label `Owners-Override`. However, these changes will still need a second human (anyone with committers `Code-Review +1` powers) to vote. +### What should I do when I need to get Owners-Override for one-off CLs? + +One-off CLs do not need to go through Large Scale Changes. If the CLs make +only mechanical changes associated with changes in //base/ APIs, //build/ APIs, +//content/ APIs, //url/ APIs or //third_party/blink/public/APIs, the API owners can set `Owners-Override`. + +For other one-off CLs, [Chrome Eng Review members](https://chromium.googlesource.com/chromium/src/+/HEAD/ENG_REVIEW_OWNERS) +can set `Owners-Override`. + ### How does Rubber Stamper bot work? Rubber Stamper applies the Bot-Commit label to conforming CLs, allowing them to @@ -47,6 +56,10 @@ that would allow anyone who can create a revert or cherry-pick to land it without any other person being involved (e.g. the silent revert of security patches). +When you need to get Owners-Override for sheriffing CLs, reach out to Active +Sheriffs or Release Program Managers. If they are not available, send an email +to lsc-owners-override@chromium.org. + ### Will trivial files require code-review? Rubber Stamper auto-reviewer (described above) reviews CLs that meet strict |