summaryrefslogtreecommitdiff
path: root/chromium/components/tracing
diff options
context:
space:
mode:
authorZeno Albisser <zeno.albisser@theqtcompany.com>2014-12-05 15:04:29 +0100
committerAndras Becsi <andras.becsi@theqtcompany.com>2014-12-09 10:49:28 +0100
commitaf6588f8d723931a298c995fa97259bb7f7deb55 (patch)
tree060ca707847ba1735f01af2372e0d5e494dc0366 /chromium/components/tracing
parent2fff84d821cc7b1c785f6404e0f8091333283e74 (diff)
downloadqtwebengine-chromium-af6588f8d723931a298c995fa97259bb7f7deb55.tar.gz
BASELINE: Update chromium to 40.0.2214.28 and ninja to 1.5.3.
Change-Id: I759465284fd64d59ad120219cbe257f7402c4181 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
Diffstat (limited to 'chromium/components/tracing')
-rw-r--r--chromium/components/tracing/OWNERS4
-rw-r--r--chromium/components/tracing/child_trace_message_filter.cc13
-rw-r--r--chromium/components/tracing/child_trace_message_filter.h12
-rw-r--r--chromium/components/tracing/tracing_messages.h6
4 files changed, 19 insertions, 16 deletions
diff --git a/chromium/components/tracing/OWNERS b/chromium/components/tracing/OWNERS
index 7fb13eeeff4..6941b2cb792 100644
--- a/chromium/components/tracing/OWNERS
+++ b/chromium/components/tracing/OWNERS
@@ -4,12 +4,12 @@ nduca@chromium.org
# Changes to IPC messages require a security review to avoid introducing
# new sandbox escapes.
per-file *_messages*.h=set noparent
-per-file *_messages*.h=cevans@chromium.org
per-file *_messages*.h=dcheng@chromium.org
per-file *_messages*.h=inferno@chromium.org
per-file *_messages*.h=jln@chromium.org
per-file *_messages*.h=jschuh@chromium.org
per-file *_messages*.h=kenrb@chromium.org
+per-file *_messages*.h=mkwst@chromium.org
per-file *_messages*.h=nasko@chromium.org
-per-file *_messages*.h=palmer@chromium.org
per-file *_messages*.h=tsepez@chromium.org
+per-file *_messages*.h=wfh@chromium.org
diff --git a/chromium/components/tracing/child_trace_message_filter.cc b/chromium/components/tracing/child_trace_message_filter.cc
index 3df0f7075fc..fe13ff57dd0 100644
--- a/chromium/components/tracing/child_trace_message_filter.cc
+++ b/chromium/components/tracing/child_trace_message_filter.cc
@@ -50,7 +50,7 @@ ChildTraceMessageFilter::~ChildTraceMessageFilter() {}
void ChildTraceMessageFilter::OnBeginTracing(
const std::string& category_filter_str,
base::TimeTicks browser_time,
- int options) {
+ const std::string& options) {
#if defined(__native_client__)
// NaCl and system times are offset by a bit, so subtract some time from
// the captured timestamps. The value might be off by a bit due to messaging
@@ -59,11 +59,12 @@ void ChildTraceMessageFilter::OnBeginTracing(
browser_time;
TraceLog::GetInstance()->SetTimeOffset(time_offset);
#endif
-
+ base::debug::TraceOptions trace_options;
+ trace_options.SetFromString(options);
TraceLog::GetInstance()->SetEnabled(
base::debug::CategoryFilter(category_filter_str),
base::debug::TraceLog::RECORDING_MODE,
- static_cast<base::debug::TraceLog::Options>(options));
+ trace_options);
}
void ChildTraceMessageFilter::OnEndTracing() {
@@ -80,11 +81,13 @@ void ChildTraceMessageFilter::OnEndTracing() {
void ChildTraceMessageFilter::OnEnableMonitoring(
const std::string& category_filter_str,
base::TimeTicks browser_time,
- int options) {
+ const std::string& options) {
+ base::debug::TraceOptions trace_options;
+ trace_options.SetFromString(options);
TraceLog::GetInstance()->SetEnabled(
base::debug::CategoryFilter(category_filter_str),
base::debug::TraceLog::MONITORING_MODE,
- static_cast<base::debug::TraceLog::Options>(options));
+ trace_options);
}
void ChildTraceMessageFilter::OnDisableMonitoring() {
diff --git a/chromium/components/tracing/child_trace_message_filter.h b/chromium/components/tracing/child_trace_message_filter.h
index 5bd993e80e4..daa00ee3bda 100644
--- a/chromium/components/tracing/child_trace_message_filter.h
+++ b/chromium/components/tracing/child_trace_message_filter.h
@@ -21,22 +21,22 @@ class ChildTraceMessageFilter : public IPC::MessageFilter {
explicit ChildTraceMessageFilter(base::MessageLoopProxy* ipc_message_loop);
// IPC::MessageFilter implementation.
- virtual void OnFilterAdded(IPC::Sender* sender) OVERRIDE;
- virtual void OnFilterRemoved() OVERRIDE;
- virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+ void OnFilterAdded(IPC::Sender* sender) override;
+ void OnFilterRemoved() override;
+ bool OnMessageReceived(const IPC::Message& message) override;
protected:
- virtual ~ChildTraceMessageFilter();
+ ~ChildTraceMessageFilter() override;
private:
// Message handlers.
void OnBeginTracing(const std::string& category_filter_str,
base::TimeTicks browser_time,
- int options);
+ const std::string& options);
void OnEndTracing();
void OnEnableMonitoring(const std::string& category_filter_str,
base::TimeTicks browser_time,
- int options);
+ const std::string& options);
void OnDisableMonitoring();
void OnCaptureMonitoringSnapshot();
void OnGetTraceBufferPercentFull();
diff --git a/chromium/components/tracing/tracing_messages.h b/chromium/components/tracing/tracing_messages.h
index 1107baf3051..ff891a0edaa 100644
--- a/chromium/components/tracing/tracing_messages.h
+++ b/chromium/components/tracing/tracing_messages.h
@@ -19,7 +19,7 @@
IPC_MESSAGE_CONTROL3(TracingMsg_BeginTracing,
std::string /* category_filter_str */,
base::TimeTicks /* browser_time */,
- int /* base::debug::TraceLog::Options */)
+ std::string /* base::debug::TraceOptions */)
// Sent to all child processes to disable trace event recording.
IPC_MESSAGE_CONTROL0(TracingMsg_EndTracing)
@@ -28,7 +28,7 @@ IPC_MESSAGE_CONTROL0(TracingMsg_EndTracing)
IPC_MESSAGE_CONTROL3(TracingMsg_EnableMonitoring,
std::string /* category_filter_str */,
base::TimeTicks /* browser_time */,
- int /* base::debug::TraceLog::Options */)
+ std::string /* base::debug::TraceOptions */)
// Sent to all child processes to stop monitoring.
IPC_MESSAGE_CONTROL0(TracingMsg_DisableMonitoring)
@@ -48,7 +48,7 @@ IPC_MESSAGE_CONTROL2(TracingMsg_SetWatchEvent,
IPC_MESSAGE_CONTROL0(TracingMsg_CancelWatchEvent)
// Sent everytime when a watch event is matched.
-IPC_MESSAGE_CONTROL0(TracingHostMsg_WatchEventMatched);
+IPC_MESSAGE_CONTROL0(TracingHostMsg_WatchEventMatched)
// Notify the browser that this child process supports tracing.
IPC_MESSAGE_CONTROL0(TracingHostMsg_ChildSupportsTracing)