diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/components/permissions/android/java/src | |
parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
download | qtwebengine-chromium-85-based.tar.gz |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/components/permissions/android/java/src')
-rw-r--r-- | chromium/components/permissions/android/java/src/org/chromium/components/permissions/PermissionDialogController.java | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/chromium/components/permissions/android/java/src/org/chromium/components/permissions/PermissionDialogController.java b/chromium/components/permissions/android/java/src/org/chromium/components/permissions/PermissionDialogController.java index b1d120e721a..2b05abc83ea 100644 --- a/chromium/components/permissions/android/java/src/org/chromium/components/permissions/PermissionDialogController.java +++ b/chromium/components/permissions/android/java/src/org/chromium/components/permissions/PermissionDialogController.java @@ -5,7 +5,6 @@ package org.chromium.components.permissions; import android.annotation.SuppressLint; -import android.app.Activity; import android.content.Context; import android.content.Intent; import android.os.Build; @@ -15,6 +14,7 @@ import androidx.annotation.IntDef; import androidx.annotation.VisibleForTesting; import org.chromium.base.BuildInfo; +import org.chromium.base.ContextUtils; import org.chromium.base.annotations.CalledByNative; import org.chromium.ui.modaldialog.DialogDismissalCause; import org.chromium.ui.modaldialog.ModalDialogManager; @@ -144,12 +144,14 @@ public class PermissionDialogController assert mState == State.NOT_SHOWING; mDialogDelegate = mRequestQueue.remove(0); - Activity activity = mDialogDelegate.getWindow().getActivity().get(); + // Use the context to access resources instead of the activity because the activity may not + // have the correct resources in some cases (e.g. WebLayer). + Context context = mDialogDelegate.getWindow().getContext().get(); // It's possible for the activity to be null if we reach here just after the user // backgrounds the browser and cleanup has happened. In that case, we can't show a prompt, // so act as though the user dismissed it. - if (activity == null) { + if (ContextUtils.activityFromContext(context) == null) { // TODO(timloh): This probably doesn't work, as this happens synchronously when creating // the PermissionPromptAndroid, so the PermissionRequestManager won't be ready yet. mDialogDelegate.onDismiss(); @@ -167,7 +169,7 @@ public class PermissionDialogController mModalDialogManager = mDialogDelegate.getWindow().getModalDialogManager(); mDialogModel = PermissionDialogModel.getModel( - this, mDialogDelegate, () -> showFilteredTouchEventDialog(activity)); + this, mDialogDelegate, () -> showFilteredTouchEventDialog(context)); mModalDialogManager.showDialog(mDialogModel, ModalDialogManager.ModalDialogType.TAB); mState = State.PROMPT_OPEN; } |