diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/base/version_unittest.cc | |
parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
download | qtwebengine-chromium-85-based.tar.gz |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/base/version_unittest.cc')
-rw-r--r-- | chromium/base/version_unittest.cc | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/chromium/base/version_unittest.cc b/chromium/base/version_unittest.cc index 12b806399d0..4d04083801e 100644 --- a/chromium/base/version_unittest.cc +++ b/chromium/base/version_unittest.cc @@ -196,4 +196,28 @@ TEST(VersionTest, IsValidWildcardString) { } } +TEST(VersionTest, LeadingZeros) { + { + // Leading zeros in the first component are not allowed. + base::Version v("01.1"); + EXPECT_FALSE(v.IsValid()); + } + + { + // Leading zeros in subsequent components are allowed (and this behavior is + // now important for compatibility with existing modules, like extensions), + // but are ignored because the value is parsed as an integer... + base::Version v1("1.01"); + EXPECT_TRUE(v1.IsValid()); + // ...and as a result, v1.01 == v1.1. + EXPECT_EQ("1.1", v1.GetString()); + base::Version v2("1.1"); + EXPECT_EQ(v1, v2); + } + + // Similarly, since leading zeros are ignored, v1.02 > v1.1 (because + // v1.02 is translated to 1.2). + EXPECT_GT(base::Version("1.02"), base::Version("1.1")); +} + } // namespace |