diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-12 14:27:29 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-10-13 09:35:20 +0000 |
commit | c30a6232df03e1efbd9f3b226777b07e087a1122 (patch) | |
tree | e992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/base/run_loop.cc | |
parent | 7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff) | |
download | qtwebengine-chromium-85-based.tar.gz |
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/base/run_loop.cc')
-rw-r--r-- | chromium/base/run_loop.cc | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/chromium/base/run_loop.cc b/chromium/base/run_loop.cc index 234e3fdc47b..af1ca56f5b4 100644 --- a/chromium/base/run_loop.cc +++ b/chromium/base/run_loop.cc @@ -136,7 +136,7 @@ void RunLoop::RunUntilIdle() { void RunLoop::Quit() { // Thread-safe. - // This can only be hit if run_loop->Quit() is called directly (QuitClosure() + // This can only be hit if RunLoop::Quit() is called directly (QuitClosure() // proxies through ProxyToTaskRunner() as it can only deref its WeakPtr on // |origin_task_runner_|). if (!origin_task_runner_->RunsTasksInCurrentSequence()) { @@ -155,7 +155,7 @@ void RunLoop::Quit() { void RunLoop::QuitWhenIdle() { // Thread-safe. - // This can only be hit if run_loop->QuitWhenIdle() is called directly + // This can only be hit if RunLoop::QuitWhenIdle() is called directly // (QuitWhenIdleClosure() proxies through ProxyToTaskRunner() as it can only // deref its WeakPtr on |origin_task_runner_|). if (!origin_task_runner_->RunsTasksInCurrentSequence()) { @@ -168,9 +168,9 @@ void RunLoop::QuitWhenIdle() { } RepeatingClosure RunLoop::QuitClosure() { - // Obtaining the QuitClosure() is not thread-safe; either post the - // QuitClosure() from the run thread or invoke Quit() directly (which is - // thread-safe). + // Obtaining the QuitClosure() is not thread-safe; either obtain the + // QuitClosure() from the owning thread before Run() or invoke Quit() directly + // (which is thread-safe). DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); allow_quit_current_deprecated_ = false; @@ -180,9 +180,9 @@ RepeatingClosure RunLoop::QuitClosure() { } RepeatingClosure RunLoop::QuitWhenIdleClosure() { - // Obtaining the QuitWhenIdleClosure() is not thread-safe; either post the - // QuitWhenIdleClosure() from the run thread or invoke QuitWhenIdle() directly - // (which is thread-safe). + // Obtaining the QuitWhenIdleClosure() is not thread-safe; either obtain the + // QuitWhenIdleClosure() from the owning thread before Run() or invoke + // QuitWhenIdle() directly (which is thread-safe). DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); allow_quit_current_deprecated_ = false; |