diff options
| author | Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io> | 2022-02-02 08:40:32 +0100 |
|---|---|---|
| committer | Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io> | 2022-02-04 13:42:35 +0000 |
| commit | 8ed95b29cf2090ffd8ba161dc16a0f661429caea (patch) | |
| tree | d35f7fb23152f887f44be228987acb35e7f47016 /src/compositor/extensions | |
| parent | 49fb7248f6ab7de046e2179c7861951ea1169e9b (diff) | |
| download | qtwayland-8ed95b29cf2090ffd8ba161dc16a0f661429caea.tar.gz | |
Address API review comments for Qt Wayland
1. Adds explicit to new constructor
2. Adds an empty destructor for consistency to new class
3. Moved new data member into private class.
Pick-to: 6.3
Change-Id: Ib76c1cbea214693c929ced8651bdac92c2dbcd4e
Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
Diffstat (limited to 'src/compositor/extensions')
| -rw-r--r-- | src/compositor/extensions/qwaylandtextinputmanagerv4.cpp | 4 | ||||
| -rw-r--r-- | src/compositor/extensions/qwaylandtextinputmanagerv4.h | 3 |
2 files changed, 6 insertions, 1 deletions
diff --git a/src/compositor/extensions/qwaylandtextinputmanagerv4.cpp b/src/compositor/extensions/qwaylandtextinputmanagerv4.cpp index 09d70c0c..e7ec4b66 100644 --- a/src/compositor/extensions/qwaylandtextinputmanagerv4.cpp +++ b/src/compositor/extensions/qwaylandtextinputmanagerv4.cpp @@ -115,6 +115,10 @@ QWaylandTextInputManagerV4::QWaylandTextInputManagerV4(QWaylandCompositor *compo { } +QWaylandTextInputManagerV4::~QWaylandTextInputManagerV4() +{ +} + void QWaylandTextInputManagerV4::initialize() { qCDebug(qLcWaylandCompositorTextInput) << Q_FUNC_INFO; diff --git a/src/compositor/extensions/qwaylandtextinputmanagerv4.h b/src/compositor/extensions/qwaylandtextinputmanagerv4.h index f004648c..5339ea39 100644 --- a/src/compositor/extensions/qwaylandtextinputmanagerv4.h +++ b/src/compositor/extensions/qwaylandtextinputmanagerv4.h @@ -54,7 +54,8 @@ class Q_WAYLAND_COMPOSITOR_EXPORT QWaylandTextInputManagerV4 : public QWaylandCo Q_DECLARE_PRIVATE(QWaylandTextInputManagerV4) public: QWaylandTextInputManagerV4(); - QWaylandTextInputManagerV4(QWaylandCompositor *compositor); + explicit QWaylandTextInputManagerV4(QWaylandCompositor *compositor); + ~QWaylandTextInputManagerV4() override; void initialize() override; |