diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-07-31 12:48:24 +0200 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-07-31 20:31:47 +0000 |
commit | 2ea853ba28e359fba7f98ba1286bc5c89a48105a (patch) | |
tree | 1f4118b793162529f9f725437b5fa0da60dc9394 /src/designer/src/lib/shared/qdesigner_widgetbox.cpp | |
parent | 7e64a97986537fab1105385be8ce70f174ca5118 (diff) | |
download | qttools-2ea853ba28e359fba7f98ba1286bc5c89a48105a.tar.gz |
Qt Designer: Fix clang-tidy warnings about Qt usage
- Use multi-arg form of QString::arg()
- Fix static method calls
- Prefer QFileInfo::exists()
- Use isEmpty() for containers instead of checking size()
- Use QOverload
Change-Id: I31e92f77d0fa377932c1369afe2503abc8ecceac
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Diffstat (limited to 'src/designer/src/lib/shared/qdesigner_widgetbox.cpp')
-rw-r--r-- | src/designer/src/lib/shared/qdesigner_widgetbox.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/designer/src/lib/shared/qdesigner_widgetbox.cpp b/src/designer/src/lib/shared/qdesigner_widgetbox.cpp index 079c0ab00..f2e4cd5cc 100644 --- a/src/designer/src/lib/shared/qdesigner_widgetbox.cpp +++ b/src/designer/src/lib/shared/qdesigner_widgetbox.cpp @@ -215,15 +215,15 @@ DomUI *QDesignerWidgetBox::xmlToUi(const QString &name, const QString &xml, bool delete ui; *errorMessage = tr("A parse error occurred at line %1, column %2 of the XML code " "specified for the widget %3: %4\n%5") - .arg(reader.lineNumber()).arg(reader.columnNumber()).arg(name) - .arg(reader.errorString()).arg(xml); + .arg(reader.lineNumber()).arg(reader.columnNumber()) + .arg(name, reader.errorString(), xml); return 0; } if (!ui || !ui->elementWidget()) { delete ui; *errorMessage = tr("The XML code specified for the widget %1 does not contain " - "any widget elements.\n%2").arg(name).arg(xml); + "any widget elements.\n%2").arg(name, xml); return 0; } |