summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Wicking <paul.wicking@qt.io>2019-12-05 08:23:58 +0100
committerPaul Wicking <paul.wicking@qt.io>2019-12-11 07:13:28 +0100
commit6100bae8bbbd113a78b9f046927d04d6d958136b (patch)
treee15cc2c5d032f9ad706f58323819cc953c4c8767
parent77f9699a7c336e67a2ae6d37b75411528954c705 (diff)
downloadqttools-6100bae8bbbd113a78b9f046927d04d6d958136b.tar.gz
QDoc: Drop unnecessary sort
There's no change in output by not sorting the container, so it seems to be entirely unnecessary. Also const qualify the container that is no longer sorted. Change-Id: I8d5186a70623b8db6397eb88b9b0a9b53465a34a Reviewed-by: Topi Reiniƶ <topi.reinio@qt.io>
-rw-r--r--src/qdoc/cppcodeparser.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/qdoc/cppcodeparser.cpp b/src/qdoc/cppcodeparser.cpp
index 84e383fc2..e92a5d7de 100644
--- a/src/qdoc/cppcodeparser.cpp
+++ b/src/qdoc/cppcodeparser.cpp
@@ -710,8 +710,7 @@ void CppCodeParser::processMetaCommand(const Doc &doc,
*/
void CppCodeParser::processMetaCommands(const Doc &doc, Node *node)
{
- QStringList metaCommandsUsed = doc.metaCommandsUsed().values();
- metaCommandsUsed.sort(); // TODO: why are these sorted? mws 24/12/2018
+ const QStringList metaCommandsUsed = doc.metaCommandsUsed().values();
for (const auto &command : metaCommandsUsed) {
const ArgList args = doc.metaCommandArgs(command);
for (const auto &arg : args)