From 6100bae8bbbd113a78b9f046927d04d6d958136b Mon Sep 17 00:00:00 2001 From: Paul Wicking Date: Thu, 5 Dec 2019 08:23:58 +0100 Subject: QDoc: Drop unnecessary sort MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There's no change in output by not sorting the container, so it seems to be entirely unnecessary. Also const qualify the container that is no longer sorted. Change-Id: I8d5186a70623b8db6397eb88b9b0a9b53465a34a Reviewed-by: Topi Reiniö --- src/qdoc/cppcodeparser.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qdoc/cppcodeparser.cpp b/src/qdoc/cppcodeparser.cpp index 84e383fc2..e92a5d7de 100644 --- a/src/qdoc/cppcodeparser.cpp +++ b/src/qdoc/cppcodeparser.cpp @@ -710,8 +710,7 @@ void CppCodeParser::processMetaCommand(const Doc &doc, */ void CppCodeParser::processMetaCommands(const Doc &doc, Node *node) { - QStringList metaCommandsUsed = doc.metaCommandsUsed().values(); - metaCommandsUsed.sort(); // TODO: why are these sorted? mws 24/12/2018 + const QStringList metaCommandsUsed = doc.metaCommandsUsed().values(); for (const auto &command : metaCommandsUsed) { const ArgList args = doc.metaCommandArgs(command); for (const auto &arg : args) -- cgit v1.2.1