summaryrefslogtreecommitdiff
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Use QList instead of QVectorJarek Kobus2020-08-312-61/+61
| | | | | | Task-number: QTBUG-84469 Change-Id: I9109f92d059fd4152aee1f37597c5564d477fbf9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Add ; to Q_UNUSEDLars Schmertmann2020-06-281-2/+2
| | | | | | | | This is required to remove the ; from the macro with Qt 6. Task-number: QTBUG-82978 Change-Id: I56268bc09fe861effc514acb4033bf8873873ab0 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Push dependency for qtdeclarative and fix resulting test failuresAlex Blasche2020-03-312-4/+4
| | | | | | | | This enables other modules depending on quickcontrols and declarative to resolve their conflicts. Change-Id: Iea28fa75157034d85dc24f44491ca986902db547 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
* Merge remote-tracking branch 'origin/5.14' into 5.15Qt Forward Merge Bot2020-03-181-0/+25
|\ | | | | | | Change-Id: I3022d2eabeef6d387135427b553de8a6d80dff13
| * TreeView: update currentIndex on model changesAlberto Mardegan2020-03-101-0/+25
| | | | | | | | | | | | | | | | | | | | | | The previous binding was not getting re-evaluated when the model was being reset or when rows were been inserted or removed. Here we use a counter variable, whose value change will force the evaluation of the binding. Fixes: QTBUG-53097 Change-Id: I76afebbda78ab477cf65631337a8bad51ca5428d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | Avoid initializing QFlags with 0 or nullptr in testsFriedemann Kleint2019-12-091-4/+4
|/ | | | | | | | It is being deprecated. Amends d1697d81866abaf217b6647b0f42a13fa974636b. Change-Id: I7ec2e8d5d07b86eebeb9e16c35f70e3c93a4b037 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* tst_tumbler.qml: fix failing test_currentIndex() testMitch Curtis2019-11-261-3/+3
| | | | | | | | | Use correct (i.e large enough distance) to ensure the current index changes. Fixes: QTBUG-80152 Change-Id: I26873e83fbd520965495104177ba09a38f566257 Reviewed-by: Liang Qi <liang.qi@qt.io>
* Merge remote-tracking branch 'origin/5.13' into 5.14v5.14.0-beta3Qt Forward Merge Bot2019-11-041-1/+204
|\ | | | | | | | | | | | | Conflicts: .qmake.conf Change-Id: Ide73d291e885a0455765263716ea2b972d7ae62b
| * QQuickTreeModelAdaptor1: fix updating of ModelIndex roleAlberto Mardegan2019-10-291-1/+204
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The decision to store the original QModelIndex as a role has the unfortunate consequence that we need to emit the dataChanged() signal whenever its value change. The previous implementation of the "move rows" operation failed in delivering this update in most cases. While addressing that, this commit also fixes some similar issues with the HasChildren role not being notified in certain scenarios. Also, when the last child of an expanded item gets moved away and later placed back in the original position, the item should not remember its expanded state, but rather accept the children while staying collapsed. Last but not least, it's important that the endMoveRows() protected method is called *after* the original tree model has completed its movement, because otherwise its elements might be accessed while in the wrong state. Similarly, we don't want the dataChanged() signals to be emitted while rows are moved or removed; we queue up these events and fire them only after the item indexes have settled. Fixes: QTBUG-59606 Change-Id: Ib981c912ea19908e1283cc463331c3053d4d6e7d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | Merge "Merge remote-tracking branch 'origin/5.13' into 5.14"v5.14.0-beta2Liang Qi2019-10-141-35/+0
|\ \
| * \ Merge remote-tracking branch 'origin/5.13' into 5.14Liang Qi2019-10-141-35/+0
| |\ \ | | |/ | | | | | | | | | | | | | | | Conflicts: tests/auto/extras/data/tst_tumbler.qml Change-Id: Ia8b373767a311e973e3b171109b6b8b6c33f82b0
| | * Remove test_resizeAfterFlicking from tst_tumblerMitch Curtis2019-10-091-35/+0
| | | | | | | | | | | | | | | | | | | | | | | | This is causing flakiness in CI, and tests a weird edge case, so its value as a test is very low. Change-Id: Iaeb2633bd270dc8e88420ace5efe9ab156339733 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* | | Blacklist Tests_TableView::test_headervisible on macosUlf Hermann2019-10-141-0/+3
|/ / | | | | | | | | | | Task-number: QTBUG-79161 Change-Id: I94f2d7bb16db92fcce87086c9abf8b4b0a39f792 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | Make restoreMode on all Binding elements explicitUlf Hermann2019-10-041-2/+5
| | | | | | | | | | | | | | The default is going to change in 5.15. Change-Id: Ib17500791476bd45ed2c7c3736186897fb63d7a0 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
* | tst_tumbler: adapt test after changes to PathViewMitch Curtis2019-09-251-2/+1
| | | | | | | | | | | | | | | | | | | | | | 3df387d63421f09533ab72e2a73fb5d259693120 changed the flicking behavior of PathView slightly, so we need to adapt this test to reflect those changes. Fixes: QTBUG-78471 Change-Id: I093bfea9a4d089b4f61c405ab41aa1f4ea77d422 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* | tst_tumbler: temporarily disable a test to let qtdeclarative change inv5.14.0-alpha1Liang Qi2019-09-191-1/+2
| | | | | | | | | | | | | | | | | | 3df387d63421f09533ab72e2a73fb5d259693120 changed the flicking behavior of PathView slightly. Task-number: QTBUG-78471 Change-Id: I403f06bed8c790196e5fc8c3ec8f3ea59b91f23e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | Merge remote-tracking branch 'origin/5.13' into devQt Forward Merge Bot2019-08-031-0/+2
|\ \ | |/ | | | | Change-Id: I9c435126c80016cf3476c09d46633038ddf46250
| * BLACKLIST Tests_Picture::test_source for msvc-2019Heikki Halmet2019-07-311-0/+2
| | | | | | | | | | | | Task-number: QTBUG-75276 Change-Id: Ief49097b9ff5b26a93afdcdc6357975d87f3363f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | Eradicate Java-style iterators and Q_FOREACH and mark the module free of themMarc Mutz2019-07-153-12/+11
|/ | | | | | | | | | | | | ... and QLinkedList. Java-style iterators are scheduled to be deprecated, or at the very least banned from use in Qt's own implementation. Ditto Q_FOREACH. Ditto QLinkedList. Change-Id: I92eb5c22762b63cba45f8eaf717c1b7d458fcda4 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Andy Shaw <andy.shaw@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Merge remote-tracking branch 'origin/5.12' into 5.13Qt Forward Merge Bot2019-06-271-25/+32
|\ | | | | | | | | | | | | Conflicts: .qmake.conf Change-Id: I6c5ee0a59f5ba747611d8f6fdf97fdb7b88f97b9
| * Stabilise flaky testDimitrios Apostolou2019-06-261-25/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | Spread small delays in the test to mitigate severe flakiness on MacOS_10_12 platform in our CI. This is not a proper fix. It is acceptable because the module is deprecated and because it should greatly improve the instability of our CI. Fixes: QTBUG-76570 Change-Id: If2d7d15dffe23c7e0644b233e7757c04574c89d4 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* | Blacklist several failing tests in extras on MSVC 2019Shawn Rutledge2019-04-291-0/+8
| | | | | | | | | | | | Task-number: QTBUG-75276 Change-Id: I3b377588e58a613fcd37e5ec5ed39a9fc1cd996c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | Merge remote-tracking branch 'origin/5.12' into 5.13Qt Forward Merge Bot2019-04-062-0/+78
|\ \ | |/ | | | | Change-Id: Ica2ac2d9c26eadad16509d0512817665566d829c
| * Dialog: Update the title on the window when changing it on the dialogAndy Shaw2019-03-292-0/+78
| | | | | | | | | | | | Change-Id: Id9c60bf10bc0d4fb28ee9a027b84e395e9cb745c Fixes: QTBUG-74350 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | Merge remote-tracking branch 'origin/5.12' into 5.13v5.13.0-beta1Qt Forward Merge Bot2019-03-022-0/+9
|\ \ | |/ | | | | Change-Id: Ib614fd58e4df83945017bbb3bf2cbc9d5a72df4c
| * Fix blacklisting of auto testsOliver Wolff2019-02-281-0/+1
| | | | | | | | | | | | | | | | | | When doing shadow builds, the BLACKLIST file can only be found if QTEST_SET_MAIN_SOURCE_PATH is set. Fixes: QTBUG-74117 Change-Id: Icfb76c313800fefbb68f911779d5ef058b67cf40 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
| * Update the CalendarHeaderModel when changing the locale setAndy Shaw2019-02-201-0/+8
| | | | | | | | | | | | Change-Id: I8af18ebfcc77f6080cfd5f0cade5042d0cd4a9a4 Fixes: QTBUG-73765 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | Skip Tests_ScrollView::test_dragFetchAppendMitch Curtis2019-02-281-0/+2
| | | | | | | | | | | | | | | | | | It's notoriously flaky, with several attempts to stabilise it so far, and it's now blocking 5.13. I would blacklist it, but QTBUG-74117. Task-number: QTBUG-55727 Change-Id: I653f534ed712fa5af9bcf6340faee2cae2f1c99b Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
* | Tests: Fix warnings about ignored return valuev5.13.0-alpha1Friedemann Kleint2019-02-061-2/+2
| | | | | | | | | | | | | | Check return value of Test::qWaitForWindowExposed() Change-Id: I21dd077d2610b6a374e2e6ad943ee39e0b6d4e79 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | Fix deprecation warningsFriedemann Kleint2019-02-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Private/qquicktreemodeladaptor.cpp:744:52: warning: ‘void QList<T>::swap(int, int) [with T = QQuickTreeModelAdaptor1::TreeItem]’ is deprecated: Use QList<T>::swapItemsAt() [-Wdeprecated-declarations] Private/qquicktreemodeladaptor.cpp:750:52: warning: ‘void QList<T>::swap(int, int) [with T = QQuickTreeModelAdaptor1::TreeItem]’ is deprecated: Use QList<T>::swapItemsAt() [-Wdeprecated-declarations] Private/qquickstyleitem.cpp:922:89: warning: ‘int QFontMetrics::width(QChar) const’ is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations] In file included from /data1/frkleint/qt-513/qtbase/include/QtGui/qfontmetrics.h:1:0, Private/qquickstyleitem.cpp:942:60: warning: ‘int QFontMetrics::width(const QString&, int) const’ is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations] Private/qquickstyleitem.cpp:961:75: warning: ‘int QFontMetrics::width(const QString&, int) const’ is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations] Private/qquickstyleitem.cpp:1010:52: warning: ‘int QFontMetrics::width(const QString&, int) const’ is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations] Private/qquickstyleitem.cpp:1010:86: warning: ‘int QFontMetrics::width(QChar) const’ is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations] Private/qquickstyleitem.cpp:1469:46: warning: ‘static bool QPixmapCache::find(const QString&, QPixmap&)’ is deprecated: Use bool find(const QString &, QPixmap *) instead [-Wdeprecated-declarations] ../../../src/controls/Private/qquicktreemodeladaptor.cpp:744:52: warning: ‘void QList<T>::swap(int, int) [with T = QQuickTreeModelAdaptor1::TreeItem]’ is deprecated: Use QList<T>::swapItemsAt() [-Wdeprecated-declarations]/data1/frkleint/qt-513/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:227:10: note: declared here ../../../src/controls/Private/qquicktreemodeladaptor.cpp:750:52: warning: ‘void QList<T>::swap(int, int) [with T = QQuickTreeModelAdaptor1::TreeItem]’ is deprecated: Use QList<T>::swapItemsAt() [-Wdeprecated-declarations] tst_qquicktreemodeladaptor.cpp:1387:39: warning: ‘QModelIndex QModelIndex::child(int, int) const’ is deprecated: Use QAbstractItemModel::index [-Wdeprecated-declarations] Change-Id: I213d7ffd2cb329b542f9273e3a566a813d1cc24f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | ScrollView Tests: Allow for delayed update when loading new dataUlf Hermann2019-01-241-2/+6
|/ | | | | | | The ScrollView can render multiple times before the content is complete. Change-Id: I32513a96e51c4d91e53daa6204821a95d9cb1d52 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Calendar: Ignore any time specified for a minimum and maximum dateAndy Shaw2019-01-142-38/+50
| | | | | | | | | | | | Since Calendar only cares about the date part and not the time, we should ignore the time part when it is set as the minimum and maximum and manually set it to 0:00:00 and 23:59:59 respectively. This ensures that the day itself is still seen as valid irrespective of what time was passed to Date(). Change-Id: I57c311ffe7d3fb1ab69c59296a067a66f1007137 Fixes: QTBUG-71997 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* Unskip test of fixed bugAllan Sandfeld Jensen2018-11-291-1/+0
| | | | | | | | Was never unskipped after being fixed Task-number: QTBUG-47523 Change-Id: Ibb193b45a73ca627ab3db7db8d1bf7b98f9ee8b4 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
* TableView: Handle dynamic insertion of TableViewColumns correctlyAndy Shaw2018-11-162-0/+90
| | | | | | | | | | When inserting a TableViewColumn after the TableView is created, then it needs to be inserted into the list of columns at the specified index so that it responds correctly to things like resizeColumnsToContents() Fixes: QTBUG-58594 Change-Id: If7ff545306fe8b6616d8e016eb87e565ed40c836 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Refine startup benchmark termination conditionSimon Hausmann2018-10-313-12/+5
| | | | | | | | | Instead of using a timer to terminate the benchmark, let's terminate the benchmark after we've sent off the first rendered frame. This is a bit more realistic, although it doesn't change numbers on my machine. Change-Id: I9a3724ecf781191d2b4dd937a5b74960a19550df Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
* Improve startup benchmarkSimon Hausmann2018-10-311-15/+15
| | | | | | | | | Don't measure the time it takes to destruct the QQmlEngine, as that may be heavy work due to the last sweep of the garbage collector heap and deleting all engine-owned QObjects. Change-Id: Ibdd3d92e306d0418ee7080077b8894950878ec43 Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
* ScrollView: Defer calls to doLayout()Ulf Hermann2018-09-261-9/+17
| | | | | | | | | | | | | | | doLayout() updates the dimensions of the scroll view, and therefore can trigger the scroll bars to be shown or hidden. That, in turn, can trigger another call to doLayout(), resulting in binding loops. Avoid those by deferring the call. The scrollview tests are broken without this change because the binding loop prevents the scrollbars from being shown or hidden in some cases. The deferring necessitates a tryVerify(), but fixes the actual tests. Change-Id: I0dac0ba380240e025237f69c4d357d764a535c3d Fixes: QTBUG-50605 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Dialogs: allow preventing processing of standard buttonsAlberto Mardegan2018-06-292-0/+228
| | | | | | | | | | | | | | | | | Add an actionChosen() signal to DefaultDialogWrapper, allowing the developer to stop further processing of the event by setting the "accepted" field to false. This is especially useful when some validation on the dialog contents need to take place before the dialog can be accepted. [ChangeLog][Dialogs] Add a signal to the Dialog class to allow the client to intercept the button presses and optionally prevent further processing of the event. This allows performing some validation on the fields before dismissing the dialog. Task-number: QTBUG-69095 Change-Id: I19bca0bd9fcbafc72d337a5870776a96634ba748 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Merge remote-tracking branch 'origin/5.11' into devQt Forward Merge Bot2018-05-261-13/+0
|\ | | | | | | Change-Id: Ie706f27a0c43ec1d1136310fba196d9b41a184ed
| * StatusIndicatorStyle: fix usage of ctx.createRadialGradient()Mitch Curtis2018-05-241-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | be4c4877b35ad1b6983cf194e61f0dad1d123af5 fixed Context2D's createRadialGradient() function, so our usage of it has to be updated accordingly. This patch results in the same visual result as it was originally (before the auto test failure). Task-number: QTBUG-68301 Change-Id: Ibd8aa24e84ceecccf25d7656350738a38cd03e24 Reviewed-by: Andy Shaw <andy.shaw@qt.io> Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
| * Unblacklist tst_tumblerMitch Curtis2018-05-221-7/+0
| | | | | | | | | | | | | | | | | | | | The issue that was causing the tests to fail was most likey fixed by 12d80048. 41669ca6 unblacklisted other tests that were fixed by the that commit. Task-number: QTBUG-46393 Change-Id: Ib81e7b1afe0a60961c0b8ad3201802389c7bab01 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
* | Merge remote-tracking branch 'origin/5.11' into devQt Forward Merge Bot2018-05-191-0/+7
|\ \ | |/ | | | | Change-Id: I4194dd92ef851407e667bd1c635367a1bae97480
| * Temporarily blacklist tst_statusindicatorMitch Curtis2018-05-161-0/+7
| | | | | | | | | | | | | | | | | | The test seems to have started failing due to high DPI issues, but until the root cause has been found, unblock CI. Task-number: QTBUG-68301 Change-Id: Ia800eb2b568ee0abd35937e436b213321d035290 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
* | Merge remote-tracking branch 'origin/5.11' into devQt Forward Merge Bot2018-04-182-0/+71
|\ \ | |/ | | | | Change-Id: I00b66b03717563bb700f8a73c3bc295a55ac8c6a
| * Slider: don't break the binding on value when using the mouse wheelAndy Shaw2018-04-171-0/+33
| | | | | | | | | | | | | | | | | | When the wheel was used it could cause any binding on value to be broken since it was updated directly. Going via range.position ensures this is not the case. Change-Id: Ic041ea911cee68de34f5c4e184cf8460f5e002da Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
| * Stop incrementing if the mouse is no longer over the buttonAndy Shaw2018-04-171-0/+38
| | | | | | | | | | Change-Id: Ibc95b14faaa77f200cf6ea5e05cb227e6a3628ca Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* | Merge remote-tracking branch 'origin/5.11' into devQt Forward Merge Bot2018-02-2721-0/+319
|\ \ | |/ | | | | Change-Id: I4b1a4ebf258c9d31e537f42c8d0219c4294628bb
| * Merge remote-tracking branch 'origin/5.10' into 5.11Liang Qi2018-02-1221-0/+319
| |\ | | | | | | | | | Change-Id: I2d12dd7b271e17662295007f5cf25ff4b3b78e8e
| | * Calendar: make clicked(date) emit the correct date5.10Mitch Curtis2018-02-091-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calendar was implemented in such a way that pressing on a date selects that date, rather than releasing or clicking. With the current code, this presents issues when the month changes as a result of the press. For example, clicking on a date in an adjacent month will result in the clicked() signal passing the date under the mouse in the new month, instead of the originally pressed date. This patches fixes the issue by storing the pressed date and using it when emitting the released() and clicked() signals. Task-number: QTBUG-54129 Change-Id: I0c16293033b77f6ae783b5365d198b4a516af90b Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
| | * Merge remote-tracking branch 'origin/5.9' into 5.10Liang Qi2018-02-0220-0/+309
| | |\ | | | | | | | | | | | | Change-Id: I556a8404b908c15eaa71b009319c7f27274b40f1