| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Task-number: QTBUG-67283
Pick-to: 6.5
Change-Id: I4b8f877cc355c7c6cd410b3b1683defa58486381
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename overloads that would cause conflict and require explicit overloa
resolution via QOverload:
- Q*Reply::error -> errorOccurred (equivalent to QNetworkReply)
- Q*Engine::error -> errorOccurred (for consistency, even if no overloa
- Q*Manager::error -> errorOccurred (ditto)
- QDeclarativeGeoMap::copyrightChanged -> copyrightImageChanged
As a drive-by, change QString value parameters to const references.
Pick-to: 6.2
Change-Id: I1ab16079842540ca0a86f711d83b35c8c56135e6
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Don't return or pass const copies, use either plain copies or const
references. Make getters const, make variables const, and use qAsConst
in ranged for loops to avoid detaches.
Pick-to: 6.2
Change-Id: If1463cf7f0077c08dedb15388d912b652c2b037c
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Get rid of unnecessary includes in most public, and some private
headers. Forward declare what we have to, and include headers where
needed in the implementation and test files.
Pick-to: 6.2
Change-Id: I7924e865b9d4ad9f8c8670605b59d5530346106e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
| |
Remove usages of outdated LGPL3 header that references LICENSES.LGPLv3
instead of LICENSES.LGPL3.
Change-Id: Ied647fc10d2bf051cccc8b38d75570b7caef1f28
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-84469
Change-Id: Iefd2fb627602ef4744d80858eee72a089ef5f4ec
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
|
|
|
|
|
| |
Change-Id: Icbebfaae93cc5827d80ef09323ec82868789838a
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Wzero-as-null-pointer-constant
... or equivalent.
QtBase 5.6 headers already compile that way, so let the other
modules follow suit.
Added explicit where it was missing. This is not a source-
incompatible change, because code that breaks by this is
a bug. Let's not have this sitting around in an LTS.
Task-number: QTBUG-45291
Change-Id: I279fd100b61d3e2b2e46e7cbd30cc6b4bfb4d10e
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
| |
Change-Id: I3007aa04d3dbc0e00cb0a43987d64d01ddf91edd
Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: Ia1e333be7fec8898de609d9b9303b1ad7687632e
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@theqtcompany.com>
|
|
|
|
|
|
| |
Change-Id: I538f0de4d2fca50e42114934f12dfd0ee51088e9
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
- Renamed LICENSE.LGPL to LICENSE.LGPLv21
- Added LICENSE.LGPLv3 & LICENSE.GPLv2
- Removed LICENSE.GPL
Change-Id: Iedee2507ab1bd46788409a98505d7be510253110
Reviewed-by: Jani Heikkinen <jani.heikkinen@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This complements 1d0966c6924876655c52725e779a7aa24866ff60
Not all service providers support arbitrary offsets when requesting
place content. The offset attribute has been removed, instead service
providers can supply a previous and next content request query in the
form of a QPlaceContentRequest.
Change-Id: I6239b42c31bed5dcd6645d86d5a48d7e6a667f46
Reviewed-by: Alex Blasche <alexander.blasche@digia.com>
|
|
|
|
|
|
|
|
|
| |
These macros were removed from Qt Core and they are no longer defined
causing Qt Location to fail to build.
Change-Id: Ibed30daa1a802957cebe95a577dfe86f0f643970
Reviewed-by: Laszlo Papp <lpapp@kde.org>
Reviewed-by: Lorn Potter <lorn.potter@jollamobile.com>
|
|
|
|
|
| |
Change-Id: I61ae1bd1a9f68d120d4e11635f306374b1f494d0
Reviewed-by: Aaron McCarthy <mccarthy.aaron@gmail.com>
|
|
|
|
|
| |
Change-Id: I17265b37a557472fc55fec7e25cd2bf2b3a6dc9d
Reviewed-by: Aaron McCarthy <mccarthy.aaron@gmail.com>
|
|
|
|
|
|
|
|
| |
Change copyrights and license headers from Nokia to Digia
Change-Id: Ic1390da64a219642fa1e1482a7677a4c2db15cbc
Reviewed-by: Janne Anttila <janne.anttila@digia.com>
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
|
|
|
|
|
|
|
|
| |
Recommendations can be incorporated into ordinary searches.
this is more convenient for the developer.
Change-Id: Ifd3e040b6b7a964227981175b074ca4f52d7579c
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The place and category added/modified/removed signals
are not sufficient if there are large scale changes
to the underlying datastore.
To avoid potential avalanches of signals we have
a dataChanged() signal for significant changes
Change-Id: Ibb90c117eabfc6144ab5d8681bd9844575e86247
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
| |
Change-Id: I8a8071e1ad50f735ada952ee8ac36f12edba8a06
Reviewed-by: Alex Wilson <alex.wilson@nokia.com>
|
|
|
|
|
|
|
| |
Duplication reduction with the Power of Templates (tm).
Change-Id: I119d83bdc965416788263b295e368b243c2b897e
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adapts geoservice plugins to use the new Qt5 plugin API,
performing boolean feature detection all through the JSON blobs
rather than methods on factories or managers.
As a result of this centralisation, it was also necessary to rework
the QML API for the Plugin element a little. Some additional changes
were made to the declarative places plugin to prevent it crashing
due to plugins becoming available later than they did previously.
Task-number: QTBUG-24331
Change-Id: I26149987344b67091480449103ab1712c869b2a5
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
| |
As in the past, to avoid rewriting various autotests that contain
line-number information, an extra blank line has been inserted at the
end of the license text to ensure that this commit does not change the
total number of lines in the license header.
Change-Id: I00c66363046e475e6924aafd221483c7fad5c0d9
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
|
|
|
|
|
| |
Change-Id: I37dfa12027bcc5424e65aa515f512b18a94692c4
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
| |
Replace Nokia contact email address with Qt Project website.
Change-Id: I3850177e14291901e924f9c27ba09e75df00f96a
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
|
|
|
|
|
|
|
|
| |
Cross referenceing means we can detect whether a place from one
plugin/manager is already in another plugin/manager
Change-Id: Ice1834446a61e30e02f869e1d383f6d8698b8db6
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
| |
Change-Id: I496795d13a615be8d252ca20a40dd2c5ba84ed60
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
For C++ we add a compatiblePlace() function which returns
a pruned version of the original suitable for saving into the manager
For QML there the Place has a copyFrom() method. Only data that
is relevant to the current place's plugin is copied over.
Change-Id: I97c3ed8f1c7e7f68165242a2d6f1d0b04e9ab9a0
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
| |
Change-Id: Ib84f1be226fcd481fe6ffed380b2e0dc63d789e6
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The manager now accepts a list of locales. If the first locale
cannot be accommodate, the manager falls back to the next.
For those managers that do support locales, the default set of locales
contains just the global default locale.
Change-Id: Iaf6511e18e22fe3c8bd6a8a0ee6077c2827d664c
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
| |
Rename for consistency with getPlaceDetails.
Also change parameter from place object to place id.
Change-Id: I1cabe7aa3cf17ce5aafba7c09d3e37ea1ab220b3
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For consistency with getPlaceDetails and getPlaceContent,
use a place id as a parameter instead of a place object.
Also provide a default search request parameter.
Also rename element to PlaceRecommendationModel
to be consisent with PlaceSearchModel and
PlaceSearchSuggestionModel
Change-Id: Idc68d8c14dcadcd8d65427fdf65a919d5d4560c5
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
A suggestion is a more appropriate term since 'prediction'
implies that the search term just is auto-completed. Suggestions
may be given that do not derive directly from the
entered partial search term.
Also rename TextPredictionModel to PlaceSearchSuggestionModel.
Change-Id: Ib7100e0c52c21196ecc70c8c25a94abfaecc9125
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
| |
Change-Id: I52e9eee45b96c42500108646880f500df9dae55d
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Documentation for the content and search request classes.
There is no need for the request classes to inherit off a
base request class. Currently the base class has limit and offset
fields, but if for example there is an image submission request class
the limit and offset become meaningless.
The content reply class should have a field for the content request
just like the search reply has a field for the search request.
Change-Id: I8d9dfe8a31806c6bb3b31f66d1338c2999e27ce2
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
| |
The notifications feature means the manager will give signal
notifications for added/modified/removed places and categories.
Change-Id: I30118d53e11a0b5ba9ed7edaf418c215861fa2c4
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
| |
The PlaceIcon can call the engine directly to get the constructed
icon
Change-Id: I71c91b958f6266acb81533c38e9b629751bbceaa
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
| |
removing places used to take a place object while removing categories
used a category id. Change removing places to use a place id.
Change-Id: I2d603564df362b327fb2fdd27e1f2f00bf2ae833
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
| |
Q_LOCATION_EXPORT_TEMP -> Q_LOCATION_EXPORT
Change-Id: I65b1d9c59ab2d2ad437f1934013eb53b0b96e606
Reviewed-by: Alex <alex.blasche@nokia.com>
|
|
|
|
|
|
|
|
| |
Removing all location related defines from qglobal.h causes this macro
to fail. It seems that it is no longer used in new modules.
Change-Id: Ifbfa6f7f40a419e0890a4611bab7e2d681f63a04
Reviewed-by: Alex <alex.blasche@nokia.com>
|
|
|
|
|
|
|
|
|
| |
Each module handles each its own exports. We need to change the
QtLocation version, remove the qglobal.h define and then add it back
under the old name in QtLocation
Change-Id: I7530a251b78402215a466cd55a33ec24664786b7
Reviewed-by: Alex <alex.blasche@nokia.com>
|
|
|
|
|
|
|
|
|
| |
Authentication can be provided through parameters to the manager,
which have been passed through the QGeoServiceProvider class.
Change-Id: I8aaba0830e08d82393fac27cbeda84c61e3941a0
Reviewed-on: http://codereview.qt-project.org/6653
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
| |
Change-Id: Ie2518c349fc551756f78a963417cceb93c81a3a8
Reviewed-on: http://codereview.qt-project.org/6407
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I559c96427db542dd71122f937dff90c900a02241
Reviewed-on: http://codereview.qt-project.org/6041
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
| |
Change-Id: Ic902592c3367a76fc0e23c237712224abbf31703
Reviewed-on: http://codereview.qt-project.org/6206
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
| |
Change-Id: Id1f5d248fd17554b17211d48facf3f6b85565853
Reviewed-on: http://codereview.qt-project.org/5341
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that the jsondb implementation will be heavily refactored.
The currrent implementation of having child id's within each
category does not 'gel' very well with jsondb.
(Some of the current engine functions are practically
synchronous)
Apparently there is an alternative approach using 'Views',
but further investigation is required. For now the intention
is just to have something working so we can with experiment and
refine the API.
Change-Id: I5c9566e94f1a712f33dc06f6ad5e041326265398
Reviewed-on: http://codereview.qt-project.org/5215
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I1c269d294d9e2187fb0f3e650b5c6941e1877140
Reviewed-on: http://codereview.qt-project.org/5269
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Add QT_{BEGIN,END}_HEADER
Add QT_{BEGIN,END}_NAMESPACE
Add QT_MODULE(Location)
Change-Id: Ib12682b847d9439c0e55e78fdf8a71ee8406c282
Reviewed-on: http://codereview.qt-project.org/5435
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I2594e33049c4901c641c4e1a4347b7ee1952ecd8
Reviewed-on: http://codereview.qt-project.org/5273
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|