| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
| |
Change-Id: I9dbdf6f4974167a2a4229bd3bd798f7de36bfc10
Reviewed-on: http://codereview.qt-project.org/4939
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to be more consistent with the other place classes
like QPlaceManager.
The alternative would be for everything to have the QGeo prefix
e.g QGePlaceManager, QGeoPlaceCategory,
the Geo prefix does not help much in avoiding name collisions
since 'Place' shouldn't collide with anything anyway.
For classes like routing the Geo prefix is necessary to give
context for what's being routed.
Change-Id: Ibcf6e6909a41ea0ce2c402e24b427496d06bf243
Reviewed-on: http://codereview.qt-project.org/5210
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These signals indicate changes to the database. These 3 signals
are provided rather than a single placesChanged() signal because
it gives greater granularity. E.g. if a place is removed,
we may want to know precisely which one it is so we can remove
it from a model.
For the SearchResultmodel whenever a place is added, updated, or
deleted we reload the model by executing the query again.
For now in the jsondb plugin implement signal emission
manually whenever a request is finished. In a future change
we will use proper jsondb notifications.
For the online plugins, we do not expect these signals to be emitted.
Also place removal now uses the QPlaceIdReply.
Change-Id: I29f5aaaa6b8152abe1f5305a4d52abc721e6915e
Reviewed-on: http://codereview.qt.nokia.com/4109
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The id reply is meant for operation in which we return an id
such as saving a place, removing a category etc.
The id reply has an operationType() property which tells us what
the operation was.
We don't use the QPlaceReply::type() to hold the operation type
because the reply type should indicate the contents of the reply,
eg the content reply holds place content, the search reply
holds search results therefore the id reply holds an id.
Change-Id: I3aa0b45c648186ee78297620896420966e42afa3
Reviewed-on: http://codereview.qt.nokia.com/4061
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the plugin does not use proper location schema to store
place objects. Also the plugin does some filtering in code rather
than with jsondb queries because it seems the comparison operators
are not working correctly.
These issues are to be addressed in future commits. Currently
only basic place information is stored consisting of name, address
and coordinate.
Change-Id: Icc59f4fe50f5ecdd61d4d9565789d813a41a749f
Reviewed-on: http://codereview.qt.nokia.com/3555
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means we no longer need the qplacereviewreply or the
paginationlist.
We also create a QPlaceContentRequest class to specialize
in requesting content. It follows the same pattern that
QPlaceContent does where the private classes use inheritance
to mirror the public classes so that we only have a single
d pointer instance per class(as opposed to a dpointer for
QPlaceRequest and a dpointer for QPlaceContentRequest).
QPlaceSeachRequest has been modified like this as well.
Also in the nokia plugin we rename the qplaceimagereplyimpl class
to the qplacecontentreplyimpl class. We use this to get the reviews
as well as images and we no longer need the qplacereviewreplyimpl class.
Change-Id: I0aa1254a4df3d136bf81f9faf0f6ec06a0773100
Reviewed-on: http://codereview.qt.nokia.com/3305
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Paging is now implemented in terms of content objects, things like
images, reviews etc should inherit off the QPlaceContent class.
The main advantage of this change in C++ is that the paging code will
not be duplicated for different content types, also we have less
symbols which is good for plugin loading times.
For now, in QML we still retain separate specialized models. In future
it might be possible to just have a single model class to hold
different content types. There will still however need to be
separate model instances for say reviews and images.
PlaceMediaObject has been renamed to PlaceImage because currently
all we provide are images. It is anticipated that if there are
new media types like video we would introduce QPlaceVideo and have
it inherit off QPlaceContent. It is suboptimal to try define
a generic media object right now when we do not have a clear idea
about the use cases of each possible media type.
A future change will have QPlaceReview inherit off QPlaceContent.
Change-Id: Ia6cf5092e246374ed639694d7653e30429c94cc2
Reviewed-on: http://codereview.qt.nokia.com/3284
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
|
|
|
| |
The term request is more consistent with existing classes like
QGeoRouteRequest and QNetworkRequest.
Change-Id: If627769d8a2a7b1fa2b802f2e7d7da8a98b006ff
Reviewed-on: http://codereview.qt.nokia.com/2984
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I3ea93dac21920e0a05b28da089a75e7d32587af8
Reviewed-on: http://codereview.qt.nokia.com/2539
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
| |
Change-Id: I5028f4a617128bb9fa95ea94efe4b1ac8722dbb2
Reviewed-on: http://codereview.qt.nokia.com/2923
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
| |
Change-Id: I3baab99ef01992555f97b6d7274c8adc6b773683
Reviewed-on: http://codereview.qt.nokia.com/2722
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
| |
Change-Id: I22b738d5ff1973a551ada60b4b4a4a58e34889b7
Reviewed-on: http://codereview.qt.nokia.com/2470
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove supportedSearchVisibiltyScopes() from QPlaceManager.
Mainly it should be a documentation issue for whether a particular
manager supports public or private place searching
Change-Id: Icbd21238151f1100614423a942a7363f13e25837
Reviewed-on: http://codereview.qt.nokia.com/2335
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
|
|
|
| |
Change-Id: I2da4764d53062b84e2e24c5b8e63cdfd5807e2ba
Reviewed-on: http://codereview.qt.nokia.com/2466
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings the usage of the Places API inline with the rest of the
functional groups in QtLocation.
Removes the PlaceManager element.
Change-Id: I6d7259fe7ea1e55dcf97b95025e0c78748e82b9f
Reviewed-on: http://codereview.qt.nokia.com/2245
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
|
|
|
|
|
|
|
|
|
| |
Change QTM_* to QT_*.
Change-Id: I8d0d0a53458ffb2f3ecc26d70a3542fb2cb1bf74
Reviewed-on: http://codereview.qt.nokia.com/1613
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
|
|
|
|
| |
QGeoPlace was an already existing class in mobility.
|
| |
|
|
|
|
|
|
|
|
| |
This covers changes from r45246 to r45259. Note not all changes
have been merged through. the qt4 pre-release doesn't support
connectivity modes, these have been retained for qt5.
Also the qt4 pre-release sends username for posting reviews this
hasn't been brought over to qt 5.
|
|
|
|
| |
Also add functions for saving and removing places
|
| |
|
|
|
|
| |
Also changes to keep in sync with the qt4 pre-release
|
| |
|
| |
|
|
|