diff options
author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-10-08 15:19:05 +0200 |
---|---|---|
committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2023-01-13 08:39:44 +0000 |
commit | 6ea8dcf6b9dda083f46c0cb67ca493bd8b6363cd (patch) | |
tree | bbcf92e9a2b6148f7d2bc887b58d77b01e44f0ff /tests | |
parent | 8c25f579cd52555f7d09919fa08aa06278480cf6 (diff) | |
download | qtlocation-6ea8dcf6b9dda083f46c0cb67ca493bd8b6363cd.tar.gz |
Remove unused extraParameters
No plugin implements or uses it, and we could use dynamic properties to
pass more data through to backend implementations, if needed.
Pick-to: 6.5
Change-Id: Ie7cbc1e24fadf51e5f39e0ced53860e6a2c6609b
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/auto/geotestplugin/qgeoroutingmanagerengine_test.h | 2 | ||||
-rw-r--r-- | tests/auto/qgeorouterequest/tst_qgeorouterequest.cpp | 32 | ||||
-rw-r--r-- | tests/auto/qgeorouterequest/tst_qgeorouterequest.h | 2 |
3 files changed, 0 insertions, 36 deletions
diff --git a/tests/auto/geotestplugin/qgeoroutingmanagerengine_test.h b/tests/auto/geotestplugin/qgeoroutingmanagerengine_test.h index 59cd8585..8ef0fd4c 100644 --- a/tests/auto/geotestplugin/qgeoroutingmanagerengine_test.h +++ b/tests/auto/geotestplugin/qgeoroutingmanagerengine_test.h @@ -141,8 +141,6 @@ public: { QList<QGeoRoute> routes; int travelTime = 0; - if (request.extraParameters().contains("test-traveltime")) - travelTime = request.extraParameters().value("test-traveltime").toMap().value("requestedTime").toInt(); for (int i = 0; i < request.numberAlternativeRoutes(); ++i) { QGeoRoute route; diff --git a/tests/auto/qgeorouterequest/tst_qgeorouterequest.cpp b/tests/auto/qgeorouterequest/tst_qgeorouterequest.cpp index 382bce56..1b35217b 100644 --- a/tests/auto/qgeorouterequest/tst_qgeorouterequest.cpp +++ b/tests/auto/qgeorouterequest/tst_qgeorouterequest.cpp @@ -280,38 +280,6 @@ void tst_QGeoRouteRequest::featureWeight() QVERIFY(qgeorouterequest.featureTypes().contains(type)); } -void tst_QGeoRouteRequest::extraParameters_data() -{ - QTest::addColumn<QVariantMap>("extraParameters"); - - QVariantMap params; - QTest::newRow("Empty") << params; - - const QVariantMap param1 = {{"property1", QVariant(42)} , {"property2", QVariant("42")} , {"property3", QVariant("42.0")}}; - params["param1"] = param1; - - QTest::newRow("One param") << params; - - const QVariantMap param2 = {{"property1", QVariant(43)} , {"property2", QVariant("43")} , {"property3", QVariant("43.0")}}; - params["param2"] = param2; - - QTest::newRow("Two params") << params; -} - -void tst_QGeoRouteRequest::extraParameters() -{ - typedef QVariantMap ParameterType; - QFETCH(ParameterType , extraParameters); - - QGeoRouteRequest qgeorouterequest; - - QVariantMap emptyParams; - qgeorouterequest.setExtraParameters(extraParameters); - QCOMPARE(qgeorouterequest.extraParameters(), extraParameters); - qgeorouterequest.setExtraParameters(emptyParams); - QCOMPARE(qgeorouterequest.extraParameters(), emptyParams); -} - void tst_QGeoRouteRequest::departureTime_data() { QTest::addColumn<QDateTime>("departureTime"); diff --git a/tests/auto/qgeorouterequest/tst_qgeorouterequest.h b/tests/auto/qgeorouterequest/tst_qgeorouterequest.h index 4bae1b0d..a06417d4 100644 --- a/tests/auto/qgeorouterequest/tst_qgeorouterequest.h +++ b/tests/auto/qgeorouterequest/tst_qgeorouterequest.h @@ -66,8 +66,6 @@ private Q_SLOTS: void maneuverDetail_data(); void featureWeight(); void featureWeight_data(); - void extraParameters(); - void extraParameters_data(); void departureTime(); void departureTime_data(); //End Unit Test for QGeoRouteRequest |