fix expensive iteration over QMap::keys(), QHash::keys()

... and QJsonObject::keys()

Change-Id: I9a8ba44406a1e2cbdfffd266d2b5cb664f7440fc
Reviewed-by: Laszlo Agocs <laszlo.agocs@theqtcompany.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/src/positioning/qgeopositioninfosource.cpp b/src/positioning/qgeopositioninfosource.cpp
index 0cec8eaa..48cb27ad 100644
--- a/src/positioning/qgeopositioninfosource.cpp
+++ b/src/positioning/qgeopositioninfosource.cpp
@@ -329,11 +329,11 @@ QGeoPositionInfoSource *QGeoPositionInfoSource::createSource(const QString &sour
 QStringList QGeoPositionInfoSource::availableSources()
 {
     QStringList plugins;
-    QHash<QString, QJsonObject> meta = QGeoPositionInfoSourcePrivate::plugins();
-    foreach (const QString &name, meta.keys()) {
-        if (meta.value(name).value(QStringLiteral("Position")).isBool()
-                && meta.value(name).value(QStringLiteral("Position")).toBool()) {
-            plugins << name;
+    const QHash<QString, QJsonObject> meta = QGeoPositionInfoSourcePrivate::plugins();
+    for (auto it = meta.cbegin(), end = meta.cend(); it != end; ++it) {
+        if (it.value().value(QStringLiteral("Position")).isBool()
+                && it.value().value(QStringLiteral("Position")).toBool()) {
+            plugins << it.key();
         }
     }