diff options
| author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-09-14 21:44:54 +0200 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-09-19 14:52:41 +0200 |
| commit | ff4207b1a41db4d23d4d0183152776e73f252a3a (patch) | |
| tree | 7462fc69d09ac167b9af512220d4e819ac0c4b42 /src/plugins/geoservices/osm/qgeocodereplyosm.cpp | |
| parent | 29bf63108f954119a0df6c70dd283367777a7e23 (diff) | |
| download | qtlocation-ff4207b1a41db4d23d4d0183152776e73f252a3a.tar.gz | |
Cleanup: de-virtualize QGeoCodeReplyPrivate
The only call to the single virtual function, extraData(), was commented
out. The subclass in the OSM plugin only wrote extra data for debug runs
and the subclass in the mock plugin is never used to test anything anyway.
So remove all this overhead. As a drive-by, refactor to member
initialization and use qsizetype for members that refer to indices in a
QList.
Change-Id: I600b4637bc367ae45d51b2a7f9a3ae0b78fb77c4
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Reviewed-by: Santhosh Kumar <santhosh.kumar.selvaraj@qt.io>
Diffstat (limited to 'src/plugins/geoservices/osm/qgeocodereplyosm.cpp')
| -rw-r--r-- | src/plugins/geoservices/osm/qgeocodereplyosm.cpp | 19 |
1 files changed, 1 insertions, 18 deletions
diff --git a/src/plugins/geoservices/osm/qgeocodereplyosm.cpp b/src/plugins/geoservices/osm/qgeocodereplyosm.cpp index 22a6d1eb..6f1262a0 100644 --- a/src/plugins/geoservices/osm/qgeocodereplyosm.cpp +++ b/src/plugins/geoservices/osm/qgeocodereplyosm.cpp @@ -51,7 +51,7 @@ QT_BEGIN_NAMESPACE QGeoCodeReplyOsm::QGeoCodeReplyOsm(QNetworkReply *reply, bool includeExtraData, QObject *parent) -: QGeoCodeReply(*new QGeoCodeReplyOsmPrivate, parent), m_includeExtraData(includeExtraData) +: QGeoCodeReply(parent), m_includeExtraData(includeExtraData) { if (!reply) { setError(UnknownError, QStringLiteral("Null reply")); @@ -202,21 +202,4 @@ void QGeoCodeReplyOsm::networkReplyError(QNetworkReply::NetworkError error) setError(QGeoCodeReply::CommunicationError, reply->errorString()); } -QGeoCodeReplyOsmPrivate::QGeoCodeReplyOsmPrivate() -{ - -} - -QGeoCodeReplyOsmPrivate::~QGeoCodeReplyOsmPrivate() -{ - -} - -QVariantMap QGeoCodeReplyOsmPrivate::extraData() const -{ - return m_extraData; -} - QT_END_NAMESPACE - - |