Refactor: for loops

Replace indexed for loops with ranged for, replace int with qsizetype
otherwise as appropriate. Apply const and line breaks in surrounding
code.

Pick-to: 6.2
Change-Id: I1c2ee372545b8ab2cbb84c4b4b97ae52dedff1d0
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>

1 files changed, 5 insertions, 11 deletions

diff --git a/src/plugins/geoservices/esri/placesearchreply_esri.cpp b/src/plugins/geoservices/esri/placesearchreply_esri.cpp
index 2d26d2ca..1c79a6a1 100644
--- a/src/plugins/geoservices/esri/placesearchreply_esri.cpp
+++ b/src/plugins/geoservices/esri/placesearchreply_esri.cpp
@@ -119,28 +119,22 @@ void PlaceSearchReplyEsri::replyFinished()
         return;
 
     QJsonDocument document = QJsonDocument::fromJson(reply->readAll());
-    if (!document.isObject())
-    {
+    if (!document.isObject()) {
         setError(ParseError, tr("Response parse error"));
         return;
     }
 
     QJsonValue suggestions = document.object().value(kCandidatesKey);
-    if (!suggestions.isArray())
-    {
+    if (!suggestions.isArray()) {
         setError(ParseError, tr("Response parse error"));
         return;
     }
 
-    QJsonArray resultsArray = suggestions.toArray();
+    const QJsonArray resultsArray = suggestions.toArray();
 
     QList<QPlaceSearchResult> results;
-    for (int i = 0; i < resultsArray.count(); ++i)
-    {
-        QJsonObject item = resultsArray.at(i).toObject();
-        QPlaceResult placeResult = parsePlaceResult(item);
-        results.append(placeResult);
-    }
+    for (const auto result : resultsArray)
+        results.append(parsePlaceResult(result.toObject()));
 
     setResults(results);
     setFinished(true);