diff options
| author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-09-12 18:07:55 +0200 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-09-26 22:24:56 +0200 |
| commit | 64906d7dcba7702e7a36acfb5984410f7d91ac24 (patch) | |
| tree | 04b93c0f22c07ec8ecfa034ef9f35b0a0d5fba3d /src/location/quickmapitems/qdeclarativepolylinemapitem_p.h | |
| parent | fdbbfa4a6723b816478ee011ab4098e5332dc2f5 (diff) | |
| download | qtlocation-64906d7dcba7702e7a36acfb5984410f7d91ac24.tar.gz | |
Simplify Q(Declarative)GeoMapParameter
Move the initialPropertyCount to the QGeoMapParameter class, where
previously the 2 was hardcoded. Don't make type/setType virtual, as the
subclass doesn't override those methods anyway. Remove the unused
constructor taking a list of property names and values.
In QDeclarativeGeoMapParameter, optimize the dynamic connections between
property notification signals and the generic forwarder. Connect between
QMetaMethods, which avoids the repeated lookups, and give the
SignalMapper instances the QMetaProperty as a data member so that we
avoid the lookup of the signal for each signal emission, and only need
one connection per property, rather than two. Also, remove the empty
destructor and apply const where appropriate.
QDeclarativeGeoMapParameter is used only by QDeclarativePolyLineMapItem,
where support for the respective parameters, penStyle and penCap, is not
implemented in the rendering code. None of the other map items support
any such dynamic parameters, their support is not documented, and only
used in the mappolyline manual test. So remove all that code. If we want
to support more properties, then the QDeclarativeMapLineProperties type
gives us that infrastructure already.
Change-Id: Iddaac568a7dc09deb0bb5085b5b90c3cca0fa5ca
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Diffstat (limited to 'src/location/quickmapitems/qdeclarativepolylinemapitem_p.h')
| -rw-r--r-- | src/location/quickmapitems/qdeclarativepolylinemapitem_p.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/location/quickmapitems/qdeclarativepolylinemapitem_p.h b/src/location/quickmapitems/qdeclarativepolylinemapitem_p.h index 0f52aaaa..bd7cc9a2 100644 --- a/src/location/quickmapitems/qdeclarativepolylinemapitem_p.h +++ b/src/location/quickmapitems/qdeclarativepolylinemapitem_p.h @@ -139,7 +139,6 @@ Q_SIGNALS: void backendChanged(); protected Q_SLOTS: - void markSourceDirtyAndUpdate(); void updateAfterLinePropertiesChanged(); void afterViewportChanged(const QGeoMapViewportChangeEvent &event) override; @@ -147,9 +146,6 @@ protected: void geometryChange(const QRectF &newGeometry, const QRectF &oldGeometry) override; void setPathFromGeoList(const QList<QGeoCoordinate> &path); void updatePolish() override; - void componentComplete() override; - void updateLineStyleParameter(QGeoMapParameter *p, const char *propertyName); - void updateLineStyleParameter(QGeoMapParameter *p, const char *propertyName, bool update); #ifdef QT_LOCATION_DEBUG public: |