diff options
author | Alex Wilson <alex.wilson@nokia.com> | 2012-02-28 13:05:02 +1000 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-03-05 04:22:24 +0100 |
commit | 0287bfee05840511c12100f06f9142e3e2b8f7d5 (patch) | |
tree | f5386e27a4b012877d37ab0b99dfc1d5a08705c5 /src/location/places | |
parent | c1d56bdae90f79d466769aa7a357d78a4f2ca6c7 (diff) | |
download | qtlocation-0287bfee05840511c12100f06f9142e3e2b8f7d5.tar.gz |
New plugin API changes, centralized geoservice feature detection
This change adapts geoservice plugins to use the new Qt5 plugin API,
performing boolean feature detection all through the JSON blobs
rather than methods on factories or managers.
As a result of this centralisation, it was also necessary to rework
the QML API for the Plugin element a little. Some additional changes
were made to the declarative places plugin to prevent it crashing
due to plugins becoming available later than they did previously.
Task-number: QTBUG-24331
Change-Id: I26149987344b67091480449103ab1712c869b2a5
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
Diffstat (limited to 'src/location/places')
-rw-r--r-- | src/location/places/qplacemanager.cpp | 8 | ||||
-rw-r--r-- | src/location/places/qplacemanager.h | 21 | ||||
-rw-r--r-- | src/location/places/qplacemanagerengine.cpp | 9 | ||||
-rw-r--r-- | src/location/places/qplacemanagerengine.h | 2 |
4 files changed, 0 insertions, 40 deletions
diff --git a/src/location/places/qplacemanager.cpp b/src/location/places/qplacemanager.cpp index cfbb5137..d1f53d69 100644 --- a/src/location/places/qplacemanager.cpp +++ b/src/location/places/qplacemanager.cpp @@ -399,14 +399,6 @@ QPlace QPlaceManager::compatiblePlace(const QPlace &original) } /*! - Returns a set of flags indicating what particular features this manager instance supports. -*/ -QPlaceManager::ManagerFeatures QPlaceManager::supportedFeatures() const -{ - return d->supportedFeatures(); -} - -/*! Returns a reply which contains a list of places which correspond/match those specified in the \a request. The places specified in the request come from a different manager. diff --git a/src/location/places/qplacemanager.h b/src/location/places/qplacemanager.h index 7419658a..36e53415 100644 --- a/src/location/places/qplacemanager.h +++ b/src/location/places/qplacemanager.h @@ -72,23 +72,6 @@ class Q_LOCATION_EXPORT QPlaceManager : public QObject { Q_OBJECT public: - enum ManagerFeature { - NoFeatures = 0x0, - SavePlaceFeature = 0x1, - RemovePlaceFeature = 0x2, - SaveCategoryFeature = 0x4, - RemoveCategoryFeature = 0x8, - RecommendationsFeature = 0x10, - SearchSuggestionsFeature = 0x20, - CorrectionsFeature = 0x40, - LocaleFeature = 0x80, - NotificationsFeature = 0x100, - MatchingFeature = 0x200 - }; - - Q_DECLARE_FLAGS(ManagerFeatures, ManagerFeature) - Q_FLAGS(ManagerFeatures) - ~QPlaceManager(); QString managerName() const; @@ -123,8 +106,6 @@ public: QPlace compatiblePlace(const QPlace &place); - ManagerFeatures supportedFeatures() const; - QPlaceMatchReply *matchingPlaces(const QPlaceMatchRequest &request) const; Q_SIGNALS: @@ -149,8 +130,6 @@ private: friend class QPlaceIcon; }; -Q_DECLARE_OPERATORS_FOR_FLAGS(QPlaceManager::ManagerFeatures) - QT_END_NAMESPACE QT_END_HEADER diff --git a/src/location/places/qplacemanagerengine.cpp b/src/location/places/qplacemanagerengine.cpp index c2602521..0c076a37 100644 --- a/src/location/places/qplacemanagerengine.cpp +++ b/src/location/places/qplacemanagerengine.cpp @@ -345,15 +345,6 @@ QPlace QPlaceManagerEngine::compatiblePlace(const QPlace &original) const } /*! - Returns a set of flags indicating what particular features this manager engine instance - supports. -*/ -QPlaceManager::ManagerFeatures QPlaceManagerEngine::supportedFeatures() const -{ - return QPlaceManager::NoFeatures; -} - -/*! Returns a reply which contains a list of places which correspond/match those specified in \a request. */ diff --git a/src/location/places/qplacemanagerengine.h b/src/location/places/qplacemanagerengine.h index 9d3f14ed..66ee4f30 100644 --- a/src/location/places/qplacemanagerengine.h +++ b/src/location/places/qplacemanagerengine.h @@ -92,8 +92,6 @@ public: virtual QPlace compatiblePlace(const QPlace &original) const; - virtual QPlaceManager::ManagerFeatures supportedFeatures() const; - virtual QPlaceMatchReply *matchingPlaces(const QPlaceMatchRequest &request); Q_SIGNALS: |