diff options
author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-07-27 23:24:20 +0200 |
---|---|---|
committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-07-28 16:53:24 +0200 |
commit | 46c9adfd30636a4b13f5b66bbe019e51033a5f0b (patch) | |
tree | e53a9cd098f3561c7fb6b0d5007e0df999a3fec7 /src/location/maps/qgeocameratiles.cpp | |
parent | fc78a32507ccaa6c101dca2cc7a4d4061acea94f (diff) | |
download | qtlocation-46c9adfd30636a4b13f5b66bbe019e51033a5f0b.tar.gz |
Use 'const' correctly
Don't return or pass const copies, use either plain copies or const
references. Make getters const, make variables const, and use qAsConst
in ranged for loops to avoid detaches.
Pick-to: 6.2
Change-Id: If1463cf7f0077c08dedb15388d912b652c2b037c
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
Diffstat (limited to 'src/location/maps/qgeocameratiles.cpp')
-rw-r--r-- | src/location/maps/qgeocameratiles.cpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/location/maps/qgeocameratiles.cpp b/src/location/maps/qgeocameratiles.cpp index 1a401b53..21b45cc6 100644 --- a/src/location/maps/qgeocameratiles.cpp +++ b/src/location/maps/qgeocameratiles.cpp @@ -506,22 +506,20 @@ QGeoCameraTilesPrivate::ClippedFootprint QGeoCameraTilesPrivate::clipFootprintTo PolygonVector results = footprint; - if (clipY0) { + if (clipY0) results = splitPolygonAtAxisValue(results, 1, 0.0).second; - } - if (clipY1) { + if (clipY1) results = splitPolygonAtAxisValue(results, 1, side).first; - } - for (const QDoubleVector3D &p: results) { + for (const QDoubleVector3D &p : qAsConst(results)) { if ((p.x() < 0.0) || (qFuzzyIsNull(p.x()))) clipX0 = true; if ((p.x() > side) || (qFuzzyCompare(side, p.x()))) clipX1 = true; } - for (const QDoubleVector3D &v : results) { + for (const QDoubleVector3D &v : qAsConst(results)) { minX = qMin(v.x(), minX); maxX = qMax(v.x(), maxX); } |