Use 'const' correctly

Don't return or pass const copies, use either plain copies or const
references. Make getters const, make variables const, and use qAsConst
in ranged for loops to avoid detaches.

Pick-to: 6.2
Change-Id: If1463cf7f0077c08dedb15388d912b652c2b037c
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>

1 files changed, 5 insertions, 5 deletions

diff --git a/src/location/declarativemaps/qdeclarativepolylinemapitem_p_p.h b/src/location/declarativemaps/qdeclarativepolylinemapitem_p_p.h
index 0ec2f4a5..0cad6682 100644
--- a/src/location/declarativemaps/qdeclarativepolylinemapitem_p_p.h
+++ b/src/location/declarativemaps/qdeclarativepolylinemapitem_p_p.h
@@ -178,7 +178,7 @@ public:
         m_wrapOffset = wrapOffset;
     }
 
-    void setLineWidth(const float lw)
+    void setLineWidth(float lw)
     {
         m_lineWidth = lw;
     }
@@ -415,7 +415,7 @@ public:
     }
     QSGMaterialShader *createShader(QSGRendererInterface::RenderMode renderMode) const override;
 
-    void setMiter(const int m)
+    void setMiter(int m)
     {
         m_miter = m;
     }
@@ -462,10 +462,10 @@ public:
     ~MapPolylineNodeOpenGLExtruded() override;
 
     void update(const QColor &fillColor,
-                const float lineWidth,
+                float lineWidth,
                 const QGeoMapPolylineGeometryOpenGL *shape,
-                const QMatrix4x4 geoProjection,
-                const QDoubleVector3D center,
+                const QMatrix4x4 &geoProjection,
+                const QDoubleVector3D &center,
                 const Qt::PenCapStyle capStyle = Qt::FlatCap,
                 bool closed = false,
                 unsigned int zoom = 30);