summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergio Ahumada <sahumada@blackberry.com>2015-02-06 20:05:44 +0100
committerSergio Ahumada <sahumada@texla.cl>2015-02-09 08:55:16 +0000
commite27168074c9062f453059a6d95d1d99ca05b166c (patch)
tree5c1bc6f15e1b9581dafe99d71bfa1132cbcb82c3
parentd7a6fe8286cd402a8f81ec11d62f8107099726ab (diff)
downloadqtlocation-e27168074c9062f453059a6d95d1d99ca05b166c.tar.gz
Use single-char QString operations for efficiency
Change-Id: I45cf92e81e94cf62a21de2e01d9f8039ec1f2672 Reviewed-by: Alex Blasche <alexander.blasche@theqtcompany.com>
-rw-r--r--src/imports/positioning/qdeclarativepositionsource.cpp2
-rw-r--r--src/plugins/geoservices/nokia/qgeocodexmlparser.cpp2
-rw-r--r--src/plugins/geoservices/nokia/qgeoroutingmanagerengine_nokia.cpp10
-rw-r--r--src/plugins/geoservices/nokia/qgeouriprovider.cpp2
4 files changed, 8 insertions, 8 deletions
diff --git a/src/imports/positioning/qdeclarativepositionsource.cpp b/src/imports/positioning/qdeclarativepositionsource.cpp
index b688758a..f42518f3 100644
--- a/src/imports/positioning/qdeclarativepositionsource.cpp
+++ b/src/imports/positioning/qdeclarativepositionsource.cpp
@@ -243,7 +243,7 @@ void QDeclarativePositionSource::setNmeaSource(const QUrl &nmeaSource)
} else if (localFileName.startsWith("qrc:/")) {
localFileName.remove(0, 5);
}
- if (!QFile::exists(localFileName) && localFileName.startsWith("/")) {
+ if (!QFile::exists(localFileName) && localFileName.startsWith('/')) {
localFileName.remove(0,1);
}
}
diff --git a/src/plugins/geoservices/nokia/qgeocodexmlparser.cpp b/src/plugins/geoservices/nokia/qgeocodexmlparser.cpp
index 7862c470..fec7ba30 100644
--- a/src/plugins/geoservices/nokia/qgeocodexmlparser.cpp
+++ b/src/plugins/geoservices/nokia/qgeocodexmlparser.cpp
@@ -412,7 +412,7 @@ bool QGeoCodeXmlParser::parseAddress(QGeoAddress *address)
}
if (inThoroughfare && (m_reader->name() == "number")) {
- address->setStreet(m_reader->readElementText() + " " + address->street());
+ address->setStreet(m_reader->readElementText() + ' ' + address->street());
if (!m_reader->readNextStartElement())
inThoroughfare = false;
}
diff --git a/src/plugins/geoservices/nokia/qgeoroutingmanagerengine_nokia.cpp b/src/plugins/geoservices/nokia/qgeoroutingmanagerengine_nokia.cpp
index ce4deaef..f8c29c7b 100644
--- a/src/plugins/geoservices/nokia/qgeoroutingmanagerengine_nokia.cpp
+++ b/src/plugins/geoservices/nokia/qgeoroutingmanagerengine_nokia.cpp
@@ -246,7 +246,7 @@ QStringList QGeoRoutingManagerEngineNokia::calculateRouteRequestString(const QGe
baseRequest += QString::number(i);
baseRequest += QStringLiteral("=geo!");
baseRequest += trimDouble(request.waypoints().at(i).latitude());
- baseRequest += ",";
+ baseRequest += ',';
baseRequest += trimDouble(request.waypoints().at(i).longitude());
}
@@ -283,7 +283,7 @@ QStringList QGeoRoutingManagerEngineNokia::updateRouteRequestString(const QGeoRo
baseRequest += "&pos=";
baseRequest += QString::number(position.latitude());
- baseRequest += ",";
+ baseRequest += ',';
baseRequest += QString::number(position.longitude());
QGeoRouteRequest::RouteOptimizations optimization = route.request().routeOptimization();
@@ -328,7 +328,7 @@ QString QGeoRoutingManagerEngineNokia::modesRequestString(const QGeoRouteRequest
QString weightString = "";
switch (weight) {
case QGeoRouteRequest::PreferFeatureWeight:
- weightString = "1";
+ weightString = '1';
break;
case QGeoRouteRequest::AvoidFeatureWeight:
weightString = "-1";
@@ -370,9 +370,9 @@ QString QGeoRoutingManagerEngineNokia::modesRequestString(const QGeoRouteRequest
}
requestString += "&mode=";
- requestString += optimization + ";" + modes.join(",");
+ requestString += optimization + ';' + modes.join(',');
if (featureStrings.count())
- requestString += ";" + featureStrings.join(",");
+ requestString += ';' + featureStrings.join(',');
return requestString;
}
diff --git a/src/plugins/geoservices/nokia/qgeouriprovider.cpp b/src/plugins/geoservices/nokia/qgeouriprovider.cpp
index 932818a5..ceb86cf8 100644
--- a/src/plugins/geoservices/nokia/qgeouriprovider.cpp
+++ b/src/plugins/geoservices/nokia/qgeouriprovider.cpp
@@ -83,7 +83,7 @@ QString QGeoUriProvider::getCurrentHost() const
{
if (m_maxSubdomains) {
QString result(m_firstSubdomain.toLatin1() + qrand() % m_maxSubdomains);
- result += "." + m_currentHost;
+ result += '.' + m_currentHost;
return result;
}
return m_currentHost;