diff options
Diffstat (limited to 'render-test/render_test.cpp')
| -rw-r--r-- | render-test/render_test.cpp | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/render-test/render_test.cpp b/render-test/render_test.cpp index 5b2a91cac4..e9fbbe3654 100644 --- a/render-test/render_test.cpp +++ b/render-test/render_test.cpp @@ -178,11 +178,15 @@ int runRenderTests(int argc, char** argv, std::function<void()> testStatus) { } } - auto results = runner.run(metadata); + if (metadata.document.ObjectEmpty()) { + metadata.metricsErrored++; + metadata.renderErrored++; + } else { + runner.run(metadata); + } - bool errored = !metadata.errorMessage.empty() || !(results.probeFailed || results.renderFailed); - bool imageOK = (!metadata.outputsImage || !metadata.diff.empty()) && metadata.difference <= metadata.allowed; - bool passed = !errored && imageOK; + bool errored = metadata.metricsErrored || metadata.renderErrored; + bool passed = !errored && !metadata.metricsFailed && !metadata.renderFailed; if (shouldIgnore) { if (passed) { @@ -201,7 +205,7 @@ int runRenderTests(int argc, char** argv, std::function<void()> testStatus) { // to succeed on metrics failed so the rebaseline bot can run next in the // pipeline and collect the new baselines. The rebaseline bot will ultimately // report the error and block the patch from being merged. - if (results.renderFailed == false || !imageOK) { + if (metadata.renderErrored || metadata.renderFailed) { returnCode = 1; } |