summaryrefslogtreecommitdiff
path: root/src/mbgl/renderer
diff options
context:
space:
mode:
authorThiago Marcos P. Santos <tmpsantos@gmail.com>2020-03-27 18:30:35 +0200
committerThiago Marcos P. Santos <tmpsantos@gmail.com>2020-04-17 13:36:50 +0300
commita1e5bffa90b8846d709e49efa80e1293d89d8d16 (patch)
treefe6381e88953d2c60f7260b5d7b1fd7a77f4bee3 /src/mbgl/renderer
parente688a847a288c1ecee6dbeb85d16bedcce61ecc8 (diff)
downloadqtlocation-mapboxgl-a1e5bffa90b8846d709e49efa80e1293d89d8d16.tar.gz
[core] Fix performance-type-promotion-in-math-fn errors in header files
As reported by clang-tidy-8.
Diffstat (limited to 'src/mbgl/renderer')
-rw-r--r--src/mbgl/renderer/data_driven_property_evaluator.hpp12
-rw-r--r--src/mbgl/renderer/possibly_evaluated_property_value.hpp9
2 files changed, 13 insertions, 8 deletions
diff --git a/src/mbgl/renderer/data_driven_property_evaluator.hpp b/src/mbgl/renderer/data_driven_property_evaluator.hpp
index c2e6d9f283..bd476ebe58 100644
--- a/src/mbgl/renderer/data_driven_property_evaluator.hpp
+++ b/src/mbgl/renderer/data_driven_property_evaluator.hpp
@@ -1,9 +1,11 @@
#pragma once
-#include <mbgl/style/property_value.hpp>
-#include <mbgl/renderer/property_evaluation_parameters.hpp>
-#include <mbgl/renderer/possibly_evaluated_property_value.hpp>
#include <mbgl/renderer/cross_faded_property_evaluator.hpp>
+#include <mbgl/renderer/possibly_evaluated_property_value.hpp>
+#include <mbgl/renderer/property_evaluation_parameters.hpp>
+#include <mbgl/style/property_value.hpp>
+
+#include <cmath>
namespace mbgl {
@@ -31,7 +33,7 @@ public:
returnExpression.useIntegerZoom = true;
return ResultType(returnExpression);
}
- return ResultType(expression.evaluate(floor(parameters.z)));
+ return ResultType(expression.evaluate(std::floor(parameters.z)));
} else {
if (!expression.isFeatureConstant() || !expression.isRuntimeConstant()) {
return ResultType(expression);
@@ -66,7 +68,7 @@ public:
if (!expression.isFeatureConstant() || !expression.isRuntimeConstant()) {
return ResultType(expression);
} else {
- const T evaluated = expression.evaluate(floor(parameters.z));
+ const T evaluated = expression.evaluate(std::floor(parameters.z));
return ResultType(calculate(evaluated, evaluated, evaluated));
}
}
diff --git a/src/mbgl/renderer/possibly_evaluated_property_value.hpp b/src/mbgl/renderer/possibly_evaluated_property_value.hpp
index 466e042cbc..651c9676fb 100644
--- a/src/mbgl/renderer/possibly_evaluated_property_value.hpp
+++ b/src/mbgl/renderer/possibly_evaluated_property_value.hpp
@@ -1,10 +1,12 @@
#pragma once
-#include <mbgl/style/property_expression.hpp>
#include <mbgl/renderer/cross_faded_property_evaluator.hpp>
+#include <mbgl/style/property_expression.hpp>
#include <mbgl/util/interpolate.hpp>
#include <mbgl/util/variant.hpp>
+#include <cmath>
+
namespace mbgl {
template <class T>
@@ -110,9 +112,10 @@ public:
[&] (const Faded<T>& constant_) { return constant_; },
[&] (const style::PropertyExpression<T>& expression) {
if (!expression.isZoomConstant()) {
- const T min = expression.evaluate(floor(zoom), feature, availableImages, canonical, defaultValue);
+ const T min =
+ expression.evaluate(std::floor(zoom), feature, availableImages, canonical, defaultValue);
const T max =
- expression.evaluate(floor(zoom) + 1, feature, availableImages, canonical, defaultValue);
+ expression.evaluate(std::floor(zoom) + 1, feature, availableImages, canonical, defaultValue);
return Faded<T> {min, max};
} else {
const T evaluated = expression.evaluate(feature, availableImages, defaultValue);