diff options
| author | Mikhail Pozdnyakov <mikhail.pozdnyakov@mapbox.com> | 2019-05-13 16:37:40 +0300 |
|---|---|---|
| committer | Mikhail Pozdnyakov <mikhail.pozdnyakov@mapbox.com> | 2019-05-14 11:29:24 +0300 |
| commit | 5b6a262e1544fc9f649b53ef15ae19b9057356f1 (patch) | |
| tree | 004cf1678190a8a75bb48e002da39575793f3023 /src/mbgl/renderer/tile_parameters.hpp | |
| parent | 7e77aff8dfc2434846614f919cd4f8db1a2ca2f0 (diff) | |
| download | qtlocation-mapboxgl-5b6a262e1544fc9f649b53ef15ae19b9057356f1.tar.gz | |
[core] GeometryTile and TileLoader keep strong reference to FileSource
Thus we fix a potential bug: if `Renderer` outlives the `Map` it will hold a stale reference to the `FileSource` instance.
Diffstat (limited to 'src/mbgl/renderer/tile_parameters.hpp')
| -rw-r--r-- | src/mbgl/renderer/tile_parameters.hpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/mbgl/renderer/tile_parameters.hpp b/src/mbgl/renderer/tile_parameters.hpp index cbe8dfb3ba..6a2deee35c 100644 --- a/src/mbgl/renderer/tile_parameters.hpp +++ b/src/mbgl/renderer/tile_parameters.hpp @@ -2,6 +2,8 @@ #include <mbgl/map/mode.hpp> +#include <memory> + namespace mbgl { class TransformState; @@ -15,7 +17,7 @@ public: const float pixelRatio; const MapDebugOptions debugOptions; const TransformState& transformState; - FileSource& fileSource; + std::shared_ptr<FileSource> fileSource; const MapMode mode; AnnotationManager& annotationManager; ImageManager& imageManager; |