diff options
author | Chris Loer <chris.loer@gmail.com> | 2018-06-01 15:23:41 -0700 |
---|---|---|
committer | Fabian Guerra Soto <fabian.guerra@mapbox.com> | 2018-06-07 17:43:41 -0400 |
commit | 58b0faef55a3d75a8e4463156fb045c0e2bb7341 (patch) | |
tree | 0cc9d5097e14923d72c25cbb0c84b5ae64282796 /platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m | |
parent | 94ad8a6c7ef87b2dcad79ac570f9ce8651812f6f (diff) | |
download | qtlocation-mapboxgl-58b0faef55a3d75a8e4463156fb045c0e2bb7341.tar.gz |
[ios, test] Add MGLMapSnapshotter integration tests.
# Conflicts:
# platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m
Diffstat (limited to 'platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m')
-rw-r--r-- | platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m | 20 |
1 files changed, 11 insertions, 9 deletions
diff --git a/platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m b/platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m index 6a698121c9..f31f9cf787 100644 --- a/platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m +++ b/platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m @@ -104,11 +104,12 @@ NSString* validAccessToken() { [self waitForExpectations:@[expectation] timeout:2.0]; } -- (void)testSnapshotterFromBackgroundQueue { +- (void)testMultipleSnapshottersFromBackgroundQueue { if (!validAccessToken()) { return; } + // Crashes with only 1 snapshot CGSize size = self.mapView.bounds.size; CLLocationCoordinate2D coord = CLLocationCoordinate2DMake(30.0, 30.0); @@ -144,9 +145,10 @@ NSString* validAccessToken() { MGLTestAssertNotNil(strongself, snapshot.image); MGLTestAssertNil(strongself, error, @"Snapshot should not error with: %@", error); - // Change this to XCTAttachmentLifetimeKeepAlways to be able to look at the snapshots after running + // Change this back to XCTAttachmentLifetimeDeleteOnSuccess when we're sure this + // test is passing. XCTAttachment *attachment = [XCTAttachment attachmentWithImage:snapshot.image]; - attachment.lifetime = XCTAttachmentLifetimeDeleteOnSuccess; + attachment.lifetime = XCTAttachmentLifetimeKeepAlways; [strongself addAttachment:attachment]; dispatch_group_leave(group); @@ -172,11 +174,10 @@ NSString* validAccessToken() { }); }); - [self waitForExpectations:@[expectation] timeout:60.0]; + [self waitForExpectations:@[expectation] timeout:10.0]; } -- (void)testMultipleSnapshottersPENDING { - MGL_CHECK_IF_PENDING_TEST_SHOULD_RUN(); +- (void)testMultipleSnapshotters { if (!validAccessToken()) { return; } @@ -216,9 +217,10 @@ NSString* validAccessToken() { MGLTestAssertNotNil(strongself, snapshot.image); MGLTestAssertNil(strongself, error, @"Snapshot should not error with: %@", error); - // Change this to XCTAttachmentLifetimeKeepAlways to be able to look at the snapshots after running + // Change this back to XCTAttachmentLifetimeDeleteOnSuccess when we're sure this + // test is passing. XCTAttachment *attachment = [XCTAttachment attachmentWithImage:snapshot.image]; - attachment.lifetime = XCTAttachmentLifetimeDeleteOnSuccess; + attachment.lifetime = XCTAttachmentLifetimeKeepAlways; [strongself addAttachment:attachment]; // Dealloc the snapshotter (by having this line in the block, we @@ -231,7 +233,7 @@ NSString* validAccessToken() { }]; } // end for loop - [self waitForExpectations:@[expectation] timeout:60.0]; + [self waitForExpectations:@[expectation] timeout:20.0]; } @end |