diff options
author | Tobrun <tobrun@mapbox.com> | 2017-07-28 19:36:13 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-07-28 19:36:13 +0200 |
commit | 685b8b2c84e47d8126e924ff3fddc22a96237680 (patch) | |
tree | d8b72c5af496f1a7bf57b3661822501a3b7a8560 /platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml | |
parent | ba7574ec51e2cfd4a55565d5a8337c47f1784bc2 (diff) | |
download | qtlocation-mapboxgl-685b8b2c84e47d8126e924ff3fddc22a96237680.tar.gz |
Solve lint issues, reduce baseline (#9627)
* [android] - fix lint issues SDK
Diffstat (limited to 'platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml')
-rw-r--r-- | platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml | 2468 |
1 files changed, 38 insertions, 2430 deletions
diff --git a/platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml b/platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml index 89eab70c48..64e3d41bcc 100644 --- a/platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml +++ b/platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml @@ -1,1418 +1,65 @@ <?xml version="1.0" encoding="UTF-8"?> -<!-- REMEMBER! First you run Lint locally you'll need to move the lint-baseline.xml file +<!-- REMEMBER! First you run Lint locally you'll need to move lint-baseline-local.xml.xml file generated into the lint folder and called it lint-baseline-local.xml If you remove any error when running Lint locally, you'll get a warning from the command line advising you to remove it from the baseline. If you remove it (remember to remove it from lint-baseline-local.xml file) you should remove it too from lint-baseline-ci.xml (THIS FILE) which is the only one included in the repo. Eventually, it'll be removed (when we remove all current lint errors included). --> -<issues format="4" by="lint 2.3.1"> - - <issue - id="MissingPermission" - message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`" - errorLine1=" Location lastKnownLocation = locationEngine.getLastLocation();" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/maps/widgets/MyLocationView.java" - line="783" - column="38"/> - </issue> - - <issue - id="MissingPermission" - message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`" - errorLine1=" locationEngine.requestLocationUpdates();" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/maps/widgets/MyLocationView.java" - line="787" - column="9"/> - </issue> - - <issue - id="MissingPermission" - message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`" - errorLine1=" .target(new LatLng(Mapbox.getLocationSource().getLastLocation()))" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/androidTest/java/com/mapbox/mapboxsdk/testapp/maps/widgets/MyLocationViewTest.java" - line="107" - column="34"/> - </issue> - - <issue - id="DefaultLocale" - message="Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead" - errorLine1=" ((TextView) infoWindow.getView()).setText(String.format("%.2fkm", distanceKm));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/infowindow/DynamicInfoWindowAdapterActivity.java" - line="72" - column="53"/> - </issue> - - <issue - id="DefaultLocale" - message="Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead" - errorLine1=" Timber.v(String.format("[HTTP] Request was successful (code = %d).", response.code()));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java" - line="112" - column="16"/> - </issue> - - <issue - id="DefaultLocale" - message="Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead" - errorLine1=" Timber.d(String.format(" - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java" - line="116" - column="16"/> - </issue> - - <issue - id="DefaultLocale" - message="Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead" - errorLine1=" String.format("Snapshot taken in %d ms", duration)," - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/imagegenerator/SnapshotActivity.java" - line="59" - column="11"/> - </issue> - - <issue - id="InflateParams" - message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout's root element)" - errorLine1=" final View dialogContent = LayoutInflater.from(context).inflate(R.layout.dialog_camera_position, null);" - errorLine2=" ~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/camera/CameraPositionActivity.java" - line="89" - column="106"/> - </issue> - - <issue - id="StringFormatMatches" - message="Suspicious argument type for formatting argument #1 in `debug_zoom`: conversion is `s`, received `double` (argument #2 in method call) (Did you mean formatting character `e`, 'f', 'g' or `a`?)" - errorLine1=" textView.setText(String.format(getString(R.string.debug_zoom), position.zoom));" - errorLine2=" ~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/maplayout/DebugModeActivity.java" - line="60" - column="76"/> - <location - file="src/main/res/values/strings.xml" - line="186" - column="5"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `Could not add markers,` requires `0` but format call supplies `1`" - errorLine1=" Timber.e("Could not add markers,", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/annotation/BulkMarkerActivity.java" - line="277" - column="9"/> - </issue> - +<issues by="lint 2.3.1" format="4"> + <issue - id="TimberArgCount" - message="Wrong argument count, format string `That's not an url... ` requires `0` but format call supplies `1`" - errorLine1=" Timber.e("That's not an url... ", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/CircleLayerActivity.java" - line="77" - column="7"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `That's not an url... ` requires `0` but format call supplies `1`" - errorLine1=" Timber.e("That's not an url... ", malformedUrlException);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/CircleLayerActivity.java" - line="135" - column="7"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `Could not resolve package info` requires `0` but format call supplies `1`" - errorLine1=" Timber.e("Could not resolve package info", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/FeatureOverviewActivity.java" - line="95" - column="7"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `Failed to read the package metadata: ` requires `0` but format call supplies `1`" - errorLine1=" Timber.e("Failed to read the package metadata: ", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/storage/FileSource.java" - line="75" - column="7"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `Failed to read the storage key: ` requires `0` but format call supplies `1`" - errorLine1=" Timber.e("Failed to read the storage key: ", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/storage/FileSource.java" - line="77" - column="7"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `Failed to obtain the external storage path: ` requires `0` but format call supplies `1`" - errorLine1=" Timber.e("Failed to obtain the external storage path: ", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/storage/FileSource.java" - line="86" - column="9"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `Failed to delete old ambient cache database: ` requires `0` but format call supplies `1`" - errorLine1=" Timber.e("Failed to delete old ambient cache database: ", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/offline/OfflineManager.java" - line="113" - column="11"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `could not reflect` requires `0` but format call supplies `1`" - errorLine1=" Timber.e("could not reflect", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/OnMapReadyIdlingResource.java" - line="49" - column="7"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `Got NULL feature %s` requires `1` but format call supplies `0`" - errorLine1=" Timber.i("Got NULL feature %s");" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesBoxCountActivity.java" - line="84" - column="9"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `Got NULL feature %s` requires `1` but format call supplies `0`" - errorLine1=" Timber.i("Got NULL feature %s");" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesPropertiesActivity.java" - line="102" - column="9"/> - </issue> - - <issue - id="TimberArgCount" - message="Wrong argument count, format string `Invalid URL` requires `0` but format call supplies `1`" - errorLine1=" Timber.e("Invalid URL", malformedUrlException);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/RealTimeGeoJsonActivity.java" - line="58" - column="7"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Remove marker with " + activeMarker.getId());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/annotation/AddRemoveMarkerActivity.java" - line="118" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("showLowThresholdMarker() " + activeMarker.getId());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/annotation/AddRemoveMarkerActivity.java" - line="125" - column="14"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Remove marker with " + activeMarker.getId());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/annotation/AddRemoveMarkerActivity.java" - line="137" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("showHighThresholdMarker() " + activeMarker.getId());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/annotation/AddRemoveMarkerActivity.java" - line="144" - column="14"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.v("Connected: " + connected);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/net/ConnectivityReceiver.java" - line="85" - column="14"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Debug FAB: isDebug Active? " + mapboxMap.isDebugActive());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/maplayout/DebugModeActivity.java" - line="72" - column="20"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.e("That's not an url... " + malformedUrlException.getMessage());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/GeoJsonClusteringActivity.java" - line="131" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.e("Device returned an out of range width size, "" - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/maps/NativeMapView.java" - line="178" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.e("Device returned an out of range height size, "" - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/maps/NativeMapView.java" - line="185" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.e("Error: " + error);" - errorLine2=" ~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/offline/OfflineActivity.java" - line="210" - column="18"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Download started: " + regionName);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/offline/OfflineActivity.java" - line="226" - column="14"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Offline region created: " + regionName);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/offline/OfflineActivity.java" - line="244" - column="18"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.e("Error: " + error);" - errorLine2=" ~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/offline/OfflineActivity.java" - line="251" - column="18"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Selected item: " + which);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/model/other/OfflineListRegionsDialog.java" - line="35" - column="20"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Old ambient cache database deleted to save space: " + path);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/offline/OfflineManager.java" - line="110" - column="22"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.e("Failed to encode metadata: " + exception.getMessage());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/utils/OfflineUtils.java" - line="32" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.e("isMapboxReady called with value " + (mapboxMap != null));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/OnMapReadyIdlingResource.java" - line="46" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.e("Could not load geojson: " + ioException.getMessage());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesBoxSymbolCountActivity.java" - line="62" - column="20"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Fill anti alias: " + fillAntialias.getValue());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/RuntimeStyleActivity.java" - line="320" - column="14"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Fill translate anchor: " + fillTranslateAnchor.getValue());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/RuntimeStyleActivity.java" - line="323" - column="14"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Visibility: " + visibility.getValue());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/RuntimeStyleActivity.java" - line="325" - column="14"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Fill color base: " + stops.getBase());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/RuntimeStyleActivity.java" - line="480" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Fill color #stops: " + stops.size());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/RuntimeStyleActivity.java" - line="481" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d("Fill color #stops: " + stop);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/RuntimeStyleActivity.java" - line="484" - column="20"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.i("Writing style file to: " + cacheStyleFile.getAbsolutePath());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/StyleFileActivity.java" - line="75" - column="18"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d(label + ": begin");" - errorLine2=" ~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/utils/TimingLogger.java" - line="149" - column="14"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d(label + ": " + (now - prev) + " ms, " + splitLabel);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/utils/TimingLogger.java" - line="156" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.d(label + ": end, " + (now - first) + " ms");" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/utils/TimingLogger.java" - line="158" - column="14"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.e("Not setting minZoomPreference, value is in unsupported range: " + minZoom);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/maps/Transform.java" - line="349" - column="16"/> - </issue> - - <issue - id="BinaryOperationInTimber" - message="Replace String concatenation with Timber's string formatting" - errorLine1=" Timber.e("Not setting maxZoomPreference, value is in unsupported range: " + maxZoom);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/maps/Transform.java" - line="361" - column="16"/> - </issue> - - <issue - id="LogNotTimber" - message="Using 'Log' instead of 'Timber'" - errorLine1=" Log.w(LOG_TAG, ACCESS_TOKEN_NOT_SET_MESSAGE);" - errorLine2=" ~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/MapboxApplication.java" - line="58" - column="7"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.e(String.format("Stops: %s is a different type: %s", stops.getClass(), exception));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/style/functions/Function.java" - line="282" - column="16"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.v(String.format("[HTTP] Request was successful (code = %d).", response.code()));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java" - line="112" - column="16"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.d(String.format(" - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java" - line="116" - column="16"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.d(String.format(MapboxConstants.MAPBOX_LOCALE," - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java" - line="163" - column="16"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format(MapboxConstants.MAPBOX_LOCALE," - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java" - line="166" - column="16"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.w(String.format(MapboxConstants.MAPBOX_LOCALE," - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java" - line="170" - column="16"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.e(String.format("Layer: %s is a different type: %s", layerId, exception));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/maps/MapboxMap.java" - line="286" - column="16"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.e(String.format("Source: %s is a different type: %s", sourceId, exception));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/maps/MapboxMap.java" - line="407" - column="16"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format("Querying box %s", box));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/annotation/MarkerViewsInRectangleActivity.java" - line="56" - column="14"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.e(String.format(MapboxConstants.MAPBOX_LOCALE," - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/maps/NativeMapView.java" - line="92" - column="16"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.d(String.format(MapboxConstants.MAPBOX_LOCALE," - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/offline/OfflineActivity.java" - line="78" - column="14"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format("Querying box %s", box));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesBoxCountActivity.java" - line="51" - column="22"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format("Got %s features", features.size()));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesBoxCountActivity.java" - line="69" - column="14"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format("Got feature %s with %s properties and Geometry %s"," - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesBoxCountActivity.java" - line="72" - column="18"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format("Prop %s - %s", entry.getKey(), entry.getValue()));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesBoxCountActivity.java" - line="79" - column="22"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format("Querying box %s for buildings", box));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesBoxHighlightActivity.java" - line="56" - column="22"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format("Querying box %s", box));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesBoxSymbolCountActivity.java" - line="79" - column="22"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format(" - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesPropertiesActivity.java" - line="62" - column="22"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format("Got %s features", features.size()));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesPropertiesActivity.java" - line="87" - column="14"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format("Got feature %s with %s properties and Geometry %s"," - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesPropertiesActivity.java" - line="90" - column="18"/> - </issue> - - <issue - id="StringFormatInTimber" - message="Using 'String#format' inside of 'Timber'" - errorLine1=" Timber.i(String.format("Prop %s - %s", entry.getKey(), entry.getValue()));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/feature/QueryRenderedFeaturesPropertiesActivity.java" - line="97" - column="22"/> - </issue> - - <issue - id="ThrowableNotAtBeginning" - message="Throwable should be first argument" - errorLine1=" Timber.e("Could not add markers,", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/annotation/BulkMarkerActivity.java" - line="277" - column="9"/> - </issue> - - <issue - id="ThrowableNotAtBeginning" - message="Throwable should be first argument" - errorLine1=" Timber.e("That's not an url... ", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/CircleLayerActivity.java" - line="77" - column="7"/> - </issue> - - <issue - id="ThrowableNotAtBeginning" - message="Throwable should be first argument" - errorLine1=" Timber.e("That's not an url... ", malformedUrlException);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/CircleLayerActivity.java" - line="135" - column="7"/> - </issue> - - <issue - id="ThrowableNotAtBeginning" - message="Throwable should be first argument" - errorLine1=" Timber.e("Could not resolve package info", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/FeatureOverviewActivity.java" - line="95" - column="7"/> - </issue> - - <issue - id="ThrowableNotAtBeginning" - message="Throwable should be first argument" - errorLine1=" Timber.e("Failed to read the package metadata: ", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/storage/FileSource.java" - line="75" - column="7"/> - </issue> - - <issue - id="ThrowableNotAtBeginning" - message="Throwable should be first argument" - errorLine1=" Timber.e("Failed to read the storage key: ", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/storage/FileSource.java" - line="77" - column="7"/> - </issue> - - <issue - id="ThrowableNotAtBeginning" - message="Throwable should be first argument" - errorLine1=" Timber.e("Failed to obtain the external storage path: ", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/storage/FileSource.java" - line="86" - column="9"/> - </issue> - - <issue - id="ThrowableNotAtBeginning" - message="Throwable should be first argument" - errorLine1=" Timber.e("Failed to delete old ambient cache database: ", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/offline/OfflineManager.java" - line="113" - column="11"/> - </issue> - - <issue - id="ThrowableNotAtBeginning" - message="Throwable should be first argument" - errorLine1=" Timber.e("could not reflect", exception);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/OnMapReadyIdlingResource.java" - line="49" - column="7"/> - </issue> - - <issue - id="ThrowableNotAtBeginning" - message="Throwable should be first argument" - errorLine1=" Timber.e("Invalid URL", malformedUrlException);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/RealTimeGeoJsonActivity.java" - line="58" - column="7"/> - </issue> - - <issue - id="StaticFieldLeak" - message="Do not place Android context classes in static fields (static reference to `ConnectivityReceiver` which has field `context` pointing to `Context`); this is a memory leak (and also breaks Instant Run)" - errorLine1=" private static ConnectivityReceiver INSTANCE;" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/net/ConnectivityReceiver.java" - line="24" - column="3"/> - </issue> - - <issue - id="StaticFieldLeak" - message="Do not place Android context classes in static fields (static reference to `IconFactory` which has field `context` pointing to `Context`); this is a memory leak (and also breaks Instant Run)" - errorLine1=" private static IconFactory instance;" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/annotations/IconFactory.java" - line="38" - column="3"/> - </issue> - - <issue - id="StaticFieldLeak" - message="Do not place Android context classes in static fields (static reference to `Mapbox` which has field `context` pointing to `Context`); this is a memory leak (and also breaks Instant Run)" - errorLine1=" private static Mapbox INSTANCE;" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/Mapbox.java" - line="29" - column="3"/> - </issue> - - <issue - id="StaticFieldLeak" - message="Do not place Android context classes in static fields (static reference to `OfflineManager` which has field `context` pointing to `Context`); this is a memory leak (and also breaks Instant Run)" - errorLine1=" // This object is implemented as a singleton" - errorLine2=" ^"> - <location - file="src/main/java/com/mapbox/mapboxsdk/offline/OfflineManager.java" - line="42" - column="3"/> - </issue> - - <issue - id="UnpackedNativeCode" - message="Missing attribute android:extractNativeLibs="false" on the `<application>` tag." - errorLine1=" <application" - errorLine2=" ^"> - <location - file="src/main/AndroidManifest.xml" - line="8" - column="5"/> - </issue> - - <issue - id="MergeRootFrame" - message="This `<FrameLayout>` can be replaced with a `<merge>` tag" - errorLine1="<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"" - errorLine2="^"> - <location - file="src/main/res/layout/activity_building_layer.xml" - line="2" - column="1"/> - </issue> - - <issue - id="MergeRootFrame" - message="This `<FrameLayout>` can be replaced with a `<merge>` tag" - errorLine1="<FrameLayout" - errorLine2="^"> - <location - file="src/main/res/layout/activity_map_in_dialog.xml" - line="2" - column="1"/> - </issue> - - <issue - id="MergeRootFrame" - message="This `<FrameLayout>` can be replaced with a `<merge>` tag" - errorLine1="<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"" - errorLine2="^"> - <location - file="src/main/res/layout/activity_map_padding.xml" - line="2" - column="1"/> - </issue> - - <issue - id="DisableBaselineAlignment" - message="Set `android:baselineAligned="false"` on this element for better performance" - errorLine1=" <LinearLayout" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_multi_map.xml" - line="10" - column="5"/> - </issue> - - <issue - id="DisableBaselineAlignment" - message="Set `android:baselineAligned="false"` on this element for better performance" - errorLine1=" <LinearLayout" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_multi_map.xml" - line="42" - column="5"/> - </issue> - - <issue - id="NestedWeights" - message="Nested weights are bad for performance" - errorLine1=" android:layout_weight="0.5"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_multi_map.xml" - line="23" - column="13"/> - </issue> - - <issue - id="NestedWeights" - message="Nested weights are bad for performance" - errorLine1=" android:layout_weight="0.5"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_multi_map.xml" - line="55" - column="13"/> - </issue> - - <issue - id="Overdraw" - message="Possible overdraw: Root element paints background `#cccc` with a theme that also paints a background (inferred theme is `@style/AppTheme`)" errorLine1=" android:background="#cccc"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~" + id="Overdraw" + message="Possible overdraw: Root element paints background `#cccc` with a theme that also paints a background (inferred theme is `@style/AppTheme`)"> <location + column="5" file="src/main/res/layout/drawer_navigation_drawer.xml" - line="4" - column="5"/> + line="4"/> </issue> <issue - id="Overdraw" - message="Possible overdraw: Root element paints background `?android:attr/selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/AppTheme`)" errorLine1=" android:background="?android:attr/selectableItemBackground"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" + id="Overdraw" + message="Possible overdraw: Root element paints background `?android:attr/selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/AppTheme`)"> <location + column="5" file="src/main/res/layout/item_main_feature.xml" - line="6" - column="5"/> + line="6"/> </issue> <issue - id="Overdraw" - message="Possible overdraw: Root element paints background `@color/mapboxGreen` with a theme that also paints a background (inferred theme is `@style/AppTheme`)" errorLine1=" android:background="@color/mapboxGreen">" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" + id="Overdraw" + message="Possible overdraw: Root element paints background `@color/mapboxGreen` with a theme that also paints a background (inferred theme is `@style/AppTheme`)"> <location + column="5" file="src/main/res/layout/view_text_marker.xml" - line="5" - column="5"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.color.mapbox_my_location_ring` appears to be unused" - errorLine1=" <color name="mapbox_my_location_ring">@color/mapbox_blue</color>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/colors.xml" - line="6" - column="12"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.mapbox_access_token` appears to be unused" - errorLine1=" <string name="mapbox_access_token">YOUR_MAPBOX_ACCESS_TOKEN_GOES_HERE</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/values/developer-config.xml" - line="3" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.dimen.mapbox_infowindow_offset` appears to be unused" - errorLine1=" <dimen name="mapbox_infowindow_offset">-2dp</dimen>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/dimens.xml" - line="5" - column="12"/> + line="5"/> </issue> <issue - id="UnusedResources" - message="The resource `R.dimen.coordinatebounds_margin` appears to be unused" - errorLine1=" <dimen name="coordinatebounds_margin">32dp</dimen>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/values/dimens.xml" - line="6" - column="12"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.dimen.mapbox_infowindow_line_width` appears to be unused" - errorLine1=" <dimen name="mapbox_infowindow_line_width">1.5dp</dimen>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/dimens.xml" - line="6" - column="12"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.dimen.mapbox_attribution_icon_left_padding` appears to be unused" - errorLine1=" <dimen name="mapbox_attribution_icon_left_padding">@dimen/mapbox_two_dp</dimen>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/dimens.xml" - line="7" - column="12"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.dimen.mapbox_attribution_icon_top_padding` appears to be unused" - errorLine1=" <dimen name="mapbox_attribution_icon_top_padding">@dimen/mapbox_two_dp</dimen>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/dimens.xml" - line="8" - column="12"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.dimen.mapbox_attribution_icon_right_padding` appears to be unused" - errorLine1=" <dimen name="mapbox_attribution_icon_right_padding">@dimen/mapbox_two_dp</dimen>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/dimens.xml" - line="9" - column="12"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.dimen.mapbox_attribution_icon_bottom_padding` appears to be unused" - errorLine1=" <dimen name="mapbox_attribution_icon_bottom_padding">@dimen/mapbox_two_dp</dimen>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/dimens.xml" - line="10" - column="12"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.dimen.mapbox_two_dp` appears to be unused" - errorLine1=" <dimen name="mapbox_two_dp">2dp</dimen>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/dimens.xml" - line="11" - column="12"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.dimen.mapbox_ten_dp` appears to be unused" - errorLine1=" <dimen name="mapbox_ten_dp">10dp</dimen>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/dimens.xml" - line="14" - column="12"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.dimen.mapbox_sixteen_dp` appears to be unused" - errorLine1=" <dimen name="mapbox_sixteen_dp">16dp</dimen>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/dimens.xml" - line="15" - column="12"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.drawable.ic_check_box` appears to be unused" - errorLine1="<vector xmlns:android="http://schemas.android.com/apk/res/android"" - errorLine2="^"> - <location - file="src/main/res/drawable/ic_check_box.xml" - line="1" - column="1"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.drawable.mapbox_infowindow_icon_bg` appears to be unused"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/drawable-xxxhdpi/mapbox_infowindow_icon_bg.9.png"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.color.mapbox_material_bg_selector` appears to be unused" - errorLine1="<selector xmlns:android="http://schemas.android.com/apk/res/android">" - errorLine2="^"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/color/mapbox_material_bg_selector.xml" - line="2" - column="1"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.drawable.marker` appears to be unused" - errorLine1="<shape xmlns:android="http://schemas.android.com/apk/res/android" android:shape="rectangle">" - errorLine2="^"> - <location - file="src/main/res/drawable/marker.xml" - line="1" - column="1"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.mapbox_style_outdoors` appears to be unused" - errorLine1=" <string name="mapbox_style_outdoors" translatable="false">mapbox://styles/mapbox/outdoors-v10</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/strings.xml" - line="22" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.mapbox_style_traffic_day` appears to be unused" - errorLine1=" <string name="mapbox_style_traffic_day" translatable="false">mapbox://styles/mapbox/traffic-day-v2</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/strings.xml" - line="27" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.mapbox_style_traffic_night` appears to be unused" - errorLine1=" <string name="mapbox_style_traffic_night" translatable="false">mapbox://styles/mapbox/traffic-night-v2</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/values/strings.xml" - line="28" - column="13"/> - </issue> - - <issue - id="UselessParent" - message="This `FrameLayout` layout or its `LinearLayout` parent is possibly useless" - errorLine1=" <FrameLayout" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_my_location_customization.xml" - line="9" - column="5"/> - </issue> - - <issue - id="UnusedIds" - message="The resource `R.id.fabStartStop` appears to be unused" - errorLine1=" android:id="@+id/fabStartStop"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_animated_image_source.xml" - line="18" - column="5"/> - </issue> - - <issue - id="UnusedIds" - message="The resource `R.id.map_container` appears to be unused" - errorLine1=" android:id="@+id/map_container"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_multi_map.xml" - line="5" - column="5"/> - </issue> - - <issue - id="UnusedIds" - message="The resource `R.id.map_container1` appears to be unused" - errorLine1=" android:id="@+id/map_container1"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_multi_map.xml" - line="11" - column="9"/> - </issue> - - <issue - id="UnusedIds" - message="The resource `R.id.map_container2` appears to be unused" - errorLine1=" android:id="@+id/map_container2"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_multi_map.xml" - line="43" - column="9"/> - </issue> - - <issue - id="UnusedIds" - message="The resource `R.id.content_frame` appears to be unused" - errorLine1=" android:id="@+id/content_frame"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_scroll_by.xml" - line="69" - column="9"/> - </issue> - - <issue - id="UnusedIds" - message="The resource `R.id.viewpager_header` appears to be unused" - errorLine1=" android:id="@+id/viewpager_header"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_viewpager.xml" - line="13" - column="13"/> - </issue> - - <issue - id="UnusedIds" - message="The resource `R.id.map_card` appears to be unused" - errorLine1=" android:id="@+id/map_card"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/fragment_double_map.xml" - line="12" - column="9"/> - </issue> - - <issue - id="UnusedIds" - message="The resource `R.id.infowindow_subdescription` appears to be unused" - errorLine1=" android:id="@+id/infowindow_subdescription"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="/src/platform/android/MapboxGLAndroidSDK/src/main/res/layout/mapbox_infowindow_content.xml" - line="43" - column="9"/> - </issue> - - <issue - id="TypographyQuotes" - message="Replace straight quotes ('') with directional quotes (‘’, &#8216; and &#8217;) ?" errorLine1=" <string name="mapbox_attributionTelemetryMessage">Estàs ajudant a millorar els mapes d\'OpenStreetMap i de Mapbox aportant dades d\'ús anònimes.</string>" - errorLine2=" ^"> + errorLine2=" ^" + id="TypographyQuotes" + message="Replace straight quotes ('') with directional quotes (‘’, &#8216; and &#8217;) ?"> <location + column="55" file="src/main/res/values-ca/strings.xml" - line="9" - column="55"/> + line="9"/> </issue> <issue id="IconDipSize" - message="The image `icon_burned.png` varies significantly in its density-independent (dip) size across the various density versions: drawable-hdpi/icon_burned.png: 64x64 dp (96x96 px), drawable-xxxhdpi/icon_burned.png: 48x48 dp (192x192 px), drawable-xxhdpi/icon_burned.png: 48x48 dp (144x144 px), drawable-mdpi/icon_burned.png: 48x48 dp (48x48 px), drawable-xhdpi/icon_burned.png: 48x48 dp (96x96 px)"> - <location - file="src/main/res/drawable-xhdpi/icon_burned.png"/> + message="The image `icon_burned.png` varies significantly in its density-independent (dip) size across the various density versions: drawable-hdpi/icon_burned.png: 64x64 dp (96x96 px), drawable-xxxhdpi/icon_burned.png: 48x48 dp (192x192 px), drawable-xxhdpi/icon_burned.png: 48x48 dp (144x144 px), drawable-xhdpi/icon_burned.png: 48x48 dp (96x96 px), drawable-mdpi/icon_burned.png: 48x48 dp (48x48 px)"> <location file="src/main/res/drawable-mdpi/icon_burned.png"/> <location + file="src/main/res/drawable-xhdpi/icon_burned.png"/> + <location file="src/main/res/drawable-xxhdpi/icon_burned.png"/> <location file="src/main/res/drawable-xxxhdpi/icon_burned.png"/> @@ -1500,1070 +147,31 @@ </issue> <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1=" <TextView" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_debug_mode.xml" - line="18" - column="5"/> - </issue> - - <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1=" <TextView" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_marker_bulk.xml" - line="18" - column="5"/> - </issue> - - <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1=" <TextView" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_marker_view.xml" - line="18" - column="5"/> - </issue> - - <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1=" <TextView" - errorLine2=" ^"> - <location - file="src/main/res/layout/item_main_feature.xml" - line="14" - column="5"/> - </issue> - - <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1=" <TextView" - errorLine2=" ^"> - <location - file="src/main/res/layout/item_main_feature.xml" - line="25" - column="5"/> - </issue> - - <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1="<TextView" - errorLine2="^"> - <location - file="src/main/res/layout/mapbox_attribution_list_item.xml" - line="2" - column="1"/> - </issue> - - <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1=" <TextView" - errorLine2=" ^"> - <location - file="src/main/res/layout/mapbox_infowindow_content.xml" - line="21" - column="5"/> - </issue> - - <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1=" <TextView" - errorLine2=" ^"> - <location - file="src/main/res/layout/mapbox_infowindow_content.xml" - line="31" - column="5"/> - </issue> - - <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1=" <TextView" - errorLine2=" ^"> - <location - file="src/main/res/layout/section_main_layout.xml" - line="13" - column="5"/> - </issue> - - <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1=" <TextView" - errorLine2=" ^"> - <location - file="src/main/res/layout/view_custom_marker.xml" - line="11" - column="5"/> - </issue> - - <issue - id="SelectableText" - message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`" - errorLine1=" <TextView" - errorLine2=" ^"> - <location - file="src/main/res/layout/view_text_marker.xml" - line="7" - column="5"/> - </issue> - - <issue - id="ButtonStyle" - message="Buttons in button bars should be borderless; use `style="?android:attr/buttonBarButtonStyle"` (and `?android:attr/buttonBarStyle` on the parent)" - errorLine1=" <Button" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_camera_animation_types.xml" - line="24" - column="9"/> - </issue> - - <issue - id="ButtonStyle" - message="Buttons in button bars should be borderless; use `style="?android:attr/buttonBarButtonStyle"` (and `?android:attr/buttonBarStyle` on the parent)" - errorLine1=" <Button" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_camera_animation_types.xml" - line="31" - column="9"/> - </issue> - - <issue - id="ButtonStyle" - message="Buttons in button bars should be borderless; use `style="?android:attr/buttonBarButtonStyle"` (and `?android:attr/buttonBarStyle` on the parent)" - errorLine1=" <Button" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_camera_animation_types.xml" - line="38" - column="9"/> - </issue> - - <issue - id="GoogleAppIndexingWarning" - message="App is not indexable by Google Search; consider adding at least one Activity with an ACTION-VIEW intent filter. See issue explanation for more details." - errorLine1=" <application" - errorLine2=" ^"> - <location - file="src/main/AndroidManifest.xml" - line="8" - column="5"/> - </issue> - - <issue - id="ContentDescription" - message="[Accessibility] Missing `contentDescription` attribute on image" - errorLine1=" <ImageView" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_snapshot.xml" - line="14" - column="9"/> - </issue> - - <issue - id="ContentDescription" - message="[Accessibility] Missing `contentDescription` attribute on image" - errorLine1="<ImageView xmlns:android="http://schemas.android.com/apk/res/android"" - errorLine2="^"> - <location - file="src/main/res/layout/mapbox_view_image_marker.xml" - line="2" - column="1"/> - </issue> - - <issue - id="ContentDescription" - message="[Accessibility] Missing `contentDescription` attribute on image" - errorLine1=" <ImageView" - errorLine2=" ^"> - <location - file="src/main/res/layout/view_custom_marker.xml" - line="6" - column="5"/> - </issue> - - <issue - id="SetTextI18n" - message="String literal in `setText` can not be translated. Use Android resources instead." - errorLine1=" textView.setText("Click the map to calculate the distance");" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/infowindow/DynamicInfoWindowAdapterActivity.java" - line="103" - column="26"/> - </issue> - - <issue - id="SetTextI18n" - message="Do not concatenate text displayed with `setText`. Use resource string with placeholders." - errorLine1=" viewCountView.setText("ViewCache size " + markerViewContainer.getChildCount());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/annotation/MarkerViewActivity.java" - line="153" - column="39"/> - </issue> - - <issue - id="SetTextI18n" - message="String literal in `setText` can not be translated. Use Android resources instead." - errorLine1=" viewCountView.setText("ViewCache size " + markerViewContainer.getChildCount());" - errorLine2=" ~~~~~~~~~~~~~~~~~"> - <location - file="src/main/java/com/mapbox/mapboxsdk/testapp/activity/annotation/MarkerViewActivity.java" - line="153" - column="39"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "No Results", should use `@string` resource" - errorLine1=" android:text="No Results"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_metadata_update.xml" - line="18" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "No Results", should use `@string` resource" - errorLine1=" android:text="No Results"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_offline_region_delete.xml" - line="18" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Move the map by x/y pixels", should use `@string` resource" - errorLine1=" android:text="Move the map by x/y pixels"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_scroll_by.xml" - line="25" - column="17"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "X: 0000", should use `@string` resource" - errorLine1=" android:text="X: 0000" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_scroll_by.xml" - line="35" - column="17"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Y: 0000", should use `@string` resource" - errorLine1=" android:text="Y: 0000" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_scroll_by.xml" - line="51" - column="17"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Latitude", should use `@string` resource" - errorLine1=" android:text="Latitude"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="19" - column="13"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "-180", should use `@string` resource" - errorLine1=" android:text="-180"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="41" - column="13"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Longitude", should use `@string` resource" - errorLine1=" android:text="Longitude" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="59" - column="13"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "-180", should use `@string` resource" - errorLine1=" android:text="-180" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="81" - column="13"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Zoom", should use `@string` resource" - errorLine1=" android:text="Zoom" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="98" - column="13"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "18", should use `@string` resource" - errorLine1=" android:text="18" />" - errorLine2=" ~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="120" - column="13"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Bearing", should use `@string` resource" - errorLine1=" android:text="Bearing" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="137" - column="13"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "0", should use `@string` resource" - errorLine1=" android:text="0" />" - errorLine2=" ~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="159" - column="13"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Tilt", should use `@string` resource" - errorLine1=" android:text="Tilt" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="176" - column="13"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "0", should use `@string` resource" - errorLine1=" android:text="0" />" - errorLine2=" ~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="198" - column="13"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Change intensity", should use `@string` resource" - errorLine1=" android:title="Change intensity"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_building.xml" - line="6" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Change Anchor", should use `@string` resource" - errorLine1=" android:title="Change Anchor"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_building.xml" - line="10" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Amount of markers", should use `@string` resource" - errorLine1=" android:title="Amount of markers"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_bulk_marker.xml" - line="6" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Update layer (invalidate)", should use `@string` resource" - errorLine1=" android:title="Update layer (invalidate)" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_custom_layer.xml" - line="7" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Red", should use `@string` resource" - errorLine1=" android:title="Red" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_custom_layer.xml" - line="10" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Green", should use `@string` resource" - errorLine1=" android:title="Green" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_custom_layer.xml" - line="13" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Blue", should use `@string` resource" - errorLine1=" android:title="Blue" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_custom_layer.xml" - line="16" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add an exponential zoom function", should use `@string` resource" - errorLine1=" android:title="Add an exponential zoom function"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_data_driven_style.xml" - line="7" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add an interval zoom function", should use `@string` resource" - errorLine1=" android:title="Add an interval zoom function"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_data_driven_style.xml" - line="12" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add a categorical source function", should use `@string` resource" - errorLine1=" android:title="Add a categorical source function"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_data_driven_style.xml" - line="17" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add an exponential source function", should use `@string` resource" - errorLine1=" android:title="Add an exponential source function"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_data_driven_style.xml" - line="22" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add an identity source function", should use `@string` resource" - errorLine1=" android:title="Add an identity source function"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_data_driven_style.xml" - line="27" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add an interval source function", should use `@string` resource" - errorLine1=" android:title="Add an interval source function"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_data_driven_style.xml" - line="32" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add a composite, exponential function", should use `@string` resource" - errorLine1=" android:title="Add a composite, exponential function"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_data_driven_style.xml" - line="37" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add a composite, categorical function", should use `@string` resource" - errorLine1=" android:title="Add a composite, categorical function"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_data_driven_style.xml" - line="42" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add a composite, interval function", should use `@string` resource" - errorLine1=" android:title="Add a composite, interval function"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_data_driven_style.xml" - line="47" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "My Location Tracking", should use `@string` resource" - errorLine1=" android:title="My Location Tracking"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_padding.xml" - line="6" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Bangalore", should use `@string` resource" - errorLine1=" android:title="Bangalore"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_padding.xml" - line="10" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "List all layers in the style", should use `@string` resource" - errorLine1=" android:title="List all layers in the style"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="7" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "List all sources in the style", should use `@string` resource" - errorLine1=" android:title="List all sources in the style"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="11" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Color the water", should use `@string` resource" - errorLine1=" android:title="Color the water"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="15" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Set background opacity", should use `@string` resource" - errorLine1=" android:title="Set background opacity"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="19" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Set road symbol placement to Point", should use `@string` resource" - errorLine1=" android:title="Set road symbol placement to Point"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="23" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Set layer visibility to false", should use `@string` resource" - errorLine1=" android:title="Set layer visibility to false"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="27" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add a parks layer", should use `@string` resource" - errorLine1=" android:title="Add a parks layer"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="31" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add a dynamic GeoJSON source", should use `@string` resource" - errorLine1=" android:title="Add a dynamic GeoJSON source"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="35" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Remove buildings layer", should use `@string` resource" - errorLine1=" android:title="Remove buildings layer"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="39" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add a terrain layer", should use `@string` resource" - errorLine1=" android:title="Add a terrain layer"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="43" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Add a satellite layer", should use `@string` resource" - errorLine1=" android:title="Add a satellite layer"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="47" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Change the water color on zoom", should use `@string` resource" - errorLine1=" android:title="Change the water color on zoom"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="51" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Custom tiles", should use `@string` resource" - errorLine1=" android:title="Custom tiles"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="55" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Apply filtered fill", should use `@string` resource" - errorLine1=" android:title="Apply filtered fill"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="59" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Apply filtered line", should use `@string` resource" - errorLine1=" android:title="Apply filtered line"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="63" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Apply numeric fill filter", should use `@string` resource" - errorLine1=" android:title="Apply numeric fill filter"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_runtime_style.xml" - line="67" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Toggle text size", should use `@string` resource" - errorLine1=" android:title="Toggle text size"/>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_symbol_layer.xml" - line="6" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Toggle text field contents", should use `@string` resource" - errorLine1=" android:title="Toggle text field contents"/>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_symbol_layer.xml" - line="10" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Toggle text font", should use `@string` resource" - errorLine1=" android:title="Toggle text font"/>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_symbol_layer.xml" - line="14" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Zoom in", should use `@string` resource" - errorLine1=" android:title="Zoom in"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_zoom.xml" - line="6" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Zoom out", should use `@string` resource" - errorLine1=" android:title="Zoom out"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_zoom.xml" - line="10" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Zoom by 2", should use `@string` resource" - errorLine1=" android:title="Zoom by 2"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_zoom.xml" - line="14" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Zoom to point", should use `@string` resource" - errorLine1=" android:title="Zoom to point"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_zoom.xml" - line="18" - column="9"/> - </issue> - - <issue - id="HardcodedText" - message="[I18N] Hardcoded string "Zoom to 4", should use `@string` resource" - errorLine1=" android:title="Zoom to 4"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/menu/menu_zoom.xml" - line="22" - column="9"/> - </issue> - - <issue - id="RelativeOverlap" - message="`@id/button_list_regions` can overlap `@id/button_download_region` if @string/button_download_region, @string/button_list_regions grow due to localized text expansion" - errorLine1=" <Button" - errorLine2=" ^"> - <location - file="src/main/res/layout/activity_offline.xml" - line="33" - column="5"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_marginEnd="@dimen/fab_margin"` to better support right-to-left layouts" - errorLine1=" android:layout_marginRight="@dimen/fab_margin"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_animated_image_source.xml" - line="25" - column="5"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_marginEnd="@dimen/fab_margin"` to better support right-to-left layouts" - errorLine1=" android:layout_marginRight="@dimen/fab_margin"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_circle_layer.xml" - line="25" - column="9"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_marginEnd="@dimen/fab_margin"` to better support right-to-left layouts" - errorLine1=" android:layout_marginRight="@dimen/fab_margin"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_circle_layer.xml" - line="37" - column="9"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_marginEnd="@dimen/fab_margin"` to better support right-to-left layouts" - errorLine1=" android:layout_marginRight="@dimen/fab_margin"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_debug_mode.xml" - line="32" - column="9"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_alignParentEnd="true"` to better support right-to-left layouts" - errorLine1=" android:layout_alignParentRight="true"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_offline.xml" - line="38" - column="9"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_marginEnd="@dimen/fab_margin"` to better support right-to-left layouts" - errorLine1=" android:layout_marginRight="@dimen/fab_margin"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_offline.xml" - line="39" - column="9"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_marginStart="56dp"` to better support right-to-left layouts" - errorLine1=" android:layout_marginLeft="56dp"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_scroll_by.xml" - line="42" - column="17"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_marginStart="56dp"` to better support right-to-left layouts" - errorLine1=" android:layout_marginLeft="56dp"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/activity_scroll_by.xml" - line="59" - column="17"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_toStartOf="@+id/value_lat"` to better support right-to-left layouts" - errorLine1=" android:layout_toLeftOf="@+id/value_lat"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="28" - column="13"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_toEndOf="@id/text_lat"` to better support right-to-left layouts" - errorLine1=" android:layout_toRightOf="@id/text_lat"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="29" - column="13"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_toStartOf="@+id/value_lon"` to better support right-to-left layouts" - errorLine1=" android:layout_toLeftOf="@+id/value_lon"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="67" - column="13"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_toEndOf="@id/text_lon"` to better support right-to-left layouts" - errorLine1=" android:layout_toRightOf="@id/text_lon"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="68" - column="13"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_toStartOf="@+id/value_zoom"` to better support right-to-left layouts" - errorLine1=" android:layout_toLeftOf="@+id/value_zoom"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="106" - column="13"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_toEndOf="@id/text_zoom"` to better support right-to-left layouts" - errorLine1=" android:layout_toRightOf="@id/text_zoom"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/dialog_camera_position.xml" - line="107" - column="13"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider adding `android:layout_toStartOf="@+id/value_bearing"` to better support right-to-left layouts" - errorLine1=" android:layout_toLeftOf="@+id/value_bearing"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> + id="IconDensities" + message="Missing the following drawables in `drawable-hdpi`: ic_car_top.png, ic_taxi_top.png, ic_us.png, southeast_radar_0.png, southeast_radar_1.png... (2 more)"> <location - file="src/main/res/layout/dialog_camera_position.xml" - line="145" - column="13"/> + file="src/main/res/drawable-hdpi"/> </issue> <issue - id="RtlHardcoded" - message="Consider adding `android:layout_toEndOf="@id/text_bearing"` to better support right-to-left layouts" - errorLine1=" android:layout_toRightOf="@id/text_bearing"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> + id="IconDensities" + message="Missing the following drawables in `drawable-mdpi`: ic_car_top.png, ic_taxi_top.png, ic_us.png"> <location - file="src/main/res/layout/dialog_camera_position.xml" - line="146" - column="13"/> + file="src/main/res/drawable-mdpi"/> </issue> <issue - id="RtlHardcoded" - message="Consider adding `android:layout_toStartOf="@+id/value_tilt"` to better support right-to-left layouts" - errorLine1=" android:layout_toLeftOf="@+id/value_tilt"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> + id="IconDensities" + message="Missing the following drawables in `drawable-xhdpi`: ic_car_top.png, ic_taxi_top.png, ic_us.png, southeast_radar_0.png, southeast_radar_1.png... (2 more)"> <location - file="src/main/res/layout/dialog_camera_position.xml" - line="184" - column="13"/> + file="src/main/res/drawable-xhdpi"/> </issue> <issue - id="RtlHardcoded" - message="Consider adding `android:layout_toEndOf="@id/text_tilt"` to better support right-to-left layouts" - errorLine1=" android:layout_toRightOf="@id/text_tilt"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> + id="IconDensities" + message="Missing the following drawables in `drawable-xxhdpi`: ic_car_top.png, ic_taxi_top.png, southeast_radar_0.png, southeast_radar_1.png, southeast_radar_2.png... (1 more)"> <location - file="src/main/res/layout/dialog_camera_position.xml" - line="185" - column="13"/> + file="src/main/res/drawable-xxhdpi"/> </issue> </issues> |