Adds checkstyle to CI (#7442)

* adds checkstyle to CI

* fixed gradlew path

* resolved testapp checkstyle violations

* added back mapboxMap variable for test

* checkstyle annotations

* checkstyle SDK round 1

* maps package checkstyle

* rest of SDK checkstyle

* checkstyle gesture library

* checkstyle test

* finished rest of test checkstyle

* resolved all checkstyle errors

* fixed class name

* removed old test file

* fixed camera postion test

* fixed native crash

1 files changed, 137 insertions, 133 deletions

diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/constants/MapboxConstants.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/constants/MapboxConstants.java
index 9c5e8194dd..fb3240fd7b 100644
--- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/constants/MapboxConstants.java
+++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/constants/MapboxConstants.java
@@ -1,6 +1,7 @@
 package com.mapbox.mapboxsdk.constants;
 
 import android.content.Context;
+
 import java.util.Locale;
 
 /**
@@ -8,137 +9,140 @@ import java.util.Locale;
  */
 public class MapboxConstants {
 
-    /**
-     * Default Locale for data processing (ex: String.toLowerCase(MAPBOX_LOCALE, "foo"))
-     */
-    public static final Locale MAPBOX_LOCALE = Locale.US;
-
-    /**
-     * Key used to store access token in AndroidManifest.xml
-     * @deprecated As of release 4.1.0, replaced by {@link com.mapbox.mapboxsdk.MapboxAccountManager#start(Context, String)}
-     */
-    @Deprecated
-    public static final String KEY_META_DATA_MANIFEST = "com.mapbox.AccessToken";
-
-    /**
-     * Key used to store staging data server url in AndroidManifest.xml
-     */
-    public static final String KEY_META_DATA_STAGING_SERVER = "com.mapbox.TestEventsServer";
-
-    /**
-     * Key used to store staging data server access token in AndroidManifest.xml
-     */
-    public static final String KEY_META_DATA_STAGING_ACCESS_TOKEN = "com.mapbox.TestEventsAccessToken";
-
-    /**
-     * Key used to switch storage to external in AndroidManifest.xml
-     */
-    public final static String KEY_META_DATA_SET_STORAGE_EXTERNAL = "com.mapbox.SetStorageExternal";
-
-    /**
-     * Default value for KEY_META_DATA_SET_STORAGE_EXTERNAL (default is internal storage)
-     */
-    public final static boolean DEFAULT_SET_STORAGE_EXTERNAL = false;
-
-    /**
-     * Unmeasured state
-     */
-    public final static float UNMEASURED = -1f;
-
-    /**
-     * Default animation time
-     */
-    public static final int ANIMATION_DURATION = 300;
-
-    /**
-     * Default short animation time
-     */
-    public static final int ANIMATION_DURATION_SHORT = 150;
-
-    /**
-     * Animation time of a fling gesture
-     */
-    public static final long ANIMATION_DURATION_FLING = 350;
-
-    /**
-     * The currently supported minimum zoom level.
-     */
-    public static final float MINIMUM_ZOOM = 0.0f;
-
-    /**
-     * The currently supported maximum zoom level.
-     */
-    public static final float MAXIMUM_ZOOM = 20.0f;
-
-    /**
-     * The currently supported maximum tilt value.
-     */
-    public static final double MAXIMUM_TILT = 60;
-
-    /**
-     * The currently supported minimum tilt value.
-     */
-    public static final double MINIMUM_TILT = 0;
-
-    /**
-     * The currently supported maximum direction
-     */
-    public static final double MAXIMUM_DIRECTION = 360;
-
-    /**
-     * The currently supported minimum direction
-     */
-    public static final double MINIMUM_DIRECTION = 0;
-
-    /**
-     * Fragment Argument Key for MapboxMapOptions
-     */
-    public static final String FRAG_ARG_MAPBOXMAPOPTIONS = "MapboxMapOptions";
-
-    // Save instance state keys
-    public static final String STATE_HAS_SAVED_STATE = "savedState";
-    public static final String STATE_CAMERA_POSITION = "cameraPosition";
-    public static final String STATE_ZOOM_ENABLED = "zoomEnabled";
-    public static final String STATE_ZOOM_ENABLED_CHANGE = "zoomEnabledChange";
-    public static final String STATE_SCROLL_ENABLED = "scrollEnabled";
-    public static final String STATE_SCROLL_ENABLED_CHANGE = "scrollEnabledChange";
-    public static final String STATE_ROTATE_ENABLED = "rotateEnabled";
-    public static final String STATE_ROTATE_ENABLED_CHANGE = "rotateEnabledChange";
-    public static final String STATE_TILT_ENABLED = "tiltEnabled";
-    public static final String STATE_TILT_ENABLED_CHANGE = "tiltEnabledChange";
-    public static final String STATE_ZOOM_CONTROLS_ENABLED = "zoomControlsEnabled";
-    public static final String STATE_DEBUG_ACTIVE = "debugActive";
-    public static final String STATE_STYLE_URL = "styleUrl";
-    public static final String STATE_MY_LOCATION_ENABLED = "myLocationEnabled";
-    public static final String STATE_MY_LOCATION_TRACKING_MODE = "myLocationTracking";
-    public static final String STATE_MY_BEARING_TRACKING_MODE = "myBearingTracking";
-    public static final String STATE_MY_LOCATION_TRACKING_DISMISS = "myLocationTrackingDismiss";
-    public static final String STATE_MY_BEARING_TRACKING_DISMISS = "myBearingTrackingDismiss";
-    public static final String STATE_COMPASS_ENABLED = "compassEnabled";
-    public static final String STATE_COMPASS_GRAVITY = "compassGravity";
-    public static final String STATE_COMPASS_MARGIN_LEFT = "compassMarginLeft";
-    public static final String STATE_COMPASS_MARGIN_TOP = "compassMarginTop";
-    public static final String STATE_COMPASS_MARGIN_RIGHT = "compassMarginRight";
-    public static final String STATE_COMPASS_MARGIN_BOTTOM = "compassMarginBottom";
-    public static final String STATE_COMPASS_FADE_WHEN_FACING_NORTH = "compassFade";
-    public static final String STATE_LOGO_GRAVITY = "logoGravity";
-    public static final String STATE_LOGO_MARGIN_LEFT = "logoMarginLeft";
-    public static final String STATE_LOGO_MARGIN_TOP = "logoMarginTop";
-    public static final String STATE_LOGO_MARGIN_RIGHT = "logoMarginRight";
-    public static final String STATE_LOGO_MARGIN_BOTTOM = "logoMarginBottom";
-    public static final String STATE_LOGO_ENABLED = "logoEnabled";
-    public static final String STATE_ATTRIBUTION_GRAVITY = "attrGravity";
-    public static final String STATE_ATTRIBUTION_MARGIN_LEFT = "attrMarginLeft";
-    public static final String STATE_ATTRIBUTION_MARGIN_TOP = "attrMarginTop";
-    public static final String STATE_ATTRIBUTION_MARGIN_RIGHT = "attrMarginRight";
-    public static final String STATE_ATTRIBUTION_MARGIN_BOTTOM = "atrrMarginBottom";
-    public static final String STATE_ATTRIBUTION_ENABLED = "atrrEnabled";
-
-    public static final String TAG = "MapboxMap";
-
-    public static final String MAPBOX_SHARED_PREFERENCES_FILE = "MapboxSharedPreferences";
-    public static final String MAPBOX_SHARED_PREFERENCE_KEY_VENDORID = "mapboxVendorId";
-    public static final String MAPBOX_SHARED_PREFERENCE_KEY_TELEMETRY_ENABLED = "mapboxTelemetryEnabled";
-    public static final String MAPBOX_SHARED_PREFERENCE_KEY_TELEMETRY_STAGING_URL = "mapboxTelemetryStagingUrl";
-    public static final String MAPBOX_SHARED_PREFERENCE_KEY_TELEMETRY_STAGING_ACCESS_TOKEN = "mapboxTelemetryStagingAccessToken";
+  /**
+   * Default Locale for data processing (ex: String.toLowerCase(MAPBOX_LOCALE, "foo"))
+   */
+  public static final Locale MAPBOX_LOCALE = Locale.US;
+
+  /**
+   * Key used to store access token in AndroidManifest.xml
+   *
+   * @deprecated As of release 4.1.0, replaced by
+   * {@link com.mapbox.mapboxsdk.MapboxAccountManager#start(Context, String)}
+   */
+  @Deprecated
+  public static final String KEY_META_DATA_MANIFEST = "com.mapbox.AccessToken";
+
+  /**
+   * Key used to store staging data server url in AndroidManifest.xml
+   */
+  public static final String KEY_META_DATA_STAGING_SERVER = "com.mapbox.TestEventsServer";
+
+  /**
+   * Key used to store staging data server access token in AndroidManifest.xml
+   */
+  public static final String KEY_META_DATA_STAGING_ACCESS_TOKEN = "com.mapbox.TestEventsAccessToken";
+
+  /**
+   * Key used to switch storage to external in AndroidManifest.xml
+   */
+  public static final String KEY_META_DATA_SET_STORAGE_EXTERNAL = "com.mapbox.SetStorageExternal";
+
+  /**
+   * Default value for KEY_META_DATA_SET_STORAGE_EXTERNAL (default is internal storage)
+   */
+  public static final boolean DEFAULT_SET_STORAGE_EXTERNAL = false;
+
+  /**
+   * Unmeasured state
+   */
+  public static final float UNMEASURED = -1f;
+
+  /**
+   * Default animation time
+   */
+  public static final int ANIMATION_DURATION = 300;
+
+  /**
+   * Default short animation time
+   */
+  public static final int ANIMATION_DURATION_SHORT = 150;
+
+  /**
+   * Animation time of a fling gesture
+   */
+  public static final long ANIMATION_DURATION_FLING = 350;
+
+  /**
+   * The currently supported minimum zoom level.
+   */
+  public static final float MINIMUM_ZOOM = 0.0f;
+
+  /**
+   * The currently supported maximum zoom level.
+   */
+  public static final float MAXIMUM_ZOOM = 20.0f;
+
+  /**
+   * The currently supported maximum tilt value.
+   */
+  public static final double MAXIMUM_TILT = 60;
+
+  /**
+   * The currently supported minimum tilt value.
+   */
+  public static final double MINIMUM_TILT = 0;
+
+  /**
+   * The currently supported maximum direction
+   */
+  public static final double MAXIMUM_DIRECTION = 360;
+
+  /**
+   * The currently supported minimum direction
+   */
+  public static final double MINIMUM_DIRECTION = 0;
+
+  /**
+   * Fragment Argument Key for MapboxMapOptions
+   */
+  public static final String FRAG_ARG_MAPBOXMAPOPTIONS = "MapboxMapOptions";
+
+  // Save instance state keys
+  public static final String STATE_HAS_SAVED_STATE = "savedState";
+  public static final String STATE_CAMERA_POSITION = "cameraPosition";
+  public static final String STATE_ZOOM_ENABLED = "zoomEnabled";
+  public static final String STATE_ZOOM_ENABLED_CHANGE = "zoomEnabledChange";
+  public static final String STATE_SCROLL_ENABLED = "scrollEnabled";
+  public static final String STATE_SCROLL_ENABLED_CHANGE = "scrollEnabledChange";
+  public static final String STATE_ROTATE_ENABLED = "rotateEnabled";
+  public static final String STATE_ROTATE_ENABLED_CHANGE = "rotateEnabledChange";
+  public static final String STATE_TILT_ENABLED = "tiltEnabled";
+  public static final String STATE_TILT_ENABLED_CHANGE = "tiltEnabledChange";
+  public static final String STATE_ZOOM_CONTROLS_ENABLED = "zoomControlsEnabled";
+  public static final String STATE_DEBUG_ACTIVE = "debugActive";
+  public static final String STATE_STYLE_URL = "styleUrl";
+  public static final String STATE_MY_LOCATION_ENABLED = "myLocationEnabled";
+  public static final String STATE_MY_LOCATION_TRACKING_MODE = "myLocationTracking";
+  public static final String STATE_MY_BEARING_TRACKING_MODE = "myBearingTracking";
+  public static final String STATE_MY_LOCATION_TRACKING_DISMISS = "myLocationTrackingDismiss";
+  public static final String STATE_MY_BEARING_TRACKING_DISMISS = "myBearingTrackingDismiss";
+  public static final String STATE_COMPASS_ENABLED = "compassEnabled";
+  public static final String STATE_COMPASS_GRAVITY = "compassGravity";
+  public static final String STATE_COMPASS_MARGIN_LEFT = "compassMarginLeft";
+  public static final String STATE_COMPASS_MARGIN_TOP = "compassMarginTop";
+  public static final String STATE_COMPASS_MARGIN_RIGHT = "compassMarginRight";
+  public static final String STATE_COMPASS_MARGIN_BOTTOM = "compassMarginBottom";
+  public static final String STATE_COMPASS_FADE_WHEN_FACING_NORTH = "compassFade";
+  public static final String STATE_LOGO_GRAVITY = "logoGravity";
+  public static final String STATE_LOGO_MARGIN_LEFT = "logoMarginLeft";
+  public static final String STATE_LOGO_MARGIN_TOP = "logoMarginTop";
+  public static final String STATE_LOGO_MARGIN_RIGHT = "logoMarginRight";
+  public static final String STATE_LOGO_MARGIN_BOTTOM = "logoMarginBottom";
+  public static final String STATE_LOGO_ENABLED = "logoEnabled";
+  public static final String STATE_ATTRIBUTION_GRAVITY = "attrGravity";
+  public static final String STATE_ATTRIBUTION_MARGIN_LEFT = "attrMarginLeft";
+  public static final String STATE_ATTRIBUTION_MARGIN_TOP = "attrMarginTop";
+  public static final String STATE_ATTRIBUTION_MARGIN_RIGHT = "attrMarginRight";
+  public static final String STATE_ATTRIBUTION_MARGIN_BOTTOM = "atrrMarginBottom";
+  public static final String STATE_ATTRIBUTION_ENABLED = "atrrEnabled";
+
+  public static final String TAG = "MapboxMap";
+
+  public static final String MAPBOX_SHARED_PREFERENCES_FILE = "MapboxSharedPreferences";
+  public static final String MAPBOX_SHARED_PREFERENCE_KEY_VENDORID = "mapboxVendorId";
+  public static final String MAPBOX_SHARED_PREFERENCE_KEY_TELEMETRY_ENABLED = "mapboxTelemetryEnabled";
+  public static final String MAPBOX_SHARED_PREFERENCE_KEY_TELEMETRY_STAGING_URL = "mapboxTelemetryStagingUrl";
+  public static final String MAPBOX_SHARED_PREFERENCE_KEY_TELEMETRY_STAGING_ACCESS_TOKEN =
+    "mapboxTelemetryStagingAccessToken";
 }