[core] Eliminate Response::stale and inline Response::isExpired()

Response::isExpired() had subtle and potentially confusing behavior around Seconds::zero(). It's best to inline it and comment why.

1 files changed, 0 insertions, 5 deletions

diff --git a/include/mbgl/storage/response.hpp b/include/mbgl/storage/response.hpp
index 532a91da97..a7a200c53a 100644
--- a/include/mbgl/storage/response.hpp
+++ b/include/mbgl/storage/response.hpp
@@ -14,16 +14,11 @@ public:
     Response(const Response&);
     Response& operator=(const Response&);
 
-    bool isExpired() const;
-
 public:
     class Error;
     // When this object is empty, the response was successful.
     std::unique_ptr<const Error> error;
 
-    // Stale responses are fetched from cache and are expired.
-    bool stale = false;
-
     // This is set to true for 304 Not Modified responses.
     bool notModified = false;