From c33ed50c98c57ce2f2cf3b971bcf72c4208bf120 Mon Sep 17 00:00:00 2001 From: John Firebaugh Date: Fri, 15 Jan 2016 12:40:53 -0800 Subject: [core] Eliminate Response::stale and inline Response::isExpired() Response::isExpired() had subtle and potentially confusing behavior around Seconds::zero(). It's best to inline it and comment why. --- include/mbgl/storage/response.hpp | 5 ----- 1 file changed, 5 deletions(-) (limited to 'include/mbgl/storage/response.hpp') diff --git a/include/mbgl/storage/response.hpp b/include/mbgl/storage/response.hpp index 532a91da97..a7a200c53a 100644 --- a/include/mbgl/storage/response.hpp +++ b/include/mbgl/storage/response.hpp @@ -14,16 +14,11 @@ public: Response(const Response&); Response& operator=(const Response&); - bool isExpired() const; - public: class Error; // When this object is empty, the response was successful. std::unique_ptr error; - // Stale responses are fetched from cache and are expired. - bool stale = false; - // This is set to true for 304 Not Modified responses. bool notModified = false; -- cgit v1.2.1