[core] Fix GCC8's new -Wcatch-value warnings

Polymorphic types shouldn't be caught by value, as the warning message says. Catch them by constant reference instead.

2 files changed, 6 insertions, 6 deletions

diff --git a/bin/offline.cpp b/bin/offline.cpp
index 65396a88fb..8b42ab7b72 100644
--- a/bin/offline.cpp
+++ b/bin/offline.cpp
@@ -33,14 +33,14 @@ int main(int argc, char *argv[]) {
 
     try {
         argumentParser.ParseCLI(argc, argv);
-    } catch (args::Help) {
+    } catch (const args::Help&) {
         std::cout << argumentParser;
         exit(0);
-    } catch (args::ParseError e) {
+    } catch (const args::ParseError& e) {
         std::cerr << e.what() << std::endl;
         std::cerr << argumentParser;
         exit(1);
-    } catch (args::ValidationError e) {
+    } catch (const args::ValidationError& e) {
         std::cerr << e.what() << std::endl;
         std::cerr << argumentParser;
         exit(2);
diff --git a/bin/render.cpp b/bin/render.cpp
index 6ceb32eb00..1e7b210a4c 100644
--- a/bin/render.cpp
+++ b/bin/render.cpp
@@ -39,14 +39,14 @@ int main(int argc, char *argv[]) {
 
     try {
         argumentParser.ParseCLI(argc, argv);
-    } catch (args::Help) {
+    } catch (const args::Help&) {
         std::cout << argumentParser;
         exit(0);
-    } catch (args::ParseError e) {
+    } catch (const args::ParseError& e) {
         std::cerr << e.what() << std::endl;
         std::cerr << argumentParser;
         exit(1);
-    } catch (args::ValidationError e) {
+    } catch (const args::ValidationError& e) {
         std::cerr << e.what() << std::endl;
         std::cerr << argumentParser;
         exit(2);