diff options
author | Tobrun <tobrun.van.nuland@gmail.com> | 2018-01-18 13:37:20 +0100 |
---|---|---|
committer | Tobrun <tobrun.van.nuland@gmail.com> | 2018-01-18 14:06:21 +0100 |
commit | 42c9c8bf1684a5b40760ac36efeea31e31b22f35 (patch) | |
tree | f03e5821d8dc2625119bddd21e256fb76a2c0a49 | |
parent | b3d3ab0e31d251cf39dfa78dfbc0661b8819a8ab (diff) | |
download | qtlocation-mapboxgl-upstream/invalid-zoom-level-telem.tar.gz |
[android] - validate zoom level before creating mapbox telem eventupstream/invalid-zoom-level-telem
-rw-r--r-- | platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxEventWrapper.java | 17 |
1 files changed, 13 insertions, 4 deletions
diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxEventWrapper.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxEventWrapper.java index 97734de493..6730278d79 100644 --- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxEventWrapper.java +++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxEventWrapper.java @@ -4,6 +4,7 @@ import android.location.Location; import android.support.annotation.NonNull; import android.support.annotation.Nullable; +import com.mapbox.mapboxsdk.constants.MapboxConstants; import com.mapbox.services.android.telemetry.MapboxEvent; import java.util.Hashtable; @@ -21,24 +22,32 @@ class MapboxEventWrapper { static Hashtable<String, Object> buildMapClickEvent( @NonNull Location location, @NonNull String gestureId, Transform transform) { try { - return MapboxEvent.buildMapClickEvent(location, gestureId, transform.getZoom()); + double mapZoom = transform.getZoom(); + if (mapZoom >= MapboxConstants.MINIMUM_ZOOM && mapZoom <= MapboxConstants.MAXIMUM_ZOOM) { + // validate zoom #8057 + return MapboxEvent.buildMapClickEvent(location, gestureId, transform.getZoom()); + } } catch (NullPointerException exception) { // Map/Transform is not ready yet #8650 // returning null is valid, event is ignored. - return null; } + return null; } @Nullable static Hashtable<String, Object> buildMapDragEndEvent( @NonNull Location location, Transform transform) { try { - return MapboxEvent.buildMapDragEndEvent(location, transform.getZoom()); + double mapZoom = transform.getZoom(); + if (mapZoom >= MapboxConstants.MINIMUM_ZOOM && mapZoom <= MapboxConstants.MAXIMUM_ZOOM) { + // validate zoom #8057 + return MapboxEvent.buildMapDragEndEvent(location, transform.getZoom()); + } } catch (NullPointerException exception) { // Map/Transform is not ready yet #8650 // returning null is valid, event is ignored. - return null; } + return null; } @Nullable |