diff options
| author | Mike Morris <mikemorris@users.noreply.github.com> | 2016-02-03 15:44:47 -0500 |
|---|---|---|
| committer | Mike Morris <mikemorris@users.noreply.github.com> | 2016-02-03 15:44:47 -0500 |
| commit | 5dd498f9ba91da91edba1f4bd4a9cd5005490206 (patch) | |
| tree | cd6f8afd5a4321d4a5ed56ea13715f428b8840df | |
| parent | 235210c64864e1bbccceb2a551a521ce72cbdadd (diff) | |
| download | qtlocation-mapboxgl-node-v3.0.2-pre.1.tar.gz | |
[node] patch a memory leak in NodeMap::requestnode-v3.0.2-pre.1
Creating a v8::Function with
Nan::GetFunction(Nan::New<v8::FunctionTemplate>) can leak, use
Nan::New<v8::Function> instead.
https://code.google.com/p/chromium/issues/detail?id=272579
| -rw-r--r-- | package.json | 2 | ||||
| -rw-r--r-- | platform/node/src/node_map.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/package.json b/package.json index aa88c983d5..d99ed46f09 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "mapbox-gl-native", - "version": "3.0.1", + "version": "3.0.2-pre.1", "description": "Renders map tiles with Mapbox GL", "keywords": [ "mapbox", diff --git a/platform/node/src/node_map.cpp b/platform/node/src/node_map.cpp index f5ebae110d..b8927ea334 100644 --- a/platform/node/src/node_map.cpp +++ b/platform/node/src/node_map.cpp @@ -462,7 +462,7 @@ std::unique_ptr<mbgl::FileRequest> NodeMap::request(const mbgl::Resource& resour Nan::HandleScope scope; auto requestHandle = NodeRequest::Create(res, cb2)->ToObject(); - auto callbackHandle = Nan::GetFunction(Nan::New<v8::FunctionTemplate>(NodeRequest::Respond, requestHandle)).ToLocalChecked(); + auto callbackHandle = Nan::New<v8::Function>(NodeRequest::Respond, requestHandle); v8::Local<v8::Value> argv[] = { requestHandle, callbackHandle }; Nan::MakeCallback(handle()->GetInternalField(1)->ToObject(), "request", 2, argv); |