summaryrefslogtreecommitdiff
path: root/src/plugins/debugger
Commit message (Collapse)AuthorAgeFilesLines
* Debugger: Fix timeout handlingChristian Stenger2019-11-011-1/+1
| | | | | | Task-number: QTCREATORBUG-21664 Change-Id: Ie6dec329443e9fa8e31e28f0fdd6d46a279804bb Reviewed-by: hjk <hjk@qt.io>
* Debugger: Fix a bugprone-branch-cloneNikolai Kosjar2019-11-011-3/+0
| | | | | | Change-Id: I7b9a3e416fa547de344dd5c4e111939200a7b824 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Debugger: Fix conditional operator with identical true and false expressionshjk2019-11-011-9/+8
| | | | | Change-Id: I1f85eed5355cd01590bc8cc0082f154e215a9ac3 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* Debugger: prefer cdb for msvc targetsDavid Schulz2019-10-301-0/+5
| | | | | Change-Id: I4d305ae6f3b54d7f724f2cfbde6062663e3c0ad1 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: adjust resetting the symbol server after cdb updateDavid Schulz2019-10-301-8/+11
| | | | | | | | The cdb symbol server can currently only be cleared by setting the symbol path via .sympath command and an empty string. Change-Id: I013b106856d87dbc2de0fdcaa876fd6d9378fb63 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Merge remote-tracking branch 'origin/4.10' into 4.11Eike Ziller2019-10-282-16/+28
|\ | | | | | | | | | | | | | | Conflicts: src/libs/utils/fancymainwindow.cpp src/plugins/projectexplorer/msvctoolchain.cpp Change-Id: I7aaeeb4f96c95fefd4944c083c1ddf9a19cd81d6
| * Debugger: Avoid recreation of breakpoint markersDavid Schulz2019-10-181-5/+13
| | | | | | | | | | Change-Id: Ie3b160a7b7137257b2028d03878700675142102f Reviewed-by: hjk <hjk@qt.io>
| * Debugger: further untangle of breakpoint item and markerDavid Schulz2019-10-172-7/+15
| | | | | | | | | | Change-Id: I9331912c1b53a0110479f46ef1e576676441ab75 Reviewed-by: hjk <hjk@qt.io>
| * Debugger: Fix crash after breakpoint marker drag&dropDavid Schulz2019-10-171-7/+3
| | | | | | | | | | | | | | | | | | The updateMarker function deletes the marker of the global breakpoint so don't call that function from the marker. Fixes: QTCREATORBUG-23107 Change-Id: I377608f1a08b61451be1fc0be5bc15252252a4a7 Reviewed-by: hjk <hjk@qt.io>
* | Fix some memory leaksChristian Kandeler2019-10-233-0/+15
| | | | | | | | | | | | | | Found by Address Sanitizer. Change-Id: I989da71e24d737e36a88b83a1f382ce2d67e3307 Reviewed-by: hjk <hjk@qt.io>
* | Debugger: always hex encode the value of assignments in cdbextDavid Schulz2019-10-221-31/+2
| | | | | | | | | | | | | | | | Fixes assigning negative values to locals Change-Id: Ief6e7f47e8e6f0a5d38458396164dfcd24e408a5 Fixes: QTCREATORBUG-17269 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Debugger: Prohibit multi selection on debugger presetsChristian Stenger2019-10-181-0/+1
| | | | | | | | | | | | | | | | To avoid confusion regarding context menu items limit the selection mode to single selection. Change-Id: I220d97fee65180a497f21e5921f832076235acb5 Reviewed-by: hjk <hjk@qt.io>
* | Debugger: Fix display of stackChristian Stenger2019-10-183-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | When switching between interrupted and continue while debugging the stack was not updated when the engine states it is running again, but immediately did so when clicking into the stack view. Fix by explicitly updating the stack when the engine reports it is running. Change-Id: Ie8cb445e87fe6e45f9ae86b8ee2eec386be78a5c Reviewed-by: hjk <hjk@qt.io>
* | Merge "Merge remote-tracking branch 'origin/4.10' into 4.11" into 4.11The Qt Project2019-10-161-1/+3
|\ \
| * \ Merge remote-tracking branch 'origin/4.10' into 4.11Eike Ziller2019-10-161-1/+3
| |\ \ | | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: cmake/QtCreatorIDEBranding.cmake qbs/modules/qtc/qtc.qbs qtcreator_ide_branding.pri src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp src/plugins/projectexplorer/deploymentdata.cpp src/plugins/projectexplorer/msvctoolchain.cpp Change-Id: I64c304fc71435629a6a0060a9df71e8952699508
| | * Debugger: Prevent crash on shutdownChristian Stenger2019-10-101-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It may happen that the global log window gets destroyed before the log windows of a running engine when QC is closed after an unsuccessful attempt to debug. Avoid accessing it when trying to write output that has not been processed so far. Change-Id: I41296cc37bab1e4f1272b05dda1979d813981aa7 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: David Schulz <david.schulz@qt.io>
* | | Debugger: Introduce a checkboxhjk2019-10-161-0/+8
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | ... to propagate breakpoint changes from a running debugger back to the original preset breakpoint. This is currently unused as some changes are already propagated, and some not, so a bit more diligence is needed. For now it is there to have the new label string in safely before string freeze. Change-Id: I8ee4d07bab5a4f66e59bf992ebfd81c56fdb3ecf Reviewed-by: David Schulz <david.schulz@qt.io>
* | Port setMargins to setContentsMarginsLaurent Montel2019-10-161-1/+1
| | | | | | | | | | Change-Id: Ie6b3f3e4dddbbf4bcc7ea7561ec348ff2c666907 Reviewed-by: hjk <hjk@qt.io>
* | Merge remote-tracking branch 'origin/4.10' into 4.11Eike Ziller2019-10-082-4/+10
|\ \ | |/ | | | | Change-Id: I9b53d00dbc79d52e52f6e18761e6a6c6faec6c84
| * Debugger: Fix missing watch highlight when the value changesAntonio Di Monaco2019-10-081-2/+2
| | | | | | | | | | | | | | | | This patch fixes a regression introduced by e95fd876aa62614fa991ab42c343adbb81acec73 Change-Id: I8cb277858ef6c63cd26c03417f9dfeb99d96cb45 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
| * Debugger: Fix out of memory crash when receiving regular outputDavid Schulz2019-10-081-2/+8
| | | | | | | | | | | | Change-Id: Icda28ec56c191e62812a4e5219a1df902c5e60a1 Fixes: QTCREATORBUG-22733 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Debugger: Fix MSVC warningOrgad Shaneh2019-10-071-1/+1
| | | | | | | | | | | | | | Using QObject::connect without capturing 'this'. Change-Id: I64e61e897760002888d7a11771bd2dc36e640c72 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Debugger: (Sub-)Aspectify DebuggerRunConfigurationAspecthjk2019-10-022-149/+151
| | | | | | | | | | Change-Id: If7fcc52a88dec02061c4e0cce4aa48d1b923ceb2 Reviewed-by: David Schulz <david.schulz@qt.io>
* | Merge remote-tracking branch 'origin/4.10' into 4.11Eike Ziller2019-10-021-9/+14
|\ \ | |/ | | | | | | | | | | Conflicts: src/plugins/projectexplorer/projectnodes.h Change-Id: I10a749cca38c2d0929cf4d2b74ab089e14b6157b
| * Debugger: Do not crash when displaying uninitialized QImageshjk2019-10-011-9/+14
| | | | | | | | | | | | | | Fixes: QTCREATORBUG-23031 Change-Id: I074cdaf509edac6e5659d2e976ed7188e8944d81 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Debugger: Remove QML port settings in run configshjk2019-09-302-55/+0
| | | | | | | | | | | | | | Obsolete since the invention of PortGatherers. Change-Id: I34c80b2408213c2d6bd0d893763be4dffc2db7ea Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | Debugger: Add a per-runconfig way to add debugger startup commandhjk2019-09-303-4/+26
| | | | | | | | | | | | Task-number: QTCREATORBUG-22979 Change-Id: I225b6cd1ee1dd3195bda3de4de72880d76e8cd37 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Merge remote-tracking branch 'origin/4.10' into 4.11Eike Ziller2019-09-301-2/+2
|\ \ | |/ | | | | Change-Id: Ic05bd53ea060d42c2013884972c05de08ed63f10
| * Debugger: Fix automatic raising of ExpressionsChristian Stenger2019-09-301-2/+2
| | | | | | | | | | | | | | | | When adding a new expression automatically raise the Expressions widget if it is not shown already. Change-Id: If89e4e4fbf8cbe57e0f08478cd2d3b9f4797f5ad Reviewed-by: hjk <hjk@qt.io>
* | Merge remote-tracking branch 'origin/4.11'Eike Ziller2019-09-261-6/+12
|\ \ | | | | | | | | | Change-Id: Ie9859185470ae46e49a25e732336c4a95eaad4ed
| * \ Merge remote-tracking branch 'origin/4.10' into 4.11Eike Ziller2019-09-261-6/+12
| |\ \ | | |/ | | | | | | Change-Id: Iad66b08f8d6d7f14319674ae6bb26cdba43b3bfa
| | * Debugger: Try harder to restore dock widget sizeshjk2019-09-261-6/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is bit of a hack: The dock widget sizes were actually restored but when previously non-existing docks were affected, a re-layout was triggered, resulting in different sizes. This can be avoided by instantiating all dock first. Fixes: QTCREATORBUG-22415 Change-Id: I4c0b27f5bab5864e93e303db758d8b909a51a425 Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
| | * Debugger: Mark docks as default-visible when resetting a perspectivehjk2019-09-251-0/+1
| | | | | | | | | | | | | | | Change-Id: I562a71de04335e8b4d34f90e7df3127fbb01ac5b Reviewed-by: Christian Stenger <christian.stenger@qt.io>
| | * Debugger: Do not forget perspective layouts on unused perspectiveshjk2019-09-232-126/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Amends 5273ef2a8aa3c8d268b107edc770b53e1aed7803 Use cases mentioned there should still work. Fixes: QTCREATORBUG-22938 Fixes: QTCREATORBUG-22286 Change-Id: Ie7bb6b7ea6d05a94cbeeb5b8021dc638548778d9 Reviewed-by: Christian Stenger <christian.stenger@qt.io> (cherry picked from commit e9c0ba9997294bdf440b6e60d0a1eaf94b74baef) Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | | Debugger: Move convenience function to only userhjk2019-09-253-15/+11
| | | | | | | | | | | | | | | Change-Id: I50952521bdd45faa8a31da674e7ea5f0796d75d9 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | | Debugger: Move showModule{Sections,Symbols} to DebuggerEnginehjk2019-09-258-84/+81
|/ / | | | | | | | | | | | | A bit closer to where the functions are used. No real change. Change-Id: Icbad68bd31d85caa59980316537ee532faf2d7ef Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Debugger: Shuffle plugin setup code aroundhjk2019-09-235-297/+248
| | | | | | | | | | | | | | To get closer to the standard setup. Change-Id: I969abb44393532f5dba95e643bd8ba6356f44d16 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Debugger: Inline rarely used convienience functionhjk2019-09-204-8/+4
| | | | | | | | | | | | Change-Id: Iad5db32af9adb90f5d191e4fdcd2be751bd2b412 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* | Debugger: Do not forget perspective layouts on unused perspectiveshjk2019-09-202-126/+114
| | | | | | | | | | | | | | | | | | | | | | Amends 5273ef2a8aa3c8d268b107edc770b53e1aed7803 Use cases mentioned there should still work. Fixes: QTCREATORBUG-22938 Fixes: QTCREATORBUG-22286 Change-Id: Ie7bb6b7ea6d05a94cbeeb5b8021dc638548778d9 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Debugger: Code cosmeticshjk2019-09-182-12/+5
| | | | | | | | | | Change-Id: I8759b5a16385b6abde9680ad6c46be5b0e2abdfc Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Debugger: Reduce scope of explicit use of perspective windowshjk2019-09-181-47/+43
| | | | | | | | | | | | | | Maybe these can be created lazily later. Change-Id: I1ebcbd99b2149e96197bbff7f7c877f609e126ad Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Android multi arch supportBogDan Vatra2019-09-162-0/+7
| | | | | | | | | | | | | | [ChangeLog][Android] Android multi arch support for qmake Change-Id: Ib8b1874604a3392130c96fbc00b26713b3d788ae Reviewed-by: hjk <hjk@qt.io>
* | Merge remote-tracking branch 'origin/4.10'Eike Ziller2019-09-121-1/+1
|\ \ | |/ | | | | | | | | | | | | | | | | | | Conflicts: cmake/QtCreatorIDEBranding.cmake qbs/modules/qtc/qtc.qbs qtcreator_ide_branding.pri src/plugins/projectexplorer/gcctoolchain.cpp src/plugins/qmldesigner/components/stateseditor/stateseditormodel.cpp Change-Id: Iffdf48e782a734107ea170ebb3812e997cea0e7b
| * Fix MSVC warningsOrgad Shaneh2019-09-111-1/+1
| | | | | | | | | | | | | | | | | | | | * Missing `this` captures * Implicit size_t -> int conversion * Unused argument * Suppress warnings in clang headers Change-Id: I7083ce6ab22ee22ecc1258539e77c790acc78df1 Reviewed-by: hjk <hjk@qt.io>
* | Utils: Add a FilePath::isDir() convenience functionhjk2019-09-111-1/+1
| | | | | | | | | | Change-Id: I1df0ee1b136299ae6e4f2e5bd0bdc24bfeca33dd Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Remove unused QObject parent arguments on options pageshjk2019-09-112-6/+6
| | | | | | | | | | | | | | | | In the new plugin setup scheme they are data members of the plugin pimpl and never use the parent. Change-Id: I28fe150393e8159064dcfbd113ce0320af50fd58 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | ProjectExplorer: Use std::function for SimpleTargetRunner::start()hjk2019-09-043-52/+41
| | | | | | | | | | | | | | | | | | This spares us the typical r = runnable(); modify(r); setRunnable(r) roundtrip and the m_runnable storage that might or might not be the same as runControl->runnable. Similar for m_device. Change-Id: I8300260dd8dd7cd395e40bcd3d2ae45089085008 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | ClangTools: Support loading exported diagnosticsNikolai Kosjar2019-09-032-0/+13
| | | | | | | | | | | | | | | | | | | | Add a new toolbar button to load diagnostics exported with $ clang-tidy -export-fixes=/path/to/file $ clazy-standalone -export-fixes=/path/to/file (master version) Change-Id: I8316fe0706a18222e68220ef4fbfdc7ae8d09804 Reviewed-by: David Schulz <david.schulz@qt.io>
* | Remove usages of deprecated APIs of QLayoutSona Kurazyan2019-09-027-17/+18
| | | | | | | | | | | | | | | | | | | | Replaced: QLayout::setMargin() -> QLayout::setContentsMargins() QLayout::margin() -> QLayout::getContentsMargins() Task-number: QTBUG-76491 Change-Id: If28ef6910b3afe5d04e4746b74f9362a3e3b3c8e Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Debugger: Inline/Remove rarely used argument handlinghjk2019-09-022-19/+7
| | | | | | | | | | Change-Id: Ibe97f3e406a4fc01569aa8e1325531ce4764adca Reviewed-by: Christian Stenger <christian.stenger@qt.io>