summaryrefslogtreecommitdiff
path: root/src/plugins/debugger/breakhandler.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Debugger: Avoid recreation of breakpoint markersDavid Schulz2019-10-181-5/+13
| | | | | Change-Id: Ie3b160a7b7137257b2028d03878700675142102f Reviewed-by: hjk <hjk@qt.io>
* Debugger: further untangle of breakpoint item and markerDavid Schulz2019-10-171-6/+15
| | | | | Change-Id: I9331912c1b53a0110479f46ef1e576676441ab75 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Fix crash after breakpoint marker drag&dropDavid Schulz2019-10-171-7/+3
| | | | | | | | | The updateMarker function deletes the marker of the global breakpoint so don't call that function from the marker. Fixes: QTCREATORBUG-23107 Change-Id: I377608f1a08b61451be1fc0be5bc15252252a4a7 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Update breakpoint marker earlierChristian Stenger2019-08-121-1/+1
| | | | | | | | | | | | Since the distinction between global and engine breakpoints we may not update the breakpoint marker correctly which in turn appears as if the breakpoint had been failed to set. Fix this by updating the breakpoint marker already on insertion request. Change-Id: I7c4ed046c26667e6aa1efceb5071c12a6d1e6132 Reviewed-by: hjk <hjk@qt.io>
* Remove more deprecation warningshjk2019-07-051-2/+2
| | | | | Change-Id: Ie50e41737a4bf7bea41f550df7cc765267e8a144 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* More Utils::toSet/toListhjk2019-07-041-1/+1
| | | | | | | ... and unrelated cosmetic changes. Change-Id: I591b17fd5289831e701b683f8fb47816efd1fa67 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* connect() to ambiguous signals/slots: Replace static_cast with QOverloadAlessandro Portale2019-05-281-1/+1
| | | | | Change-Id: I473d7a2a16509cee944a2a21b022a3f6f02cfd8d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Utils: Rename FileName to FilePathhjk2019-05-281-6/+6
| | | | | | | | More in line with QFileInfo terminonlogy which appears to be best-of-breed within Qt. Change-Id: I1d051ff1c8363ebd4ee56376451df45216c4c9ab Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Debugger: Coordinate breakpoint rampdownhjk2019-04-111-3/+7
| | | | | | | | | | The update of the global came too early to properly check the condition whether it is still used. So fully remove usage first, then update, so the check operates on intended data. Fixes: QTCREATORBUG-22284 Change-Id: Iecdbdc371396132c88d0918f7cb253cf2627e0e3 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* TreeView: Fix mapping to source models in case ProxyModels are involvedhjk2019-04-021-3/+3
| | | | | | | Visible e.g. in context menu handling of the debugger's module view. Change-Id: I342ed262c9e3dcdf98590003a7930cb8ef4ca0d2 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Merge remote-tracking branch 'origin/4.8'Eike Ziller2019-01-071-0/+4
|\ | | | | | | | | | | | | Conflicts: src/plugins/coreplugin/dialogs/externaltoolconfig.ui Change-Id: Ie38e9028cee599578c59b22325d85c097335243e
| * Debugger: Update global breakpoint line and filehjk2018-12-191-0/+4
| | | | | | | | | | | | | | | | ... when a breakpoint in an active engine is moved due to code edits. Change-Id: Iac8102b7ac0149342ccb3fd6be6bf16172683036 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-191-4/+5
|\ \ | |/ | | | | | | | | | | Conflicts: src/plugins/winrt/winrtdevicefactory.cpp Change-Id: I33b8697e2ebf2bea051d7f1144449e0743ee16a5
| * Debugger: Silence soft assertChristian Stenger2018-11-131-4/+5
| | | | | | | | | | | | | | | | | | Enabling or disabling a multiple break points that have different states will trigger the soft assert for all break points having the destination state already. Change-Id: I61d859c0af548cb1dd9070a28c9aacee241e075b Reviewed-by: hjk <hjk@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-091-2/+3
|\ \ | |/ | | | | | | | | | | Conflicts: tests/unit/unittest/unittest.pro Change-Id: I4f0ab05f96ee60900a3a35fad4c7331238367593
| * Debugger: Silence breakpoint state transition warninghjk2018-11-071-2/+3
| | | | | | | | | | | | | | ... for "alien" breakpoint that legitimately jump from New to Inserted. Change-Id: Idb8b540a119f6dbd04d86b8ce3f15c2599d4b60c Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-061-16/+7
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | Conflicts: src/plugins/debugger/debuggermainwindow.cpp src/plugins/qbsprojectmanager/qbsbuildstep.cpp src/plugins/winrt/winrtdevicefactory.cpp tests/unit/unittest/gtest-creator-printing.cpp tests/unit/unittest/gtest-creator-printing.h tests/unit/unittest/unittest.pro Change-Id: Ie9b80b87a8a4fa81baf72a2daa7919b21371c15e
| * Debugger: Implement disabling/enabling subbreakpoints with LLDBhjk2018-11-061-2/+0
| | | | | | | | | | Change-Id: Iaad8716b98d632e5a933b7f5b26549c7cb885ea7 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
| * Debugger: use requested file and line for pending breakpointshjk2018-11-051-14/+7
| | | | | | | | | | | | | | | | | | | | | | Otherwise markers will not be shown. This fixes the visual aspect of the referenced tasks. Choosing a specific engine if more than one is running is still not possible. Task-number: QTCREATORBUG-21361 Task-number: QTCREATORBUG-21330 Change-Id: I5e31adf43ca8a57add83166b307434122498f1e6 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-10-241-6/+0
|\ \ | |/ | | | | | | | | | | | | Conflicts: doc/src/editors/creator-only/creator-code-pasting.qdoc src/plugins/android/androidbuildapkwidget.cpp Change-Id: Iea8b7135643d14ffe49d10b14bedb8fa5ac48063
| * Debugger: Remove unused BreakHandler::setBreakpointEnabled()hjk2018-10-221-6/+0
| | | | | | | | | | Change-Id: Ie7ef810e72b3d02663b425c687407cdd2b0cea52 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-10-221-11/+10
|\ \ | |/ | | | | | | | | | | | | Conflicts: src/plugins/debugger/debuggeritem.cpp tests/unit/unittest/unittest.pro Change-Id: Id2e4e9c2bc87b2556d7c2845aea3fe2fa11b630b
| * Debugger: Remove wrong state transitionChristian Stenger2018-10-221-1/+0
| | | | | | | | | | Change-Id: Ie199370e6dc9e8c3efe293be76cb89feacb8d4c5 Reviewed-by: hjk <hjk@qt.io>
| * Debugger: Re-enable breakpoint state handling with keyboardChristian Stenger2018-10-161-10/+10
| | | | | | | | | | | | | | | | | | This patch re-enables disabling or enabling breakpoints using the respective keyboard shortcut. Had been disabled since d6911fd10c0d. Change-Id: Iea3ce679bafcc78910be07984fd03b4a6e66eb8b Reviewed-by: hjk <hjk@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-10-161-8/+16
|\ \ | |/ | | | | Change-Id: I0ff6f659b7ccd4ff5a79e422a1d54488508fe05f
| * Debugger: Fix breakpoint disabling using context menuhjk2018-10-151-8/+16
| | | | | | | | | | Change-Id: I3fa5ef2dc123f5f7f8292147626453284c1afd76 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Debugger: Strip QLatin1* where possibleOrgad Shaneh2018-10-131-2/+2
|/ | | | | Change-Id: Idcab23875b5dc2ecf55e3303f417b995e2252720 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Rename snapshothandler.{cpp,h} to enginemanager.{cpp,h}hjk2018-09-281-2/+2
| | | | | | | That's what they are nowadays. Change-Id: I1bd6db18f2142ecf488eba51ca739675eac753c7 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Consolidate breakpoint searchhjk2018-09-041-24/+31
| | | | | | | | | | | | | We already have a concept of Context when action on editor events, use that directly when searching an (almost) matching breakpoint instead of translating it into breakpoint manager's interface language. This also centralizes the guesswork for non-exact matches in one place, making it easier to fix currently wrong matches later. Change-Id: I5579e7e01792d425cad4ccf1dbcbbd1bd56c84ec Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Fix insertion of backend generated breakpointshjk2018-08-291-0/+1
| | | | | Change-Id: Ifb46995a787c111620b5270b2b60e4e7f39eb552 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Identify a breakpoint's requested parameters with preset datahjk2018-08-291-33/+33
| | | | | | | | | | | | This removes the ability to have different enabled/disabled states for the same breakpoint in concurrently running engines, but make the behavior less surprising. At least currently people *do* expect breakpoint changes in a running engine to persist after the engine dies. Change-Id: I911594765b24f2ce58f6747ae5ecab3e608882b8 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Move session load/restore handlinghjk2018-08-291-4/+13
| | | | | | | | | ... to breakpoint and watchhandler. More modular this way. Change-Id: I4a45481fcc2bfde67b164bd7274fb7b2a12cb7ac Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Re-enable breakpoint enabling via gutter context menuhjk2018-08-241-2/+3
| | | | | | Task-number: QTCREATORBUG-20970 Change-Id: Ie8fc2af8e99e82018a9b4262fe6053cb714e7d60 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Debugger: Re-enable breakpoint property editing before debugger starthjk2018-08-211-11/+61
| | | | | | | | Amends 3b5ecac23. Task-number: QTCREATORBUG-20970 Change-Id: I8206b16bc17a4d3830b8e517c7e952efabcf4609 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Debugger: Make breakpoint property dialogs less dependent on enginehjk2018-08-211-22/+22
| | | | | | | ... so they can be reused for global/preset breakpoints later. Change-Id: I34493f3b702605054c1ea227f56ed286eb77fcca Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Debugger: Make most views per-engine instead of singletonshjk2018-08-171-1003/+1288
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a step towards properly supporting multiple debugger sessions side-by-side. The combined C++-and-QML engine has been removed, instead a combined setup creates now two individual engines, under a single DebuggerRunTool but mostly independent with no combined state machine. This requires a few more clicks in some cases, but makes it easier to direct e.g. interrupt requests to the interesting engine. Care has been taken to not change the UX of the single debugger session use case if possible. The fat debug button operates as-before in that case, i.e. switches to Interrupt if the single active runconfiguration runs in the debugger etc. Most views are made per-engine, running an engine creates a new Perspective, which is destroyed when the run control dies. The snapshot view remains global and becomes primary source of information on a "current engine" that receives all menu and otherwise global input. There is a new global "Breakpoint Preset" view containing all "static" breakpoint data. When an engine starts up it "claims" breakpoint it believes it can handle, but operates on a copy of the static data. The markers of the static version are suppressed as long as an engine controls a breakpoint (that inclusive all resolved locations), but are re-instatet once the engine quits. The old Breakpoint class that already contained this split per-instance was split into a new Breakpoint and a GlobalBreakpoint class, with a per-engine model for Breakpoints, and a singleton model containing GlobalBreakpoints. There is a new CppDebuggerEngine intermediate level serving as base for C++ (or, rather, "compiled") binary debugging, i.e. {Gdb,Lldb,Cdb}Engine, taking over bits of the current DebuggerEngine base that are not applicable to non-binary debuggers. Change-Id: I9994f4c188379b4aee0c4f379edd4759fbb0bd43 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Debugger: ModernizeAlessandro Portale2018-07-251-20/+20
| | | | | | | | | | | | | modernize-use-auto modernize-use-nullptr modernize-use-override modernize-use-using modernize-use-default-member-init modernize-use-equals-default Change-Id: I91a6874f0d7b94e9079ab4ef07c23c60c80be9c0 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Debugger: Code cosmeticshjk2018-05-311-11/+11
| | | | | | | Sprinkling in const and ranged for. Change-Id: I5d11d57f64140021397c23734c7373544ebebb6f Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Use FileName in TextMarkEike Ziller2018-05-031-4/+4
| | | | | Change-Id: I3666d95dc8ef3b7da099d6d30f5cb4678a349493 Reviewed-by: David Schulz <david.schulz@qt.io>
* Fix warnings about unused lambda capturesTobias Hunger2018-02-211-1/+1
| | | | | Change-Id: Ib9bcf180fd8ceffbf88836a62fc9532e6f7fc656 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Handle double click of sub break pointsChristian Stenger2018-02-011-0/+2
| | | | | | | | | Double clicking on a child break point (e.g. multi location break point) now jumps to the respective parent break point. Change-Id: I93497f8eec78408909dddd159002e171805814d7 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Debugger: Modernizehjk2018-02-011-2/+2
| | | | | | | Mostly nullptr instead of 0, but also a few bits of collateral damage. Change-Id: I921991272aca921dcdecf302dfff3716e79dfc24 Reviewed-by: David Schulz <david.schulz@qt.io>
* Debugger: Allow disabling individual breakpoint locationshjk2018-02-011-13/+52
| | | | | | | | | | ... for breakpoints that resolve to multiple locations, like templates. Toggling is done via the the breakpoint view context menu, for now only available with GDB and not persistent. Change-Id: I098ae13a5518e9f671c647680f8bd4413e7e5ccc Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Move HTML out of translated stringsRobert Loehning2018-01-241-5/+5
| | | | | | | | Change-Id: I4664427086619f33e9a882eb3f0a5f2f52e1b42a Reviewed-by: Jochen Becher <jochen_becher@gmx.de> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Drop unused variables and lambda capturesUlf Hermann2017-09-081-1/+1
| | | | | | | | | Also, add context to connect() expressions where we are or were capturing "this". Change-Id: I6e006ba6f83d532478018550d148ee93eca59605 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Editor: Simplify text marksDavid Schulz2017-06-221-5/+4
| | | | | | | | | Moving defaultToolTip and color from TextMarkRegistry to TextMark. Allowing every instance of a TextMark object to define these information. Change-Id: Iec1794372cf902b34d343402074e3999e7f9faf7 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Fix UI text capitalizationLeena Miettinen2017-04-051-13/+13
| | | | | Change-Id: Iccd08dae2ef2a86c0d0d5fb5d572b24664c40431 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Comment out quasi dead codeRobert Loehning2017-03-131-9/+9
| | | | | Change-Id: I8d7773d911646b05d6343241ae09882b40e861b2 Reviewed-by: hjk <hjk@qt.io>
* Remove spaces in initializer listsTim Jenssen2017-02-221-3/+3
| | | | | | | Format initializer lists code style like. Change-Id: Ib82c235e4ba7dc75ee96a7abc0c47eff7b0a9013 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Remove pleonasmRobert Loehning2017-02-151-1/+1
| | | | | Change-Id: I95a4089fe042b8e5c9bdede870489613e86f52fc Reviewed-by: hjk <hjk@qt.io>
View Lorry Controller Status