summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix reference on temperary valuev4.8.0-beta2Tim Jenssen2018-11-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Old code at Context::lookupReference took via Context::ptr() a temporary QSharedPointer as an argument into a reference member which is deleted just after ReferenceContext is constructed - changing that to a general member copies this temporary QSharedPointer and fixes the problem which was there since always and that this was not crashing before was just luck. class ReferenceContext { public: ReferenceContext(const ContextPtr &context); private: const ContextPtr &m_context; }; QWeakPointer<const Context> _ptr; ContextPtr Context::ptr() const { return _ptr.toStrongRef(); } const Value *Context::lookupReference(const Value *value) const { ReferenceContext refContext(ptr()); return refContext.lookupReference(value); } Task-number: QTCREATORBUG-21510 Change-Id: Ic49a0597763fb8be65feca6f24fec105d531d6ab Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* CppTools: Fix thread-unsafe call to MessageManager::write()Nikolai Kosjar2018-11-151-1/+14
| | | | | | | | | The Preprocessor running in a worker thread can call this function. Fixes: QTCREATORBUG-21481 Change-Id: I4970379fbabae23cfa3d7c1222e81a4ae8c3e6ad Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* Update qbs submoduleChristian Kandeler2018-11-151-0/+0
| | | | | | | To HEAD of 1.12 branch. Change-Id: I2fb087bc89907386ddd3fdcf5fd7ca808f149c1a Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Clang: Remove some warning flags provided by LLVMOrgad Shaneh2018-11-152-4/+16
| | | | | | | | Clang unit tests produce many warnings with GCC8 and these flags (-Wnon-virtual-dtor, -Woverloaded-virtual). Change-Id: I54a4c9c5b2f12da3c3898fc6f3beca0d4dfe478c Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* Clang: Default to llvm-config-7Orgad Shaneh2018-11-152-4/+4
| | | | | Change-Id: Id29095f378268b55430e715ec7d37f5a52159df5 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* Git: Fix checking out a branch after adding itOrgad Shaneh2018-11-151-3/+5
| | | | | | | Fallout from a9ac438ad8e8aa710810133802636aa82f6c821f. Change-Id: I07b36dd1bc5e9fb63f7d4552d9cb6ccd7ea2e22d Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Fix crash at shutdown if multiple windows are openEike Ziller2018-11-152-23/+26
| | | | | | | | | | | | | | | | The issue is that the window actions were explicitly made children of the ActionManager, but ActionManager is deleted earlier than the windows closed at shutdown. Change WindowList from a bunch of static data to an object with a lifetime and make it own the actions itself. Fix-up of 1b0d6e3c26c5dc54c6eae3cb21dc36a22ab1274c which started deleting the actions in the first place. Fixes: QTCREATORBUG-21221 Change-Id: I2e335887fa4b85b29bdaa2c908ec643b6abf3231 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Clang: Remove duplicate CXX flagsOrgad Shaneh2018-11-152-2/+2
| | | | | | | | Most of the flags appear twice on llvm-config-7 --cxxflags (at least on Debian). Change-Id: I9c5630d61472fa37bce998ec541a0ab561b83722 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* QmlDesigner: Use Image.PreserveAspectFit as default for resourcesThomas Hartmann2018-11-141-0/+2
| | | | | | Change-Id: I469bf4cb57b3fcc3f156021c4478442ec2f847f4 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* QmlDesigner: Do not show selection rect and label when movingThomas Hartmann2018-11-141-1/+1
| | | | | | | This makes repositioning items easier and the label is not in the way. Change-Id: I5020ee50ca95f57aac9d3af6abcd09ed41b6d0cd Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* QmlDesigner: Fix SelectionIndicator::hide()Thomas Hartmann2018-11-141-0/+4
| | | | | Change-Id: I62958b0a470724baeff1cfccd44b4ddacbd70f0e Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Tracing: Don't use "row" and "column" as IDsUlf Hermann2018-11-144-23/+25
| | | | | | | Fixes: QTCREATORBUG-21478 Change-Id: I9bda68abc4980ab9bc4247e48f5bc8bfc788c2dd Reviewed-by: Robert Loehning <robert.loehning@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* GDB: Enable adding expressions for core dumpOrgad Shaneh2018-11-141-0/+1
| | | | | Change-Id: I998bf3f3a7a719dc9b80492e55ffe5ace56ef461 Reviewed-by: hjk <hjk@qt.io>
* Documentation: Fix qbs buildChristian Kandeler2018-11-141-0/+4
| | | | | | | Amends 1e1c212090 and 54208113ee. Change-Id: I1f15a118b40513382e4e1d5767781865d4458ce9 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* More Qt Quick wizard fixes for Qt 5.12Eike Ziller2018-11-143-48/+48
| | | | | | | Task-number: QTCREATORBUG-21476 Change-Id: Icadcf12dc59786a62205cccc917a13b42f55b782 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: Robert Loehning <robert.loehning@qt.io>
* Tests: Allow dumper tests with Qt5.11 and Xcode 10Christian Stenger2018-11-141-0/+1
| | | | | | | | | qmake brings up a warning regarding using Qt5.11 in combination with Xcode 10. This seems to get handled as error inside the tests - so, disable the warning. Change-Id: I6d2918789580fd332048c85e0c4fc75a9635deb6 Reviewed-by: hjk <hjk@qt.io>
* Git: Make commit a bit less synchronousOrgad Shaneh2018-11-143-3/+8
| | | | | | | | | If gc.auto is configured, commit can trigger garbage collection, which takes time. Avoid completely blocking the UI on this case, and at least show the output of the commit command. Change-Id: Id301c878c26599bbc363928a6770c04369a62f2f Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Tracing: Only call QFutureWatcher::setFuture() after connecting to itUlf Hermann2018-11-141-1/+1
| | | | | | | Fixes: QTCREATORBUG-21485 Change-Id: Icc44cf0195775d31934a60cb064addc94b152d92 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Debugger: Fix translation contextsRobert Loehning2018-11-142-4/+7
| | | | | Change-Id: Id41ba15a4f0f5956148661e3c329cbb36a373f48 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* CompilationDatabase: Don't translate qWarningRobert Loehning2018-11-141-2/+1
| | | | | | | Change-Id: I5d7507fd05312e2d9b7ea57c94744aa311dc1104 Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
* Fix Qt Quick wizards with Qt 5.12 / ECMAScript 7Eike Ziller2018-11-145-60/+60
| | | | | | | | | | The expression that we used either worked in ECMAScript 6, or only accidentally worked in QJSEngine in Qt 5.11. Fixes: QTCREATORBUG-21476 Change-Id: Id2ce0932ead24c8caef9a82b10a173dfdcf1e927 Reviewed-by: Robert Loehning <robert.loehning@qt.io> Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Debugger: Fix display of location marker when switching perspectiveshjk2018-11-144-18/+20
| | | | | | Fixes: QTCREATORBUG-21362 Change-Id: I9bc1f0931ea902d04ab256774347b63c1fc64262 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Dumper: Fix activating frame for lldbChristian Stenger2018-11-141-1/+0
| | | | | | | ...when being attached to core file. Change-Id: I4f8364285d756bae53b4a14ca8feb74f7fdaacfb Reviewed-by: hjk <hjk@qt.io>
* winrt: Add categorized logging to device parserOliver Wolff2018-11-141-5/+41
| | | | | | Task-number: QTCREATORBUG-21366 Change-Id: I30dc7adc76a897fbed064123e5ef45d32bc552f2 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Debugger: Add some labels to the preset viewshjk2018-11-141-0/+12
| | | | | | | In the hope to make it more obvious what the new views are all about,. Change-Id: I3abde8a12cb5ac1f532f3b453c8d73f36498ff3d Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* ClangFormat: Do not format text but indent onlyIvan Donchevskii2018-11-147-48/+88
| | | | | | | | | | | | Provide the separate infrastructure for the formatting but use it only when QTC_FORMAT_INSTEAD_OF_INDENT is provided in run environment. Fixes: QTCREATORBUG-21447 Fixes: QTCREATORBUG-21459 Change-Id: I1ad6fe23f5de17016c0c7b18749c6977fc03a22b Reviewed-by: Marco Bubke <marco.bubke@qt.io> Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* ClangFormat: Use relevant settings for each fileIvan Donchevskii2018-11-145-48/+54
| | | | | | | | | | | | | Existing Clang Format settings may not follow the project/global pattern but can be expected to be used for the indentation/formatting. So let's proceed with UI for global/project settings but use global settings only if there's no configuration found for the current file. Change-Id: I87c25ab3feb7e2e3deb0290848088657783cf972 Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* Clang: Fix completion icon for members in member init listNikolai Kosjar2018-11-143-0/+20
| | | | | Change-Id: Ib02320dcf4de7cbb8ac6fbf29d1929edae77591a Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
* Designer: Fix crash on closeChristian Stenger2018-11-142-0/+11
| | | | | | | | ...when executing plugin unit tests for Designer. Change-Id: Ic3252bfef4559de4e54f5c3c3fd1984ab6a00f9d Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* Debugger: Silence soft assertChristian Stenger2018-11-131-4/+5
| | | | | | | | | Enabling or disabling a multiple break points that have different states will trigger the soft assert for all break points having the destination state already. Change-Id: I61d859c0af548cb1dd9070a28c9aacee241e075b Reviewed-by: hjk <hjk@qt.io>
* Squish: Fix using locatorChristian Stenger2018-11-131-1/+1
| | | | | Change-Id: Ifbc693439cbcd4146f1b18e67f1f1d6bc49162e5 Reviewed-by: Robert Loehning <robert.loehning@qt.io>
* reduce compression rate to save some RAMTim Jenssen2018-11-131-1/+1
| | | | | Change-Id: Icc124948a5223294e90fa27b7c4cf5924bdab5e2 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* ClangFormat: Use the constant for the configuration filenameIvan Donchevskii2018-11-133-6/+13
| | | | | | | | It is unlikely that this name changes but let's follow good coding practices. Change-Id: I12adbf155f26b1b3a02d07092fcc113e0c5157e6 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* Debugger: Make validateExecutable a validateRunParametershjk2018-11-132-11/+4
| | | | | | | | Gets rid of the odd and otherwise unused DebuggerEngine::mutableRunParameters() function. Change-Id: Ib0861432e7c61072db2968acf2f36c7f2d56c89a Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* ClangFormat: Improve current style detectionIvan Donchevskii2018-11-131-2/+9
| | | | | | | | Check first if the current project already has .clang-format configuration file. Change-Id: Ic8cb5d37c32cd5b0c04485589caea95de933c264 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* CppTools: Simplify the currentProjectCodeStyle codeIvan Donchevskii2018-11-131-4/+5
| | | | | | | Use alias to shorten the repeating default return value. Change-Id: I673fc1d293c1612c945c80d554c6667a756108de Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* ClangFormat: Set BreakBeforeBraces to Custom by defaultIvan Donchevskii2018-11-131-0/+2
| | | | | | | | | | | | If it's not set to custom some user settings are continuously overridden which is not always expected. Previously the default style caused some parameters to be reset. Change-Id: Ie0fedf6b9984116a86b7c588aed8c6b6cb35133e Reviewed-by: Marco Bubke <marco.bubke@qt.io> Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* Clang: Change dot <-> arrow if all completions require itIvan Donchevskii2018-11-133-2/+40
| | | | | | | | | | Return the behavior that existed before completion fix-its were introduced. Apply it only for the cases when all items require the fix-it. Fixes: QTCREATORBUG-21367 Change-Id: Idc358255135f72353f3fd3204b653fc2fc55e7a0 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* Debugger: Fix cut-and-pastohjk2018-11-131-7/+0
| | | | | | | Amends c3f29684fab92a6b51dfaa59254a61c86ed4968a. Change-Id: I19e7a9ce65780822f8a9718906acc68f6f7e7454 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* CppTools: Forward OpenMP extension flagNikolai Kosjar2018-11-131-0/+3
| | | | | | Fixes: QTCREATORBUG-21213 Change-Id: I986ab69bc44ece83a3b56f968cc3b6c3126e2c32 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
* Clang: Allow overtyping ) after completing function like snippetsNikolai Kosjar2018-11-131-3/+22
| | | | | | Fixes: QTCREATORBUG-21166 Change-Id: I02e20a230012ce82aed668a46f5fd4a02796135b Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
* Debugger: Fix handling of some actions after multiinferior splithjk2018-11-133-32/+76
| | | | | | | | | | | The pattern used is some inactive/invible global action with a command to put in the menus, and per-engine action "overloads" to reflect the active engine's state once there is an engine. Task-number: QTCREATORBUG-21454 Change-Id: I861a42994849ef9f0b51fb7b1608f14fa7fa9d7c Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Doc: Change a link to a previous pageLeena Miettinen2018-11-121-1/+1
| | | | | | | | | The page is now automatically generated, so the title needs to be used instead of the filename. Change-Id: I3363792466082a14a10b32ab9f98b2b24c0e856a Reviewed-by: Brook Cronin <brook.cronin@qt.io> Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* Update qbs submoduleChristian Kandeler2018-11-121-0/+0
| | | | | | | To HEAD of 1.12 branch. Change-Id: I1711d2c5fb40f77858ce0bdac990822fbb568ef4 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Fix Qt version detection in the cdbbridgeDavid Schulz2018-11-121-9/+12
| | | | | | | | broken by b2052561cca185ca18b114110ae401ad9cb43aec Fixes: QTCREATORBUG-21446 Change-Id: I303bb943a3b39703a6c5898aab99b89d35d1d2d7 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Fix fetching memoryDavid Schulz2018-11-121-1/+1
| | | | | | | Do not dereference function parameter in async callback. Change-Id: I9a6cebdc59579f230a5f570969c9cd1c6417edfc Reviewed-by: hjk <hjk@qt.io>
* Debugger: Fix assignment to QString etc with LLDBhjk2018-11-122-5/+33
| | | | | | Task-number: QTCREATORBUG-21353 Change-Id: Ie3655738c249240d9fbf17e054fc8f79a284efd4 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Do not pretendhjk2018-11-121-1/+3
| | | | | | | ... the preset perspective had an associated debugger. Change-Id: Icf4f07c5e184530e9c3cee920dcbff9b66066c31 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* SerialTerminal: Select text in input line after each commandOrgad Shaneh2018-11-121-0/+1
| | | | | | | | Makes it easier to type a different command. Change-Id: Ica152575f2f5130a8f2da75379403841aba89176 Reviewed-by: Benjamin Balga <balga.benjamin@gmail.com> Reviewed-by: André Hartmann <aha_1980@gmx.de>
* CppTools: Allow to check whether project code style existsIvan Donchevskii2018-11-124-11/+19
| | | | | | | | | | | The calling code can anyways fallback to the global style without extra help if no project style exists. It is useful when you want to get the project style if it exists and understand at the same time that it is not a global one. Change-Id: I265de3f436f90623385427fc8a1abad09c8c3577 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>