diff options
author | Kevin Funk <kevin.funk@kdab.com> | 2011-05-11 16:26:34 +0200 |
---|---|---|
committer | hjk <qtc-committer@nokia.com> | 2011-05-11 16:26:34 +0200 |
commit | bf1f5c2b02bd57cffc127f15fe05099c862102e3 (patch) | |
tree | 10748c8300dac8a2925e4231d7cf72d96923abc8 /tests/valgrind | |
parent | f5601d7b1b01ad3b1a39353bb8ef942f1f92cad6 (diff) | |
download | qt-creator-bf1f5c2b02bd57cffc127f15fe05099c862102e3.tar.gz |
Fixes for valgrind-callgrind feedback by Nokia
Most changes include style fixes and UI changes for better usability.
Merge-request: 324
Reviewed-by: hjk <qtc-committer@nokia.com>
Diffstat (limited to 'tests/valgrind')
-rw-r--r-- | tests/valgrind/callgrind/callgrindparsertests.cpp | 2 | ||||
-rw-r--r-- | tests/valgrind/callgrind/modeltest.cpp | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/tests/valgrind/callgrind/callgrindparsertests.cpp b/tests/valgrind/callgrind/callgrindparsertests.cpp index c75492d294..73a6c8bd4d 100644 --- a/tests/valgrind/callgrind/callgrindparsertests.cpp +++ b/tests/valgrind/callgrind/callgrindparsertests.cpp @@ -368,7 +368,7 @@ void CallgrindParserTests::testMultiPosAndCost() const Function *findFunction(const QString &needle, const QVector<const Function *> &haystack) { - foreach(const Function *function, haystack) { + foreach (const Function *function, haystack) { if (function->name() == needle) { return function; } diff --git a/tests/valgrind/callgrind/modeltest.cpp b/tests/valgrind/callgrind/modeltest.cpp index c98c6cc1ef..53030f8c6b 100644 --- a/tests/valgrind/callgrind/modeltest.cpp +++ b/tests/valgrind/callgrind/modeltest.cpp @@ -162,9 +162,9 @@ void ModelTestWidget::showViewContextMenu(const QPoint &pos) QVector<quint64> totalCosts; totalCosts.fill(0, data->events().size()); - for(int row = 0; row < rows; ++row) { + for (int row = 0; row < rows; ++row) { const CostItem *item = func->costItems().at(row); - for(int column = 0; column < columns; ++column) { + for (int column = 0; column < columns; ++column) { QVariant value; if (column < lastEventColumn) { value = item->cost(column); @@ -181,7 +181,7 @@ void ModelTestWidget::showViewContextMenu(const QPoint &pos) } } QStringList totalCostsStrings; - for(int i = 0; i < totalCosts.size(); ++i) { + for (int i = 0; i < totalCosts.size(); ++i) { totalCostsStrings << QString("%1: %2").arg(totalCosts.at(i)).arg(data->events().at(i)); } view->setWindowTitle(totalCostsStrings.join(QLatin1String(", "))); |