Clang: Ensure to clear all affected translation units on project part change

The ones that were already dirty were not taken into the account and
used the old project configuration.

Change-Id: I949d1ca8c23bbdb18eec78e5a708199beff6f735
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>

1 files changed, 17 insertions, 5 deletions

diff --git a/tests/unit/unittest/clangdocuments-test.cpp b/tests/unit/unittest/clangdocuments-test.cpp
index e2622f5b33..71186353ee 100644
--- a/tests/unit/unittest/clangdocuments-test.cpp
+++ b/tests/unit/unittest/clangdocuments-test.cpp
@@ -410,19 +410,31 @@ TEST_F(Documents, SetDocumentsDirtyIfProjectPartChanged)
     documents.create({fileContainerWithOtherProject});
     projects.createOrUpdate({ProjectPartContainer(projectPartId)});
 
-    const auto notDirtyBefore = documents.setDocumentsDirtyIfProjectPartChanged();
+    const auto affectedDocuments = documents.setDocumentsDirtyIfProjectPartChanged();
 
-    ASSERT_THAT(notDirtyBefore, createdDocuments);
+    ASSERT_THAT(affectedDocuments, createdDocuments);
 }
 
-TEST_F(Documents, SetDocumentsDirtyIfProjectPartChangedReturnsEmpty)
+TEST_F(Documents, SetDocumentsDirtyIfProjectPartChanged_EvenIfAlreadyDirty)
+{
+    ClangBackEnd::FileContainer fileContainer(filePath, projectPartId, Utf8StringVector(), 74u);
+    auto createdDocuments = documents.create({fileContainer});
+    projects.createOrUpdate({ProjectPartContainer(projectPartId)});
+    documents.setDocumentsDirtyIfProjectPartChanged(); // Make already dirty
+
+    const auto affectedDocuments = documents.setDocumentsDirtyIfProjectPartChanged();
+
+    ASSERT_THAT(affectedDocuments, createdDocuments);
+}
+
+TEST_F(Documents, SetDocumentsDirtyIfProjectPartChanged_ReturnsEmpty)
 {
     ClangBackEnd::FileContainer fileContainer(filePath, projectPartId, Utf8StringVector(), 74u);
     documents.create({fileContainer});
 
-    const auto notDirtyBefore = documents.setDocumentsDirtyIfProjectPartChanged();
+    const auto affectedDocuments = documents.setDocumentsDirtyIfProjectPartChanged();
 
-    ASSERT_TRUE(notDirtyBefore.empty());
+    ASSERT_TRUE(affectedDocuments.empty());
 }
 
 void Documents::SetUp()