C++: Fix crash with invalid raw string literal

While parsing a document Bind::asStringLiteral() Token::spell() was
called for a raw string literal token with a Token::literal nullptr.

This is due scanRawStringLiteral() not properly aborting for
invalid/incomplete code and that the code paths handling
multi-line-raw-strings were not limited to the highlighting case.

Address both cases.

Task-number: QTCREATORBUG-18941
Change-Id: I489d288ccbd7b59be396dada846613ff555436cf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

1 files changed, 13 insertions, 0 deletions

diff --git a/tests/auto/cplusplus/misc/tst_misc.cpp b/tests/auto/cplusplus/misc/tst_misc.cpp
index aff5a12ce0..808408df40 100644
--- a/tests/auto/cplusplus/misc/tst_misc.cpp
+++ b/tests/auto/cplusplus/misc/tst_misc.cpp
@@ -48,6 +48,8 @@ private slots:
     void astPathOnGeneratedTokens();
 
     void typeMatcher();
+
+    void doNotCrashForInvalidRawString();
 };
 
 void tst_Misc::diagnosticClient_error()
@@ -266,5 +268,16 @@ void tst_Misc::typeMatcher()
     }
 }
 
+void tst_Misc::doNotCrashForInvalidRawString()
+{
+    const QByteArray src("\n"
+                         "void f() { enum { Size = sizeof(R\"[^\\s]+([^]+)*\") }; }"
+                         "}\n"
+                         );
+    Document::Ptr doc = Document::create("crash");
+    doc->setUtf8Source(src);
+    doc->check();
+}
+
 QTEST_MAIN(tst_Misc)
 #include "tst_misc.moc"