diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2016-11-25 16:56:56 +0100 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@qt.io> | 2016-11-28 08:19:09 +0000 |
| commit | 31749b76b83e3de392fcd80c2e2d11c71a36f25f (patch) | |
| tree | 398864677bf134421dd4a60dc04649cfde17ca62 /src | |
| parent | f4223aa4f6a8d42b9c50dd9ac8d525405129e44f (diff) | |
| download | qt-creator-31749b76b83e3de392fcd80c2e2d11c71a36f25f.tar.gz | |
Cmake: Don't take QStringRefs of a temporary QString
This crashes.
Change-Id: I3f81466f504fdff8d47372425ea8f84048f89b76
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/cmakeprojectmanager/cmaketool.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/plugins/cmakeprojectmanager/cmaketool.cpp b/src/plugins/cmakeprojectmanager/cmaketool.cpp index e38ce68748..acfb553e6a 100644 --- a/src/plugins/cmakeprojectmanager/cmaketool.cpp +++ b/src/plugins/cmakeprojectmanager/cmaketool.cpp @@ -411,7 +411,8 @@ void CMakeTool::fetchVersionFromVersionOutput() const return; QRegularExpression versionLine("^cmake version ((\\d+).(\\d+).(\\d+).*)$"); - for (const QStringRef &line : response.stdOut().splitRef(QLatin1Char('\n'))) { + const QString responseText = response.stdOut(); + for (const QStringRef &line : responseText.splitRef(QLatin1Char('\n'))) { QRegularExpressionMatch match = versionLine.match(line); if (!match.hasMatch()) continue; |