diff options
| author | hjk <hjk@qt.io> | 2018-03-20 08:05:19 +0100 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2018-03-20 10:14:50 +0000 |
| commit | 5d79e1dcee768442efbb19c825ec6b50f03c441d (patch) | |
| tree | d52d5d52933a4ee259112da5a9335f74ed7df5fe /src | |
| parent | 80f98a7fb92f1e37404dd7d5e5b58b6f86df024a (diff) | |
| download | qt-creator-5d79e1dcee768442efbb19c825ec6b50f03c441d.tar.gz | |
Drop QFileInfo::exists() check before trying to run an executable
Physical existence of a file is not strictly needed for something
being runnable, e.g. 'foo' can be used to start a process on windows,
even when only 'foo.exe', but not 'foo' itself exists.
On the other hand, the existence of the file is not sufficient either
to run it, so the check was too weak and too strict at the same time.
Change-Id: I4a41d2f5cbb0cb471023a8bc23628072b28a5984
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/projectexplorer/runconfiguration.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/plugins/projectexplorer/runconfiguration.cpp b/src/plugins/projectexplorer/runconfiguration.cpp index 5f91c9fa9d..bf92088dfa 100644 --- a/src/plugins/projectexplorer/runconfiguration.cpp +++ b/src/plugins/projectexplorer/runconfiguration.cpp @@ -1572,9 +1572,6 @@ void SimpleTargetRunner::start() const QString executable = m_runnable.as<StandardRunnable>().executable; if (executable.isEmpty()) { reportFailure(RunControl::tr("No executable specified.")); - } else if (!QFileInfo::exists(executable)) { - reportFailure(RunControl::tr("Executable %1 does not exist.") - .arg(QDir::toNativeSeparators(executable))); } else { m_launcher.start(m_runnable); } |