diff options
author | jkobus <jaroslaw.kobus@digia.com> | 2014-03-10 13:28:34 +0100 |
---|---|---|
committer | Jarek Kobus <jaroslaw.kobus@digia.com> | 2014-03-10 14:35:51 +0100 |
commit | b8046e603d5bae78c301a9bdb22e2d55a1743b17 (patch) | |
tree | 162e324de29a61848372e27d3a765bfcf1d9366a /src | |
parent | 4bf11c7df6aac526a9272a827fa96d099253cbcf (diff) | |
download | qt-creator-b8046e603d5bae78c301a9bdb22e2d55a1743b17.tar.gz |
Don't register mimetype for diff editor
Task-number: QTCREATORBUG-11624
Change-Id: I9eeeeeb862e335c1a4d5cbd80d0908297ad6d1db
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/plugins/diffeditor/diffeditor.cpp | 2 | ||||
-rw-r--r-- | src/plugins/diffeditor/diffeditorconstants.h | 1 | ||||
-rw-r--r-- | src/plugins/diffeditor/diffeditordocument.cpp | 5 | ||||
-rw-r--r-- | src/plugins/diffeditor/diffeditordocument.h | 3 | ||||
-rw-r--r-- | src/plugins/diffeditor/diffeditorfactory.cpp | 1 |
5 files changed, 4 insertions, 8 deletions
diff --git a/src/plugins/diffeditor/diffeditor.cpp b/src/plugins/diffeditor/diffeditor.cpp index 77338f9870..11461aa851 100644 --- a/src/plugins/diffeditor/diffeditor.cpp +++ b/src/plugins/diffeditor/diffeditor.cpp @@ -113,7 +113,7 @@ void DescriptionEditorWidget::setDisplaySettings(const DisplaySettings &ds) DiffEditor::DiffEditor() : IEditor(0) - , m_document(new DiffEditorDocument(QLatin1String(Constants::DIFF_EDITOR_MIMETYPE))) + , m_document(new DiffEditorDocument()) , m_descriptionWidget(0) , m_diffWidget(0) , m_controller(0) diff --git a/src/plugins/diffeditor/diffeditorconstants.h b/src/plugins/diffeditor/diffeditorconstants.h index 6180557dbb..a19528ce15 100644 --- a/src/plugins/diffeditor/diffeditorconstants.h +++ b/src/plugins/diffeditor/diffeditorconstants.h @@ -37,7 +37,6 @@ namespace Constants { const char DIFF_EDITOR_ID[] = "Diff Editor"; const char DIFF_EDITOR_DISPLAY_NAME[] = QT_TRANSLATE_NOOP("DiffEditor", "Diff Editor"); -const char DIFF_EDITOR_MIMETYPE[] = "text/x-patch"; const char G_TOOLS_DIFF[] = "QtCreator.Group.Tools.Options"; } // namespace Constants diff --git a/src/plugins/diffeditor/diffeditordocument.cpp b/src/plugins/diffeditor/diffeditordocument.cpp index 36999ac8ca..4daa270ae9 100644 --- a/src/plugins/diffeditor/diffeditordocument.cpp +++ b/src/plugins/diffeditor/diffeditordocument.cpp @@ -35,9 +35,8 @@ namespace DiffEditor { -DiffEditorDocument::DiffEditorDocument(const QString &mimeType) : +DiffEditorDocument::DiffEditorDocument() : Core::IDocument(), - m_mimeType(mimeType), m_diffEditorController(new DiffEditorController(this)) { setDisplayName(QCoreApplication::translate("DiffEditor", Constants::DIFF_EDITOR_DISPLAY_NAME)); @@ -69,7 +68,7 @@ bool DiffEditorDocument::save(QString *errorString, const QString &fileName, boo QString DiffEditorDocument::mimeType() const { - return m_mimeType; + return QString(); } Core::IDocument::ReloadBehavior DiffEditorDocument::reloadBehavior(ChangeTrigger state, ChangeType type) const diff --git a/src/plugins/diffeditor/diffeditordocument.h b/src/plugins/diffeditor/diffeditordocument.h index 259b60d087..ffed43ce5d 100644 --- a/src/plugins/diffeditor/diffeditordocument.h +++ b/src/plugins/diffeditor/diffeditordocument.h @@ -42,7 +42,7 @@ class DIFFEDITOR_EXPORT DiffEditorDocument : public Core::IDocument { Q_OBJECT public: - explicit DiffEditorDocument(const QString &mimeType); + explicit DiffEditorDocument(); virtual ~DiffEditorDocument(); DiffEditorController *controller() const; @@ -59,7 +59,6 @@ public: bool reload(QString *errorString, ReloadFlag flag, ChangeType type); private: - const QString m_mimeType; DiffEditorController *m_diffEditorController; }; diff --git a/src/plugins/diffeditor/diffeditorfactory.cpp b/src/plugins/diffeditor/diffeditorfactory.cpp index f323405ae2..25c873654e 100644 --- a/src/plugins/diffeditor/diffeditorfactory.cpp +++ b/src/plugins/diffeditor/diffeditorfactory.cpp @@ -43,7 +43,6 @@ DiffEditorFactory::DiffEditorFactory(QObject *parent) { setId(Constants::DIFF_EDITOR_ID); setDisplayName(qApp->translate("DiffEditorFactory", Constants::DIFF_EDITOR_DISPLAY_NAME)); - addMimeType(QLatin1String(Constants::DIFF_EDITOR_MIMETYPE)); } Core::IEditor *DiffEditorFactory::createEditor() |