diff options
| author | Ivan Donchevskii <ivan.donchevskii@qt.io> | 2018-10-25 10:03:21 +0200 |
|---|---|---|
| committer | Ivan Donchevskii <ivan.donchevskii@qt.io> | 2018-10-26 07:22:24 +0000 |
| commit | 93269f3ecddd1fd6746123b7e78f981b4e9e6fc2 (patch) | |
| tree | e2f11ab1784d59eaac86dd448940e749079871c6 /src/tools | |
| parent | fe873398885673fea7df8adebd3f750f79b32459 (diff) | |
| download | qt-creator-93269f3ecddd1fd6746123b7e78f981b4e9e6fc2.tar.gz | |
Clang: Add unit-tests for function overloads completion order
Make sure that the same function overloads with different priorities
come together in the completions list.
Fixes the case when we complete the method without '.' or '->'.
Change-Id: Icaf7ea47f5e58b3ae5cc9764ad79c857f6f6e231
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/clangbackend/source/codecompletionsextractor.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/tools/clangbackend/source/codecompletionsextractor.cpp b/src/tools/clangbackend/source/codecompletionsextractor.cpp index f9c019b66d..b42520c7e5 100644 --- a/src/tools/clangbackend/source/codecompletionsextractor.cpp +++ b/src/tools/clangbackend/source/codecompletionsextractor.cpp @@ -115,7 +115,9 @@ static void adaptOverloadsPriorities(CodeCompletions &codeCompletions) std::map<Utf8String, std::vector<CodeCompletion *>> cachedOverloads; for (CodeCompletion ¤tCompletion : codeCompletions) { if (currentCompletion.completionKind != CodeCompletion::ConstructorCompletionKind - && currentCompletion.completionKind != CodeCompletion::FunctionCompletionKind) { + && currentCompletion.completionKind != CodeCompletion::FunctionCompletionKind + && currentCompletion.completionKind + != CodeCompletion::FunctionDefinitionCompletionKind) { continue; } |