diff options
author | Friedemann Kleint <Friedemann.Kleint@nokia.com> | 2010-10-20 15:17:19 +0200 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@nokia.com> | 2010-10-20 15:17:19 +0200 |
commit | e0e59232964f050d78f99b7d6423a7de8e8e5234 (patch) | |
tree | 1cd42ceef385f85cccb4e09ee73e6e9d6265d604 /src/tools/qtcdebugger/main.cpp | |
parent | b2369973a4548a9dd341deb7a4a427e36f1fe640 (diff) | |
download | qt-creator-e0e59232964f050d78f99b7d6423a7de8e8e5234.tar.gz |
Debugger: Do not pass -client for Windows-post-mortem debugging.
Reviewed-by: Robert Loehning <robert.loehning@nokia.com>
Task-number: QTCREATORBUG-2827
Diffstat (limited to 'src/tools/qtcdebugger/main.cpp')
-rw-r--r-- | src/tools/qtcdebugger/main.cpp | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/tools/qtcdebugger/main.cpp b/src/tools/qtcdebugger/main.cpp index 14fb414a2a..fd6aa6942d 100644 --- a/src/tools/qtcdebugger/main.cpp +++ b/src/tools/qtcdebugger/main.cpp @@ -269,6 +269,7 @@ bool startCreatorAsDebugger(bool asClient, QString *errorMessage) const QString dir = QApplication::applicationDirPath(); const QString binary = dir + QLatin1Char('/') + QLatin1String(creatorBinaryC); QStringList args; + // Send to running Creator: Unstable with directly linked CDB engine. if (asClient) args << QLatin1String("-client"); args << QLatin1String("-debug") << QString::number(argProcessId) @@ -356,8 +357,10 @@ bool chooseDebugger(QString *errorMessage) if (msgBox.clickedButton() == creatorButton) { // Just in case, default to standard. Do not run as client in the unlikely case // Creator crashed + // TODO: pass asClient=true for new CDB engine. const bool canRunAsClient = !processName.contains(QLatin1String(creatorBinaryC), Qt::CaseInsensitive); - if (startCreatorAsDebugger(canRunAsClient, errorMessage)) + Q_UNUSED(canRunAsClient) + if (startCreatorAsDebugger(false, errorMessage)) return true; return startDefaultDebugger(errorMessage); } @@ -478,7 +481,8 @@ int main(int argc, char *argv[]) usage(QCoreApplication::applicationFilePath(), errorMessage); break; case ForceCreatorMode: - ex = startCreatorAsDebugger(true, &errorMessage) ? 0 : -1; + // TODO: pass asClient=true for new CDB engine. + ex = startCreatorAsDebugger(false, &errorMessage) ? 0 : -1; break; case ForceDefaultMode: ex = startDefaultDebugger(&errorMessage) ? 0 : -1; |