diff options
| author | Ulf Hermann <ulf.hermann@theqtcompany.com> | 2014-11-19 17:23:15 +0100 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@theqtcompany.com> | 2014-11-19 18:57:10 +0100 |
| commit | 4e3435a5cf3e553a3b56f2c32ef34ab79056b7f3 (patch) | |
| tree | 10b5c7bb9866206ba0fbcfaec60bbcbee54ec21e /src/plugins | |
| parent | beac7b9539457fe721de1709b9a406cac2379851 (diff) | |
| download | qt-creator-4e3435a5cf3e553a3b56f2c32ef34ab79056b7f3.tar.gz | |
Analyzer: Trigger stopIt() only once when pressing the stop button
The stopIt() slot is already connected in the constructor of
AnalyzerRunControl.
The double connection is clearly not intended and, considering that
various analyzers modify internal state from those callse, could lead
to incorrect behavior.
Change-Id: I1c68eb06729849771f4a25257a219c84a032adf3
Reviewed-by: hjk <hjk121@nokiamail.com>
Diffstat (limited to 'src/plugins')
| -rw-r--r-- | src/plugins/qmlprofiler/qmlprofilertool.cpp | 1 | ||||
| -rw-r--r-- | src/plugins/valgrind/valgrindtool.cpp | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/src/plugins/qmlprofiler/qmlprofilertool.cpp b/src/plugins/qmlprofiler/qmlprofilertool.cpp index 53466822f7..235f684c3e 100644 --- a/src/plugins/qmlprofiler/qmlprofilertool.cpp +++ b/src/plugins/qmlprofiler/qmlprofilertool.cpp @@ -454,7 +454,6 @@ static void startRemoteTool(IAnalyzerTool *tool, StartMode mode) sp.analyzerPort = port; AnalyzerRunControl *rc = tool->createRunControl(sp, 0); - QObject::connect(AnalyzerManager::stopAction(), SIGNAL(triggered()), rc, SLOT(stopIt())); ProjectExplorerPlugin::startRunControl(rc, tool->runMode()); } diff --git a/src/plugins/valgrind/valgrindtool.cpp b/src/plugins/valgrind/valgrindtool.cpp index 361fc9c5f5..f348288c67 100644 --- a/src/plugins/valgrind/valgrindtool.cpp +++ b/src/plugins/valgrind/valgrindtool.cpp @@ -150,7 +150,6 @@ static void startRemoteTool(IAnalyzerTool *tool) sp.workingDirectory = dlg.workingDirectory(); AnalyzerRunControl *rc = tool->createRunControl(sp, 0); - QObject::connect(AnalyzerManager::stopAction(), SIGNAL(triggered()), rc, SLOT(stopIt())); ProjectExplorerPlugin::startRunControl(rc, tool->runMode()); } |