diff options
author | Thiago Macieira <thiago.macieira@intel.com> | 2014-02-02 14:14:00 -0800 |
---|---|---|
committer | Thiago Macieira <thiago.macieira@intel.com> | 2014-02-03 20:19:44 +0100 |
commit | f1606a9f58267c53440651757c0a6608c9c65c04 (patch) | |
tree | e94940da078dbc078e4b26279040cc5c8c8bd3a0 /src/plugins | |
parent | 10f0044031d1aba06aacbcb628aaa4a35a459438 (diff) | |
download | qt-creator-f1606a9f58267c53440651757c0a6608c9c65c04.tar.gz |
Normalize signal & slot signatures in connection
Profiling shows Qt Creator spends 2% of its load time normalizing
Change-Id: I7c38825875c8db58813792dcb86b3a88945466f7
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins')
-rw-r--r-- | src/plugins/clangcodemodel/pchmanager.cpp | 4 | ||||
-rw-r--r-- | src/plugins/cppeditor/cppcodemodelinspectordialog.cpp | 12 | ||||
-rw-r--r-- | src/plugins/cppeditor/cppincludehierarchy.cpp | 4 | ||||
-rw-r--r-- | src/plugins/cpptools/cpptoolseditorsupport.cpp | 2 | ||||
-rw-r--r-- | src/plugins/texteditor/texteditorsettings.cpp | 2 |
5 files changed, 12 insertions, 12 deletions
diff --git a/src/plugins/clangcodemodel/pchmanager.cpp b/src/plugins/clangcodemodel/pchmanager.cpp index ec0bb2591a..fd62dd076f 100644 --- a/src/plugins/clangcodemodel/pchmanager.cpp +++ b/src/plugins/clangcodemodel/pchmanager.cpp @@ -51,8 +51,8 @@ PCHManager::PCHManager(QObject *parent) m_instance = this; QObject *msgMgr = Core::MessageManager::instance(); - connect(this, SIGNAL(pchMessage(QString, Core::MessageManager::PrintToOutputPaneFlags)), - msgMgr, SLOT(write(QString, Core::MessageManager::PrintToOutputPaneFlags))); + connect(this, SIGNAL(pchMessage(QString,Core::MessageManager::PrintToOutputPaneFlags)), + msgMgr, SLOT(write(QString,Core::MessageManager::PrintToOutputPaneFlags))); connect(&m_pchGenerationWatcher, SIGNAL(finished()), this, SLOT(updateActivePCHFiles())); diff --git a/src/plugins/cppeditor/cppcodemodelinspectordialog.cpp b/src/plugins/cppeditor/cppcodemodelinspectordialog.cpp index 201fb9ebbb..461ce25a8e 100644 --- a/src/plugins/cppeditor/cppcodemodelinspectordialog.cpp +++ b/src/plugins/cppeditor/cppcodemodelinspectordialog.cpp @@ -1833,8 +1833,8 @@ CppCodeModelInspectorDialog::CppCodeModelInspectorDialog(QWidget *parent) m_workingCopyView->setModel(m_proxyWorkingCopyModel); connect(m_snapshotView->selectionModel(), - SIGNAL(currentRowChanged(QModelIndex ,QModelIndex)), - SLOT(onDocumentSelected(QModelIndex, QModelIndex))); + SIGNAL(currentRowChanged(QModelIndex,QModelIndex)), + SLOT(onDocumentSelected(QModelIndex,QModelIndex))); connect(m_snapshotView, SIGNAL(filterChanged(QString)), SLOT(onSnapshotFilterChanged(QString))); connect(m_ui->snapshotSelector, SIGNAL(currentIndexChanged(int)), @@ -1845,14 +1845,14 @@ CppCodeModelInspectorDialog::CppCodeModelInspectorDialog(QWidget *parent) SLOT(onSymbolsViewExpandedOrCollapsed(QModelIndex))); connect(m_projectPartsView->selectionModel(), - SIGNAL(currentRowChanged(QModelIndex ,QModelIndex)), - SLOT(onProjectPartSelected(QModelIndex, QModelIndex))); + SIGNAL(currentRowChanged(QModelIndex,QModelIndex)), + SLOT(onProjectPartSelected(QModelIndex,QModelIndex))); connect(m_projectPartsView, SIGNAL(filterChanged(QString)), SLOT(onProjectPartFilterChanged(QString))); connect(m_workingCopyView->selectionModel(), - SIGNAL(currentRowChanged(QModelIndex ,QModelIndex)), - SLOT(onWorkingCopyDocumentSelected(QModelIndex, QModelIndex))); + SIGNAL(currentRowChanged(QModelIndex,QModelIndex)), + SLOT(onWorkingCopyDocumentSelected(QModelIndex,QModelIndex))); connect(m_workingCopyView, SIGNAL(filterChanged(QString)), SLOT(onWorkingCopyFilterChanged(QString))); diff --git a/src/plugins/cppeditor/cppincludehierarchy.cpp b/src/plugins/cppeditor/cppincludehierarchy.cpp index 2806b0c011..e32467d238 100644 --- a/src/plugins/cppeditor/cppincludehierarchy.cpp +++ b/src/plugins/cppeditor/cppincludehierarchy.cpp @@ -120,8 +120,8 @@ CppIncludeHierarchyWidget::CppIncludeHierarchyWidget() : setLayout(layout); connect(CppEditorPlugin::instance(), SIGNAL(includeHierarchyRequested()), SLOT(perform())); - connect(Core::EditorManager::instance(), SIGNAL(editorsClosed(QList<Core::IEditor *>)), - this, SLOT(editorsClosed(QList<Core::IEditor *>))); + connect(Core::EditorManager::instance(), SIGNAL(editorsClosed(QList<Core::IEditor*>)), + this, SLOT(editorsClosed(QList<Core::IEditor*>))); } diff --git a/src/plugins/cpptools/cpptoolseditorsupport.cpp b/src/plugins/cpptools/cpptoolseditorsupport.cpp index 66d2f8adce..2638a127ce 100644 --- a/src/plugins/cpptools/cpptoolseditorsupport.cpp +++ b/src/plugins/cpptools/cpptoolseditorsupport.cpp @@ -153,7 +153,7 @@ CppEditorSupport::CppEditorSupport(CppModelManager *modelManager, BaseTextEditor connect(m_textEditor->document(), SIGNAL(reloadFinished(bool)), this, SLOT(onReloadFinished())); - connect(Core::EditorManager::instance(), SIGNAL(currentEditorChanged(Core::IEditor *)), + connect(Core::EditorManager::instance(), SIGNAL(currentEditorChanged(Core::IEditor*)), this, SLOT(onCurrentEditorChanged())); m_editorGCTimer = new QTimer(this); m_editorGCTimer->setSingleShot(true); diff --git a/src/plugins/texteditor/texteditorsettings.cpp b/src/plugins/texteditor/texteditorsettings.cpp index ebe1f61501..2fbbe433d0 100644 --- a/src/plugins/texteditor/texteditorsettings.cpp +++ b/src/plugins/texteditor/texteditorsettings.cpp @@ -342,7 +342,7 @@ void TextEditorSettings::initializeEditor(BaseTextEditorWidget *editor) editor, SLOT(setStorageSettings(TextEditor::StorageSettings))); connect(m_instance, SIGNAL(behaviorSettingsChanged(TextEditor::BehaviorSettings)), editor, SLOT(setBehaviorSettings(TextEditor::BehaviorSettings))); - connect(m_instance, SIGNAL(marginSettingsChanged(const TextEditor::MarginSettings &)), + connect(m_instance, SIGNAL(marginSettingsChanged(TextEditor::MarginSettings)), editor, SLOT(setMarginSettings(TextEditor::MarginSettings))); connect(m_instance, SIGNAL(displaySettingsChanged(TextEditor::DisplaySettings)), editor, SLOT(setDisplaySettings(TextEditor::DisplaySettings))); |