diff options
| author | Eike Ziller <eike.ziller@qt.io> | 2018-04-20 15:45:11 +0200 |
|---|---|---|
| committer | Eike Ziller <eike.ziller@qt.io> | 2018-04-23 11:12:26 +0000 |
| commit | d1ec4c120410b7351fc31df659a7f3be7ed4e93f (patch) | |
| tree | 87f5c7c73ca95e2b2e14747fdc20659c79d5d59d /src/plugins/vcsbase | |
| parent | 4b9945c32981105bfae3ba59f9565757f0dc7417 (diff) | |
| download | qt-creator-d1ec4c120410b7351fc31df659a7f3be7ed4e93f.tar.gz | |
Clean up options page category display name and icon set up
In cases where plugins extend an existing settings category of a plugin
that they depend on anyhow, they do not need to specify the translated
display name and icon for that category.
Some options pages were already not setting the icon, but still the
translated name, which makes even less sense.
Clean up this mess, only setting display name and icon if that is
necessary.
Change-Id: I8bc9d0c51b11d48f1d847337838704d663e70b45
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Diffstat (limited to 'src/plugins/vcsbase')
| -rw-r--r-- | src/plugins/vcsbase/vcsbaseconstants.h | 2 | ||||
| -rw-r--r-- | src/plugins/vcsbase/vcsbaseoptionspage.cpp | 4 |
2 files changed, 2 insertions, 4 deletions
diff --git a/src/plugins/vcsbase/vcsbaseconstants.h b/src/plugins/vcsbase/vcsbaseconstants.h index b02f14e136..05b02a1ba7 100644 --- a/src/plugins/vcsbase/vcsbaseconstants.h +++ b/src/plugins/vcsbase/vcsbaseconstants.h @@ -31,8 +31,6 @@ namespace VcsBase { namespace Constants { const char VCS_SETTINGS_CATEGORY[] = "V.Version Control"; -const char VCS_SETTINGS_TR_CATEGORY[] = QT_TRANSLATE_NOOP("VcsBase", "Version Control"); -const char SETTINGS_CATEGORY_VCS_ICON[] = ":/vcsbase/images/category_vcs.png"; const char VCS_COMMON_SETTINGS_ID[] = "A.VCS.General"; const char VCS_COMMON_SETTINGS_NAME[] = QT_TRANSLATE_NOOP("VcsBase", "General"); diff --git a/src/plugins/vcsbase/vcsbaseoptionspage.cpp b/src/plugins/vcsbase/vcsbaseoptionspage.cpp index 8a7b038a6b..6ca261c9ee 100644 --- a/src/plugins/vcsbase/vcsbaseoptionspage.cpp +++ b/src/plugins/vcsbase/vcsbaseoptionspage.cpp @@ -47,8 +47,8 @@ namespace VcsBase { VcsBaseOptionsPage::VcsBaseOptionsPage(QObject *parent) : Core::IOptionsPage(parent) { setCategory(Constants::VCS_SETTINGS_CATEGORY); - setDisplayCategory(QCoreApplication::translate("VcsBase", Constants::VCS_SETTINGS_TR_CATEGORY)); - setCategoryIcon(Utils::Icon(Constants::SETTINGS_CATEGORY_VCS_ICON)); + setDisplayCategory(QCoreApplication::translate("VcsBase", "Version Control")); + setCategoryIcon(Utils::Icon(":/vcsbase/images/category_vcs.png")); } VcsBaseOptionsPage::~VcsBaseOptionsPage() = default; |