diff options
| author | hjk <hjk@qt.io> | 2017-07-13 15:24:04 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2017-07-17 12:28:50 +0000 |
| commit | cd5ba755056a70f86fa6b9d7789090f9c84927de (patch) | |
| tree | 386937f16c91069eadd16f56f6542fa83726242e /src/plugins/valgrind/valgrindengine.cpp | |
| parent | c8054d9547ffffd9300340d48033e9f75f3f3e7b (diff) | |
| download | qt-creator-cd5ba755056a70f86fa6b9d7789090f9c84927de.tar.gz | |
ProjectExplorer: Use a real 'finishing' phase for RunControls
Instead of a blunt delete() RunControl::initiateFinish() is triggered
by the closing of the application output instead. The rampdown process
is basically the same as stop() now, except for the other success
signal (new finished()) and the final self-destruction of the
runcontrol.
stop() itself triggers initiateStop() on all running workers in
parallel (before it was in the order of start). This gives
downstream complex worker combinations the flexibility to use any
order it wants by ignoring stop() on 'uninteresting' workers,
and centralizing rampdown e.g. in the main worker. That setup should
be rare in practice, but seems needed in some profiler cases.
Change-Id: I986a152a663754206709ed4df0d4568847afad17
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/valgrind/valgrindengine.cpp')
| -rw-r--r-- | src/plugins/valgrind/valgrindengine.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/plugins/valgrind/valgrindengine.cpp b/src/plugins/valgrind/valgrindengine.cpp index 3cb1a4245b..13beca1fa0 100644 --- a/src/plugins/valgrind/valgrindengine.cpp +++ b/src/plugins/valgrind/valgrindengine.cpp @@ -106,7 +106,6 @@ void ValgrindToolRunner::stop() { m_isStopping = true; m_runner.stop(); - reportStopped(); // FIXME: Restrict to non-running scenarios? } QString ValgrindToolRunner::executable() const |